View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0021737 | mantisbt | other | public | 2016-10-03 11:51 | 2016-10-30 23:22 |
Reporter | atrol | Assigned To | atrol | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Target Version | 1.3.3 | Fixed in Version | 1.3.3 | ||
Summary | 0021737: Users can't remove their real name from their account | ||||
Description | Real name can't be removed by using the My Account page. | ||||
Tags | No tags attached. | ||||
I didn't look at the PR, but do we really want to allow users to remove their email address ? A lot of functionality relies on being able to send emails (e.g. password reset). |
|
not complete sure, but is it that bad?
|
|
That has always bothered me actually. IMO, we should ideally enforce a valid address, by only allowing the change after an activation e-mail has been actioned by the user (similar to new user account validation). But I guess that's outside the scope of this change. I still feel it's conceptually wrong to set the email to blank (whether it's done by admin or user, makes no difference). Using that as a trick to deactivate notifications, is also wrong. If this is a valid use case, then we should offer a "mute all notifications" option in the user profile, or something similar. |
|
Changed description and updated PR to deal just with real name.
Changing by admin is still possible and not changed in this PR as it's outside the scope of the change |
|
There are a couple of reasons where it makes sense for an admin to remove their email address:
The admin should have the power to do this for whatever reason. At the end of the day, if a user wants to reset their password and their email is blank, they will contact the admin to help them.
I think that users should be able to change their email address, however, to handle this properly we need to have the concept of email vs. pending_email (or a token for storing pending email). When user modifies their email address, we have it as pending until the user verifies it, and then it gets set as email. |
|