View Issue Details

IDProjectCategoryView StatusLast Update
0021986mantisbtuipublic2016-11-30 07:13
Reportersebastian.poxhofer Assigned To 
PrioritynormalSeverityfeatureReproducibilityalways
Status newResolutionopen 
Product Version2.0.0-rc.2 
Summary0021986: set the at resolving set resolution as default at closing
Description

When a issue is resolved, the resolution is not set as default for closing.
This lead to many false resolutions as on close the resolution jumps back to "fixed".

Additional Information

When I have time I will look into it and will maby provide a pull request

TagsNo tags attached.

Activities

sebastian.poxhofer

sebastian.poxhofer

2016-11-29 15:46

reporter   ~0054636

@atrol this fixed my issues:

diff --git a/bug_change_status_page.php b/bug_change_status_page.php
index 77408ca..55c4cee 100644
--- a/bug_change_status_page.php
+++ b/bug_change_status_page.php
@@ -165,8 +165,9 @@
</thead>
<tbody>
<?php

  • $t_current_resolution = $t_bug->resolution;
  • $t_bug_is_open = $t_current_resolution < $t_resolved;
  • $t_current_solution = $t_bug->resolution;
  • $t_current_status = $t_bug->status;
  • $t_bug_is_open = $t_current_status < $t_resolved;

    if( $f_new_status >= $t_resolved && ( $f_new_status < $t_closed || $t_bug_is_open ) ) {
    ?>

Some details:
Before the resolved threshold was compared to the, at the moment, set resolution type.
I have changed this so it will compare the resolved threshold with the status of the bug

cproensa

cproensa

2016-11-29 17:14

developer   ~0054637

What if...
<pre>
$t_bug_is_open = $t_current_resolution < config_get( 'bug_resolution_fixed_threshold' );
</pre>

cproensa

cproensa

2016-11-29 17:49

developer   ~0054639

related read: 0015653

sebastian.poxhofer

sebastian.poxhofer

2016-11-30 05:36

reporter   ~0054643

In that case we have following problems during this workflow:

  1. opening issue
  2. confirm issue
  3. closing issue
  4. reopening to confirmed
  5. resolve issue

At 3 no resolution listbox is shown (neither is the default resolution applied).
At 5 the "reopened" resolution set as default and not fixed. In my opinion a minor issue, but anoying.

I will look later into it.
greetings

Issue History

Date Modified Username Field Change
2016-11-29 14:02 sebastian.poxhofer New Issue
2016-11-29 15:46 sebastian.poxhofer Note Added: 0054636
2016-11-29 17:14 cproensa Note Added: 0054637
2016-11-29 17:49 cproensa Note Added: 0054639
2016-11-30 05:36 sebastian.poxhofer Note Added: 0054643