View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0023970 | mantisbt | html | public | 2018-02-13 01:20 | 2018-03-04 00:36 |
| Reporter | libregeek | Assigned To | dregad | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | no change required | ||
| Product Version | 2.11.0 | ||||
| Summary | 0023970: Missing print_bracket_link in print_api | ||||
| Description | The print_bracket_link() in core/print_api.php is missing in 2.11 branch. This method is present in 2.10 branch and it's being used by one of our private plugins. I couldn't find any change/deprecation log on this method. | ||||
| Tags | No tags attached. | ||||
|
We don't have a clear rule for removing functions. The function was removed as part of PR https://github.com/mantisbt/mantisbt/pull/1259 as it's no longer used in code and makes not that much sense in modern UI of 2.x. @vboctor might comment, as he approved the PR. |
|
|
My plugins are affected too
We usually deprecate. |
|
|
My intend was not to break anything, but just to cleanup code. @cproensa @libregeek do you think we should reintroduce the function? To prevent this situation in future, It would be good if you could invest some time to have a look at least at approved PRs. |
|
Not at this point FYI: I have solved it by copying the old function within my plugin namespace. |
|
|
I'm not against deprecating functions, but it would be nice to mention such deprecations in release notes. Thus plugin developers can take a quick look at the release notes and fix it without doing a blind upgrade and breaking the production environments. |
|
I've changed issue 0023754's title to make the function removal appear in the change log.
The "clean" way would have been to leave the function in, while having it trigger a USER_DEPRECATED error, and actually remove it in a later release. To keep in mind for future code cleanups :-) |
|
Any function? Does it mean that we also have to announce changes like incompatible function signature changes, removal/renaming of CSS classes, ...? |
|