View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0025446||mantisbt||ui||public||2019-02-06 11:40||2019-02-17 05:14|
|Priority||normal||Severity||minor||Reproducibility||have not tried|
|Target Version||2.20.0||Fixed in Version|
|Summary||0025446: 'show_queries_count' is a global setting, but 'show_memory_usage', 'show_timer' are not|
|Tags||No tags attached.|
I believe config options that are related to instrumentation and diagnostics should be required to be global, since they can expose information about the server, overwrite a critical file with a log file, etc. These should be controlled via IT admin / hoster via
In general, I prefer config_get_global for such kind of settings, because of better performance and security.
As mentioned by @cproensa there is no reason to prevent setting show_queries_count in database as long as we allow settings like show_memory_usage, show_timer to be set in database.
I think we should merge the PR and start the general discussion in #25460 (IMO something that could just be changed in 3.x)
I understand the reasons for #0025460. But also the settings referenced here don't have any impact on security, or side effects with application functionality, system files, etc.
I think the point here is: all of them should have the same treatment. I don't really mind if it's to use them as config-file only, or not.
Ok, so there is now PR https://github.com/mantisbt/mantisbt/pull/1466
|2019-02-06 11:40||cproensa||New Issue|
|2019-02-07 03:09||atrol||Assigned To||=> atrol|
|2019-02-07 03:09||atrol||Status||new => assigned|
|2019-02-07 03:09||atrol||Target Version||=> 2.20.0|
|2019-02-07 03:15||atrol||Note Added: 0061431|
|2019-02-08 22:17||vboctor||Note Added: 0061458|
|2019-02-09 15:11||atrol||Note Added: 0061468|
|2019-02-16 17:03||vboctor||Note Added: 0061508|
|2019-02-16 20:24||cproensa||Note Added: 0061509|
|2019-02-17 05:14||atrol||Note Added: 0061512|