View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0025962||mantisbt||bugtracker||public||2019-08-04 19:09||2019-08-25 12:36|
|Target Version||2.22.0||Fixed in Version||2.22.0|
|Summary||0025962: IssueAddCommand does not create history entries identical to the code it replaced|
IssueAddCommand was introduced in 2.13.0 via 0023998.
Executing PHPUnit tests as follows:
The test case is documented to create a new issue with non-default status and resolution and validate that history entries are created for the status and resolution.
Offending commit according to git bisect is MantisBT master b03448f2
|Tags||No tags attached.|
@vboctor you stated in chat
Looking at the history of the change (see 0014678, and more specifically MantisBT master 921a4005 ), it appears to be fully intentional (i.e. not a "side effect") that status and resolution were logged separately after issue creation. I can understand the reasoning behind @rombert's original implementation, which better documents that the issue was opened and immediately resolved.
I'm not saying that's correct, but at least that explains why it was done that way.
After discussion we agreed that the new behavior will be kept, so the unit tests will be adjusted accordingly.
PR 1538 has been closed, and the change included in https://github.com/mantisbt/mantisbt/pull/1540
MantisBT: master b13c301e
Committer: dregad Details Diff
|Fix test case to expect one history entry
When creating an issue with non-default status/resolution, check that a single entry is created.
|mod - tests/soap/IssueHistoryTest.php||Diff File|
|2019-08-04 19:09||dregad||New Issue|
|2019-08-04 19:09||dregad||Status||new => assigned|
|2019-08-04 19:09||dregad||Assigned To||=> vboctor|
|2019-08-04 19:09||dregad||Relationship added||related to 0023998|
|2019-08-04 19:10||dregad||Relationship added||related to 0025961|
|2019-08-04 21:19||vboctor||Note Added: 0062507|
|2019-08-05 04:29||dregad||Note Added: 0062509|
|2019-08-05 04:30||dregad||Relationship added||related to 0014678|
|2019-08-05 04:30||dregad||Note Edited: 0062509||View Revisions|
|2019-08-20 03:56||dregad||Note Added: 0062613|
|2019-08-24 22:19||dregad||Changeset attached||=> MantisBT master b13c301e|
|2019-08-24 22:19||vboctor||Status||assigned => resolved|
|2019-08-24 22:19||vboctor||Resolution||open => fixed|
|2019-08-24 22:19||vboctor||Fixed in Version||=> 2.22.0|
|2019-08-25 12:36||vboctor||Status||resolved => closed|