|
|
This is @dregad note:
The PHPDoc says * * @param boolean $p_log_insert Create history logs for new values.*
So, the previous behavior is consistent with that. if we change it, then the PHPDoc needs to be updated accordingly.
Currently, this parameter is only used by mci_issue_set_custom_fields()
when called from mc_issue_update() it is set to true
when called from IssueAddCommand::process(), it is set to false.
In my opinion, it makes sense not to have a history entry when the issue is created, but it is correct to always have one whenever the custom field is updated (which if I'm not mistaken, is what the original implementation was doing).
Based on that, I believe that this change should not be merged. Unless I missed another use case ? If so, please explain the rationale
Being the lowest level entry point to update a custom field, i expected that the option to bypass history logs makes sense to be optional on both insert, and update, of the field value.
Other use cases, is updating custom fields from plugins. I have several plugins that use custom fields in a way that i'd rather not add history logs, because its data that is not directly intended for the user. |
