View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0028335 | Plugin - EmailReporting | General | public | 2021-04-22 15:55 | 2026-10-21 12:00 |
| Reporter | bradbulger | Assigned To | SL-Gundam | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 0.10.1 | ||||
| Summary | 0028335: Body of plain text email missing from "Complete email" attachment | ||||
| Description | We have "remove all replies" checked, the identifying string is "-----Original Message-----". Sending mail from Outlook to Mantis, not only is all the content below that string removed from the comment on the ticket, but the entire body of the email is missing from the "Complete email" attachment. Looking at the parsed version of the debug copy, the original body is in [X-Mantis-Body], but none of it is in [X-Mantis-Parts][body]. When people forward a pre-existing email chain to Mantis, either to open a ticket or add information to an existing one, the interesting content is in the forwarded message, which gets removed from the Mantis entry. That could be acceptable if it was available in the "Complete email", but as it is now, it is completely lost. | ||||
| Tags | No tags attached. | ||||
| Attached Files | parsed_msg_1619119801_1a242ca4a713aaac35dd1060913df0cf (12,736 bytes)
array (
'From_parsed' =>
array (
'name' => 'Bulger, Brad (ARC-SGG)[Bay Area Environmental Research Institute]',
'email' => 'bradford.bulger@nasa.gov',
'From' => '"Bulger, Brad (ARC-SGG)[Bay Area Environmental Research Institute]" <bradford.bulger@nasa.gov>',
),
'Reporter_id' => 6,
'Subject' => 'FW: [EXTERNAL] Re: A plain text saga [1332]',
'To' =>
array (
0 => 'support@cloud1.arc.nasa.gov',
),
'Cc' =>
array (
),
'X-Mantis-Body' => 'Forwarding a plain text message with indents on, but I think it\'s the OM line that\'s key.
-----Original Message-----
From: Brad Bulger <bulger@baeri.org>
Date: Thursday, April 22, 2021 at 12:22 PM
To: "Bulger, Brad (ARC-SGG)[Bay Area Environmental Research Institute]" <bradford.bulger@nasa.gov>
Subject: [EXTERNAL] Re: A plain text saga
I think there is a flaw in your argument.
-----Original Message-----
From: "Bulger, Brad (ARC-SGG)[Bay Area Environmental Research Institute]" <bradford.bulger@nasa.gov>
Date: Thursday, April 22, 2021 at 12:08 PM
To: Brad Bulger <bulger@baeri.org>
Subject: A plain text saga
No fuss, no muss',
'X-Mantis-Parts' =>
array (
0 =>
array (
'name' => 'Complete email.txt',
'ctype' => 'text/plain',
'body' => 'Return-Path: <bradford.bulger@nasa.gov>
X-Original-To: support@cloud1.arc.nasa.gov
Delivered-To: support@cloud1.arc.nasa.gov
Received: from pagent2.arc.nasa.gov (pagent2.arc.nasa.gov [128.102.12.132])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by cloud1.arc.nasa.gov (Postfix) with ESMTPS id CD92929C0361
for <support@cloud1.arc.nasa.gov>; Thu, 22 Apr 2021 12:23:31 -0700 (PDT)
Authentication-Results: cloud1.arc.nasa.gov;
dkim=pass (2048-bit key; unprotected) header.d=nasa.gov header.i=@nasa.gov header.b=F6oawZUM;
dkim=pass (1024-bit key; unprotected) header.d=nasa.gov header.i=@nasa.gov header.b=IaiClA6k;
dkim-atps=neutral
Received: from ndjsvnpf102.ndc.nasa.gov (NDJSVNPF102.ndc.nasa.gov [198.117.1.152])
by pagent2.arc.nasa.gov (8.16.1.2/8.16.1.2) with ESMTPS id 13MJNUW1020146
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)
for <support@cloud1.arc.nasa.gov>; Thu, 22 Apr 2021 12:23:31 -0700
Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a01:111:f400:7d04::203; helo=gcc02-dm3-obe.outbound.protection.outlook.com; envelope-from=bradford.bulger@nasa.gov; receiver=support@cloud1.arc.nasa.gov
DKIM-Filter: OpenDKIM Filter v2.11.0 ndjsvnpf102.ndc.nasa.gov 8F7FA400AF12
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nasa.gov;
s=letsgomars; t=1619119410;
bh=5cWzUdSwV6tKPER0X1pCAfPf3j+iCXklaThsKdaXvl8=;
h=From:To:Subject:Date:From;
b=F6oawZUMeuIwrCywTRnoxeQMDMdbiUKljKwQSRVIiPQchWfge9Hv0FPXzEU72Tbe8
G/PwgV1T87Ldk8DPex3kp0VO0N7y06HL02UDifhPGfhHkb91ps1ieHGZG+rmawjv0c
kGGfn6rqe/ClrjMxnBsZZoeBcdEmppBt9M3+3F+wfl1j49dqz2IQXVE+88qI3AMnde
YiUMfbz1DqTQyLnt/z4ZF07otr1rQgzdB98c7tDXO9r5EqKXfM1Gf2d5Cs6YvDjvKT
diK4wqVsxPxUc9CV644F9ZNFeMkcs6UxY0KTP3EoGuuyf7UovuDmtOjvdZCfGCNV1/
EUovHb1k4XsGQ==
Received: from GCC02-DM3-obe.outbound.protection.outlook.com (mail-dm3gcc02lp20203.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d04::203])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by ndjsvnpf102.ndc.nasa.gov (Postfix) with ESMTPS id 8F7FA400AF12
for <support@cloud1.arc.nasa.gov>; Thu, 22 Apr 2021 14:23:30 -0500 (CDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=P48nWmPPD6bClMVdg8sodgN/LcX4tl9JLYryL97eto8MWpJglkgVb7tUfja+JxDlCpj/VNNN1Ag0UCjM6mSx7MdepTeJX6FdwV51GKLF+/trnHBOjRREOryXXaAFT3U6A2WYsPRvK1bQbh/OYzbRsXuk1c6j5Ziz5B5W83Uq9NQMK8BhjFNK4IY2xydzdmZnzF48/mMDtfQlKQU0OG4d3SjOSNea/rQ8KuPyUpQWjlo6PEtrqN4M7Wkftyvv38ER31ff56CwzcPYZ9WNG5Je41Fv/rKgtggOvJbZcJcisnk+SmcA4c60hPjzF5h+bWK4CBLFv2xpilXNFr2yU2Z8OQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=5cWzUdSwV6tKPER0X1pCAfPf3j+iCXklaThsKdaXvl8=;
b=ienlFqK/xfx/t6eP+fvZOB35LdltIEhNTut0XiVJi7HKpV8+XLVXxpL8bHB4rT/v4fIvDfRxuELGYq154sLZVJ8ThHUxCRZU+9md710LfDRdBZlaaFO3SyKWQriWqbOnv8+zELMYn9TRF4bWGheza7sEMrHfsM7sNfuGO3HxIlmMylLnhUYvwS3ny5qAeNQoc+ZGoPEN1RfzjQEDI7HDhZ9iKwn+PGJRWc+3sT2tJufpILNRiw7TCBIEXTZ78Qu0hrFNox4mVxwzheRZbThIqE4H7Nt73pShwpXbUH30kjG1rF4vi/umZgu203zLeiuUV6OYYiMWjgPIewrZOdY+5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=nasa.gov; dmarc=pass action=none header.from=nasa.gov;
dkim=pass header.d=nasa.gov; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nasa.gov; s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=5cWzUdSwV6tKPER0X1pCAfPf3j+iCXklaThsKdaXvl8=;
b=IaiClA6kGs81cgpHFjFI+FdZz3vypoj9uomQd4phwh4GyXVrdtDQs1I2KkebgLQPxhu+uzvSuwXtK5GehN39IzDzzcnKDCJjVyL5dkFfDpY27x/HXogVb2d2soK/Cfm4fM9t6//9gpnO1Vo8GExvddQP/Raa6XXH+xK87hTXBBI=
Received: from BY5PR09MB5586.namprd09.prod.outlook.com (2603:10b6:a03:24d::21)
by BY5PR09MB5921.namprd09.prod.outlook.com (2603:10b6:a03:24b::8) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Thu, 22 Apr
2021 19:23:29 +0000
Received: from BY5PR09MB5586.namprd09.prod.outlook.com
([fe80::8502:57c6:7435:666]) by BY5PR09MB5586.namprd09.prod.outlook.com
([fe80::8502:57c6:7435:666%5]) with mapi id 15.20.4065.020; Thu, 22 Apr 2021
19:23:29 +0000
From: "Bulger, Brad (ARC-SGG)[Bay Area Environmental Research Institute]"
<bradford.bulger@nasa.gov>
To: Mantis Bug Tracker <support@cloud1.arc.nasa.gov>
Subject: FW: [EXTERNAL] Re: A plain text saga [1332]
Thread-Topic: [EXTERNAL] Re: A plain text saga [1332]
Thread-Index: AQHXN6z5YbILxE3FNkS++OtamjhT2Q==
Date: Thu, 22 Apr 2021 19:23:29 +0000
Message-ID: <C8DB9831-4CCE-4C2C-8D9C-BBDC467A2A1F@nasa.gov>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/16.48.21041102
authentication-results: cloud1.arc.nasa.gov; dkim=none (message not signed)
header.d=none;cloud1.arc.nasa.gov; dmarc=none action=none
header.from=nasa.gov;
x-originating-ip: [192.92.190.42]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b1ab0462-109c-4801-a21c-08d905c41c2a
x-ms-traffictypediagnostic: BY5PR09MB5921:
x-ms-exchange-atpmessageproperties: SA|SL
x-microsoft-antispam-prvs:
<BY5PR09MB59215D255256BCE4F54A8EBE98469@BY5PR09MB5921.namprd09.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5516;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
BEYdjc48nBYcqGHcbbDG2K/dZExtqwx4rx9Hl/THY163SPtoxh98/NRNpDVtEjqehp7z5D4gK0pctNtlYR5cqNs37Kaqc9+3WUxEedOKIE4G+mhuv64QsTl4OHF0zUSvCJH51RbdJFBgk1EG+kuws+oL94DV0H3SBg6pZ7+mkZW6JhsVGGvhjTLGdYLd9y3NCmTa68OqXpnm2tdz301DAT+n8A/ryUOTSCfHSkA4IRw6ByLckTr+fceJr7jLm6uhuoL0Jh10db1GOPEXgTwAwrirHoEhrmfe4L0CkLcDpGGKdSC0ROrGpNHUWIq7E9lP46V1bM9Jly7aej9No2tb+55kqkqyzcVNyHy5619VgN14w7gtjgAegiMNwrAko81tP+O7UY66DAFySC0jO3UXUDQYsXLfZiaEAdXr5+o2vUzCBum+VQUCdvrqzVovUi+q7QCbJtbraIE+LZDygCneU2QnsHAR/uQ9WR5e5Dk18r4U6Pn29ZUo1VlARQ8nEVUjsLaRoq+9B9314hv2ybKmXe26j9O5vBG71DMsMvpKmCpjPZ90F7WlZQ38XQ1KUh0rfz64PFzm8pyopc9eI7yNWyLROGTipAkNrSs6gatNpXLFSozkCgiDc1Ydr8CCqUJf3Lo9u1XpjYXtQ8hkPE79ecNU6FfiUfoyz7C3D2nlr3A=
x-forefront-antispam-report:
CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR09MB5586.namprd09.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(39860400002)(346002)(366004)(136003)(2616005)(71200400001)(83380400001)(33656002)(38100700002)(316002)(8936002)(186003)(26005)(36756003)(53546011)(6506007)(8676002)(478600001)(66946007)(4744005)(6916009)(6512007)(122000001)(2906002)(66446008)(66476007)(6486002)(64756008)(91956017)(5660300002)(66556008)(86362001)(76116006)(45980500001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata:
=?utf-8?B?RWRGcDh4dmI2WnhVaGhUd1BRdnVQNG9LWm1yak1QZHpHRnFnSXFLYW9EUk96?=
=?utf-8?B?S3ZNTCtIbUwrS3R6VGpJcG1HNC9OL2NuYjcyZ1RpOEIrZUEyamFVSkNLSlVU?=
=?utf-8?B?dURRYi9zZHFyaVFXRUdjZ2UwbjNhQ3VlU1pPOTZCYVBuOGJWQktDTmc4dStm?=
=?utf-8?B?QStEVSszMVAxODMreVJaRk82UHpMbHZraEpldUNRSDZHQUJUUHpMdXNZSmU1?=
=?utf-8?B?ck0yKzBYMzdnNTVONW5OTm1VTE1nU2V5Yk0vOU41eFIyWksxL0ZraEtkSFBK?=
=?utf-8?B?MXpVZHpISXNHQXlORlFnTlp0Lyt5UVEra3VSM0lrTUduQ0w2UmdKNjEzUUZR?=
=?utf-8?B?WFY5VlFBckRkZDl6NUJMTmdKTXpYZm52bCtKZEJPOUtla044eGE2TG9TTTFW?=
=?utf-8?B?YXk2Q0p6cGloeDBuYldTMy9IWXhqMEtOZ0cvS0NsZGpTOFNhSldyY1pOYWxS?=
=?utf-8?B?VDRBSTNTbjA0aE1zREN5dG0zV3R4YXZJanZRYzRLN0k5dDdyaGNobktJbllo?=
=?utf-8?B?SHJqZWV3Vk44MkNMNnpSU3NrSGtkZnJGT1pRdVlKdHovdnU1TUpLajVZSWxh?=
=?utf-8?B?UElvci9hVWJnOXB3TnNYYWVWeEFkZk1SMWxhSm5Mb3dnZFFhWVdhYUNJUURN?=
=?utf-8?B?VE9OUW1mSHVSeFBaUXRzYXp3NE1Xc0FRSUJ5MXkxNlUxejNTdUhJNHpnRytT?=
=?utf-8?B?SDhFZVE5TDJLTDRvSXhjejREUlJpTDF1YUUrSDhqZE1QTG02dzRSRWJHenAx?=
=?utf-8?B?QkpMeE51WFh0bnJ5bXEvamhNNTlhV093bENEUHplczhCcUl4ZkJWc3NvU2NC?=
=?utf-8?B?VDEzWGk5dnBnTkROVDVZQXdGSkYvT3FFVVhqSGRnTzAvVWpHK2FrYmc4T3dz?=
=?utf-8?B?VXNlUlJhc3AzN1V6cFRnNHpUUmR0SUJ6ZkRST00rbXIwek9SUVdra3Uvd3FP?=
=?utf-8?B?K2xYWTJXQStOYzFtVEhqYmpSOFBDNXRWYmZaeGxaWWpzTmVrZzlqN0NRTTRw?=
=?utf-8?B?WHFSOVUxdFYwc01EdXIyeFlVcGdXSGxCcysyUGlONkFUUHhQN2oyN1NpbDdj?=
=?utf-8?B?OWEvQkc4VjUwZ1M3R211dW5ESjRyUGRiWS95MDZabXNSeitNamV5a0I5VmZT?=
=?utf-8?B?VXEwMmNSV1oxZ0FJVVN5eWZ4OE1BeGdmUGFKV0t4Nm9hRmFzYUVqRGhSWnpr?=
=?utf-8?B?a3MvK1JQYlltRWtuY284bDB5RUJ6UFBTRldBVS96bUpEVGpNcEVjRVRsdldY?=
=?utf-8?B?cmFDNVIvR3hFRkU0NWFoVHZpVWhNVHB1aEhUK3dtYWl5ZVI2L0ZPK1F0V0V1?=
=?utf-8?B?S0djNG51eUtDbWRoei8rMjZtOGE1YnJaTEc1S2ttbFM1S0dwNFZrR0NDeFVo?=
=?utf-8?B?OGl5enYxaTZkNjI5TmNCa2EzMHFINVJtbnQ2aFU2bko5S211QmVXMlVmeG4z?=
=?utf-8?B?RnQrT0JRR0dqcTlFWVo1cUJET1ZVOE5yU1RBM1BtT29wWkkxRjcwYzN6UWxu?=
=?utf-8?B?cElkczZxU1JRM29ha24raFpuVkVMeE5nVDducFpoZ21abnduNXdmQUlDZkNh?=
=?utf-8?B?aTVHWmEzSXREZ3h2UENGNUl3YXJDNHV1dk41Ump5ZTZ3OGVyUnBDb0NiajhL?=
=?utf-8?B?U3RIQzliVnFCdnJrOTBJb3ZzcFJBSTVxaHovSU9zVkJWQkJoQW81dFB1Ny9w?=
=?utf-8?B?RkpQRWZJR25ZeWFRWEdUd1dKTWVtTVJxcG0vMWdWV2VXRW5zQWNoWXl2U2lp?=
=?utf-8?Q?rmzRFPIhXvIZSkuQ4R8v8MmnPxrwcrjdXavhazJ?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <31E81F9FF07174489F9FD1D44944DDC9@namprd09.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: nasa.gov
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR09MB5586.namprd09.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1ab0462-109c-4801-a21c-08d905c41c2a
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2021 19:23:29.1829
(UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 7005d458-45be-48ae-8140-d43da96dd17b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR09MB5921
X-Proofpoint-GUID: n6bjdg7Ja5EIgPv_gsYtnrk8JmfZwrae
X-Proofpoint-ORIG-GUID: n6bjdg7Ja5EIgPv_gsYtnrk8JmfZwrae
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761
definitions=2021-04-22_12:2021-04-22,2021-04-22 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0
mlxlogscore=977 phishscore=0 suspectscore=0 bulkscore=0 spamscore=0
mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
engine=8.12.0-2104060000 definitions=main-2104220142
X-Proofpoint-Bar:
Rm9yd2FyZGluZyBhIHBsYWluIHRleHQgbWVzc2FnZSB3aXRoIGluZGVudHMgb24sIGJ1dCBJIHRo
aW5rIGl0J3MgdGhlIE9NIGxpbmUgdGhhdCdzIGtleS4NCg0K77u/LS0tLS1PcmlnaW5hbCBNZXNz
YWdlLS0tLS0NCkZyb206IEJyYWQgQnVsZ2VyIDxidWxnZXJAYmFlcmkub3JnPg0KRGF0ZTogVGh1
cnNkYXksIEFwcmlsIDIyLCAyMDIxIGF0IDEyOjIyIFBNDQpUbzogIkJ1bGdlciwgQnJhZCAoQVJD
LVNHRylbQmF5IEFyZWEgRW52aXJvbm1lbnRhbCBSZXNlYXJjaCBJbnN0aXR1dGVdIiA8YnJhZGZv
cmQuYnVsZ2VyQG5hc2EuZ292Pg0KU3ViamVjdDogW0VYVEVSTkFMXSBSZTogQSBwbGFpbiB0ZXh0
IHNhZ2ENCg0KICAgIEkgdGhpbmsgdGhlcmUgaXMgYSBmbGF3IGluIHlvdXIgYXJndW1lbnQuDQoN
CiAgICAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KICAgIEZyb206ICJCdWxnZXIsIEJyYWQg
KEFSQy1TR0cpW0JheSBBcmVhIEVudmlyb25tZW50YWwgUmVzZWFyY2ggSW5zdGl0dXRlXSIgPGJy
YWRmb3JkLmJ1bGdlckBuYXNhLmdvdj4NCiAgICBEYXRlOiBUaHVyc2RheSwgQXByaWwgMjIsIDIw
MjEgYXQgMTI6MDggUE0NCiAgICBUbzogQnJhZCBCdWxnZXIgPGJ1bGdlckBiYWVyaS5vcmc+DQog
ICAgU3ViamVjdDogQSBwbGFpbiB0ZXh0IHNhZ2ENCg0KICAgICAgICBObyBmdXNzLCBubyBtdXNz
DQoNCg0KDQo=',
),
),
'Priority' => 30,
'Message-ID' => '<C8DB9831-4CCE-4C2C-8D9C-BBDC467A2A1F@nasa.gov>',
'References' =>
array (
),
'In-Reply-To' => NULL,
) | ||||
|
Complete email.txt is a debug feature and is designed to attach the raw_msg as an attachment to the issue. The email uses base64 encoding.
What you should do is disable debugging features as they are designed to find issues and not for production usage. As i see it you have 2 options.
|
|
|
I only turned on debugging to, you know, debug it. I had wondered if it was encrypting the body, I thought that was some kind of Proofpoint signature block. The clear text is in the parsed version of the debugging output, so it must be available. I guess the issue is that the "Complete email" is an attachment of the raw email. Maybe I can rig something up. We had already had mail_max_email_body_add_attach set to Yes, so I am not sure what you mean about it. |
|
|
Oh I see you're saying that attaching the original email is a debugging feature, not meant for production use? I guess we just disagree, then, it has always been a valuable feature. This current issue is our own organization making things harder on us now, it looks like. |
|
|
Sorry my mistake option 2 does not apply since it triggers on truncation because of length not because stripping replies or signatures. It's possible to create your own plugin for MantisBT and hook it into MantisBT/EmailReporting events. Don't know whether they provide enough information but we could fix that if needed. You could also quick fix it by doing the following
Modify as needed |
|
|
Yes, a patch and then a plugin sounds like the way to go. If this business with encoded body text isn't already a known thing, I guess that means it's not too common yet. Thanks for your help. |
|
|
Encoded body text is standard for email systems. There are different methods but base64 is one of them. If you run into any issues with writing your plugin please let me know so that we can see what changes are required |
|