View Issue Details

IDProjectCategoryView StatusLast Update
0002962mantisbtbugtrackerpublic2003-12-13 04:46
Reporterkilroysoft Assigned Tojfitzell  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0002962: Call-time pass-by-reference
Description

Warning: Call-time pass-by-reference has been deprecated - argument passed by value; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. However, future versions may not support this any longer. in /home/sites/site18/users/bugs/web/view_all_bug_page.php on line 36

Causes halt due to text before headers.

Additional Information

PHP Version 4.1.2
Linux rev66.dhcp 2.2.16C28_III 0000001 Mon Jul 30 22:07:58 PDT 2001 i586 unknown
Apache/1.3.20

TagsNo tags attached.

Activities

jfitzell

jfitzell

2003-02-19 20:59

reporter   ~0003741

thanks, I've known about this for a while but it's good to have an issue file for it

kilroysoft

kilroysoft

2003-02-20 08:12

reporter   ~0003750

To resolve this bug :

cvs_export.php (26)
$t_bug_count = null;
$t_page_count = null;
$p_per_page = -1;
$f_page_number = 1;

$rows = filter_get_bug_rows( $f_page_number, $p_per_page, $t_page_count, $t_bug_count );

core/filter_api.php (20)
function filter_get_bug_rows( &$p_page_number, &$p_per_page, &$p_page_count, &$p_bug_count ) {

view_all_bug_page.php (33)
$t_bug_count = null;
$t_page_count = null;
$p_per_page = null;

$rows = filter_get_bug_rows( $f_page_number, $p_per_page, $t_page_count, $t_bug_count );

I hope this helps

jfitzell

jfitzell

2003-02-20 09:09

reporter   ~0003751

Fixed in CVS, thanks for the recipe :)

Related Changesets

MantisBT: master f24ca774

2003-02-20 03:11

Julian Fitzell


Details Diff
Fix issue 0002962 'Call-time pass-by-reference'

Thanks to kilroysoft for the rough recipe for fixing it. I'm not 100% happy with the solution but it's the only easy one and at least it gets rid of the errors.

* csv_export.php: pass all the values for the filter function by reference

* view_all_bug_page.php: pass all the values for the filter function by
reference

* core/filter_api.php
(filter_get_bug_rows): indicate all parameters are to be passed by reference
and therefor, sadly, cannot be optional any more

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1971 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0002962
mod - core/filter_api.php Diff File
mod - csv_export.php Diff File
mod - view_all_bug_page.php Diff File