View Issue Details

IDProjectCategoryView StatusLast Update
0002995mantisbtbugtrackerpublic2004-08-29 02:16
ReporterBertHuijben Assigned Tothraxisp  
PrioritynormalSeverityfeatureReproducibilityalways
Status closedResolutionfixed 
Summary0002995: Bug email of 0002994
Description

The bug e-mail of 0002994 was a nice example of another bug itself.. (The hyperlink code was spelled out in the e-mail, instead of the bug id's itself)

Additional Information

Maybe the generation of hyperlinks in bugs should be done when rendering, instead of when reporting.

This makes nice features like rendering the hyperlink after the state possible. (striped-through is resolved, black = closed, etc)

TagsNo tags attached.

Activities

jfitzell

jfitzell

2003-02-24 11:34

reporter   ~0003802

It's actually supposed to be a link. But it's supposed to be the full link, not just the file name. (we could choose to change that policy of course)

I noticed it as well on that mailing and stared at the code for a while but didn't decide on a fix I was happy with. I need to think about where else we might want absolute URLs instead of relative ones.

thraxisp

thraxisp

2003-03-11 23:54

reporter   ~0003962

I've noticed that some email tools don't like the bug references in the email. Should they (the URL) be protected by brackets (<>)?

jfitzell

jfitzell

2003-03-12 07:45

reporter   ~0003965

what do you mean by "don't like" ? what do they do?

I noticed that Mail.app on OSX seems to include the line of === signs under the bug link as part of the link which makes absolutely no sense since there is a carriage return in between them.

thraxisp

thraxisp

2003-03-12 18:48

reporter   ~0003974

Mail.app was the one I noticed as well. I also reported it as a bug to Apple.

fatal

fatal

2003-04-20 23:44

reporter   ~0004221

In my humble opinion the buglink (0002995) should be written as # and the number, not as a link in the email. Ofcourse, this could be made into a configurable option. but "tainting" the comments with url's in the email i doubt would make anyone happy :)

jfitzell

jfitzell

2003-04-22 09:10

reporter   ~0004227

actually, I think I agree. The link to the bug on which the action was performed needs to be there but the rest are better displayed as links after you go view the bug.

thraxisp

thraxisp

2003-08-18 18:32

reporter   ~0004535

Here is my fix for this (protecting the URLs):

% diff mantis/core/string_api.php original_src/mantisbt/core/string_api.php
303c303
< return "<" . config_get( 'path' ) . string_get_bug_view_url( $p_bug_id, $p_user_id ) . ">";

          return config_get( 'path' ) . string_get_bug_view_url( $p_bug_id, $p_user_id );

original_src is a CVS snapshot from 8/15

grangeway

grangeway

2004-07-24 09:13

reporter   ~0006325

thraxisp - was this fix applied - can this be resolved now?

thraxisp

thraxisp

2004-07-26 12:01

reporter   ~0006369

This seems to have been fixed in the latest versions (probably of Apple Mail). The other mail tools I have access to seem to recognize the URLs now.

thraxisp

thraxisp

2004-07-28 11:04

reporter   ~0006418

I have found other mail tools that don't seem to accept split URLs (Eudora).

The original angle bracket enclosure was not added, but seemed to work in some areas.

I'll implement

thraxisp

thraxisp

2004-07-28 20:39

reporter   ~0006430

Here is my patch:

Index: core/email_api.php

RCS file: /cvsroot/mantisbt/mantisbt/core/email_api.php,v
retrieving revision 1.89
diff -r1.89 email_api.php
784c784
< $t_message .= $p_visible_bug_data['email_bug_view_url'] . "\n";

                  $t_message .= '<' . $p_visible_bug_data['email_bug_view_url'] . "> \n";
thraxisp

thraxisp

2004-07-29 05:49

reporter   ~0006436

Fixed brackets in CVS.