View Issue Details

IDProjectCategoryView StatusLast Update
0003002mantisbtbugtrackerpublic2003-12-13 04:45
Reporterslawek Assigned Tojfitzell  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Platformx86OSWindows 2000 ServerOS Version0.18-CVS
Product Versiongit trunk 
Summary0003002: User 'administrator' is not able to change other users settings
Description

Logon as administrator (or any other user with administrator access and enabled account protection). You should be able to change some users settings - for example language, but after clicking 'Update Prefs' button on page manage_user_edit_page.php you get error message 'ERROR: This account is protected. You are not allowed to access this until the account protection is lifted. (user_api.php: line 211)' on page account_prefs_update.php. It is caused by current_user_ensure_unprotected() function which is called with no clear reason (it's not current account being changed). I think that user_ensure_unprotected() with selected users' id should be called after reciving form data.

Steps To Reproduce

1) logon as administrator (or any protected user with admin access)
2) select some unprotected user account
3) try to change something and then click 'Update Prefs'

TagsNo tags attached.

Activities

jfitzell

jfitzell

2003-02-25 18:44

reporter   ~0003819

Fixed in CVS

Related Changesets

MantisBT: master 795e50b3

2003-02-25 12:46

Julian Fitzell


Details Diff
Fix issue 0003002 - "User 'administrator' is not able to change other users settings"

* account_prefs_update.php
+ check if $f_user_id is unprotected instead of the current user
+ if f_user_id is not the current user, perform an additional access check

NOTE: I'm not sure we should be sharing this file between the account section and
manage section. Having to add that conditional access check is a little ugly and
who knows if the pages will always be the same. Most of the code should be in an
API function anyway.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2026 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0003002
mod - account_prefs_update.php Diff File