View Issue Details

WikiRelated ChangesetsJump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0032038mantisbtemailpublic2023-02-20 04:442023-10-31 16:32
Reportersederther Assigned Tocommunity  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version2.25.5 
Target Version2.26.0Fixed in Version2.26.0 
Summary0032038: Missing In-Reply-To header in new bugnote email notification
Description

Hello,

I have noticed that email notifications about new bug notes does not have In-Reply-To header.
I am using Thunderbird email client and this emails are not being added to the main thread.

I've made some digging and i think the solution is to add the In-Reply-To header here
https://github.com/mantisbt/mantisbt/blob/master/core/email_api.php#L1047

Similar to this
https://github.com/mantisbt/mantisbt/blob/master/core/email_api.php#L1687

Is that the right way to solve this problem? If it is, i can submit a pull request in github.

TagsNo tags attached.

Relationships

Relationship GraphDependency Graph
has duplicate 0024982 closedatrol Notification for NOTE added starts a new thread/conversation due to lack of a proper In-Reply-To header 

Activities

dregad

dregad

2023-02-21 18:20

developer   ~0067410

@atrol, you marked this as related to 0024982, but after a quick look it seems to me this is in fact the same issue. If you agree, then this should be closed as duplicate.

@sederther That should indeed fix the problem, a pull request would be welcome. Please avoid code duplication, i.e. introduce a new function to generate the header as appropriate.
atrol

atrol

2023-02-22 10:25

developer   ~0067415

If you agree, then this should be closed as duplicate.

Right, had just very little time when triaging the issue and wanted to wait with closing the old one until we know if we will get a PR in the current issue that will fix exactly the old one.
Seems that @sederther started working on it, but deleted the first PR.
dregad

dregad

2023-02-22 17:32

developer   ~0067418

PR https://github.com/mantisbt/mantisbt/pull/1867

Related Changesets

MantisBT: master fd4b1c56

2023-02-22 10:43

sederther

Committer: dregad


Details Diff		 Adding In-Reply-To header to bugnote notification

Prevents start of a new thread/conversation in mail clients.

Fixes 0032038, PR https://github.com/mantisbt/mantisbt/pull/1867

Co-authored-by: Damien Regad <dregad@mantisbt.org>		 Affected Issues
0032038
mod - core/email_api.php Diff File