View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0033007 | mantisbt | code cleanup | public | 2023-10-08 06:30 | 2024-09-29 13:15 |
Reporter | dregad | Assigned To | dregad | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Target Version | 2.27.0 | Fixed in Version | 2.27.0 | ||
Summary | 0033007: Remove deprecated and incorrect usage of Pragma: no-cache header | ||||
Description | $g_allow_file_cache (if defined) triggers emission of a The pragma was added to fix an issue downloading large attachments - it is quite likely that this code is no longer useful nowadays - it was written in 2005. mantisbt/file_download.php Lines 154 to 164 in 262ecdd
We can probably get rid of the whole thing. | ||||
Additional Information | Originally posted in https://github.com/mantisbt/mantisbt/pull/1925#issuecomment-1729874609 This issue only covers the first part of that note (related to $g_allow_file_cache). Specifically, no further investigation has been made on this:
| ||||
Tags | No tags attached. | ||||
MantisBT: master 0bfe58b2 2023-12-02 10:49 Details Diff |
Remove usage of 'Pragma: no-cache' header It is a deprecated HTTP/1.0 thing that should be replaced with a Cache-Control header. Additionally we use it in an incorrect way, as the directive is only defined in a request context (not response). This was implemented as a workaround for an Internet Explorer bug, and we don't support this browser anymore. Fixes 0033007 |
Affected Issues 0033007 |
|
mod - file_download.php | Diff File | ||
MantisBT: master bafd41ed 2023-12-02 10:54 Details Diff |
Remove 'Pragma: public' header It was used for Internet Explorer compatibility, and we don't support this browser anymore. Fixes 0033007 |
Affected Issues 0033007 |
|
mod - file_download.php | Diff File | ||
MantisBT: master 943f427e 2023-12-03 12:47 Details Diff |
Remove unused $g_allow_file_cache config Issue 0033007 |
Affected Issues 0033007 |
|
mod - config_defaults_inc.php | Diff File | ||
mod - core/obsolete.php | Diff File | ||
mod - docbook/Admin_Guide/en-US/config/webserver.xml | Diff File |