View Issue Details

WikiRelated ChangesetsJump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0033012mantisbtadministrationpublic2023-10-10 10:592024-10-27 12:22
Reporterdregad Assigned Todregad  
PrioritynormalSeverityminorReproducibilityalways
Status assignedResolutionopen 
Target Version2.28.0 
Summary0033012: Don't abort Admin Checks after first failure unless it's critical
Description

Currently the Admin Checks' execution stops at the end of a given section (e.g. database, email) if any test within it fails.

They were implemented this way, because some of the tests are critical, and must be executed in a given sequence and pass otherwise it is not possible to continue running the Checks. However, only a small number of these tests are truly critical and require the process to abort if they fail.

It would be better if by default the whole Checks suite was always executed, and only aborted if a critical test fails.

This requires

  • introducing a concept of critical failure (meaning that if the test fails, then it is not possible to continue with the Checks), in addition to the existing fail, warn and info checks.
  • identify those truly critical tests that should cause the Admin Checks to abort. (database and paths checks would qualify, but a detailed analysis is needed)
Additional Information

Follows up on discussion in issue 0032787, starting with note 0032787:0068167.

TagsNo tags attached.

Relationships

Relationship GraphDependency Graph
related to 0032787 closeddregad Facilitate identification of user accounts sharing the same email 
related to 0034915 assigneddregad Reduce code duplication in Admin Checks 
related to 0024615 closeddregad admin/check : writability check for absolute_path_default_upload_folder with FAIL may be too restrictive 

Activities

dregad

dregad

2023-10-15 09:58

developer   ~0068216

@atrol your temporary workaround preventing the Admin Checks from aborting after failure in email checks has been committed MantisBT master 7ffc863d

Related Changesets

MantisBT: master 7ffc863d

2023-10-14 14:38

atrol

Committer: dregad


Details Diff		 Continue admin checks after failed email checks

Issue 0032787 introduces a new check for email addresses that can be hard
and time-consuming to fix when failing.

This change allows to run the remaining tests even if the email check
failed.

Signed-off-by: Damien Regad <dregad@mantisbt.org>

This is a temporary workaround that should be reverted when implementing
the fix for Issue 0033012. A @TODO comment was added in the code as a
reminder to do it when implementing a proper fix.

Initially submitted in PR https://github.com/mantisbt/mantisbt/pull/1928
(original commit message modified).		 Affected Issues
0032787, 0033012
mod - admin/check/index.php Diff File