At first focusing on tests/Mantis.

Tests for Helper

• Add new Test for Helper helper_api:::get_link_attributes()
• Rename current HelperTest to ArrayTransposeTest
• Organize them in an new subdirectory tests/Mantis/Helper
• Add a new HelperTest as a collection of smaller tests, but larger ones should get their own file

Not sure how many could easily created, but will try to cover helper_api.

Fixing

Found at least one bug in ConfigParserTest.

Arguments for ->assertEqual must be flipped.

public function testExtraTokensIgnore() {
// …
$this->assertEquals( $t_result, 1 ); 
// …
$this->assertEquals( $t_result, array() );
}

Modernizing

Namespaces and autoload

• Add a classmap to composer.json (at least for the includes that are needed for the tests)
• Add a psr-4 root for the tests.

    "classmap": [
        "core/classes"
    ],
    "autoload-dev": {
        "psr-4": {
            "Tests\\": "tests/"
        }
    },

From:

require_once 'MantisCoreBase.php';
require_once 'MantisEnum.class.php';

To:

namespace Tests\Mantis;

use MantisCoreBase;
use MantisEnum;

PHP language level

• Update to PHP language level 7.4
• Add type hints
• Add declaration for strict_types
• Array syntax from array() to []
• Replace assertEquals with the strict assertSame