View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0034614 | mantisbt | code cleanup | public | 2024-09-02 14:25 | 2024-09-29 13:15 |
| Reporter | dregad | Assigned To | dregad | ||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Target Version | 2.27.0 | Fixed in Version | 2.27.0 | ||
| Summary | 0034614: Refactoring GraphViz API and Workflow Graph | ||||
| Description | General code improvement and cleanup, suggested by static analysis warnings while working on Workflow Graph and graphviz_api.php. | ||||
| Tags | No tags attached. | ||||
|
MantisBT: master 1fcc1cfd 2023-09-29 11:20 Details Diff |
Use class constants instead of global defines Fixes 0034614 |
Affected Issues 0034614 |
|
| mod - core/graphviz_api.php | Diff File | ||
|
MantisBT: master 96521463 2023-09-29 11:24 Details Diff |
Define visibility of methods and properties Renamed protected methods (removed leaading `_`): - _print_graph_defaults() => print_graph_defaults() - _build_attribute_list() => build_attribute_list() Fixes 0034614 |
Affected Issues 0034614 |
|
| mod - core/graphviz_api.php | Diff File | ||
|
MantisBT: master a9530538 2023-09-29 11:32 Details Diff |
PHPDoc Fixes 0034614 |
Affected Issues 0034614 |
|
| mod - core/graphviz_api.php | Diff File | ||
|
MantisBT: master 7144abfe 2023-09-29 11:34 Details Diff |
Remove useless is_array() check Fixes 0034614 |
Affected Issues 0034614 |
|
| mod - core/graphviz_api.php | Diff File | ||
|
MantisBT: master 52b561ac 2024-09-02 12:45 Details Diff |
PHPDoc: reference Graphviz Visual Editor Useful to test validity of generated graphs. https://github.com/magjac/graphviz-visual-editor Fixes 0034614 |
Affected Issues 0034614 |
|
| mod - core/graphviz_api.php | Diff File | ||
|
MantisBT: master b0c95422 2024-09-02 13:07 Details Diff |
Refactor Workflow Graph Reduce code complexity and improve performance by - Using Status Id instead of label as Graph node id - Adding labels to graph nodes - Moving config_get() and lang_get() calls out of the loop Fixes 0034614 |
Affected Issues 0034614 |
|
| mod - workflow_graph_img.php | Diff File | ||
