View Issue Details

WikiRelated ChangesetsJump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0034682mantisbtbugtrackerpublic2024-09-20 10:052024-09-28 11:28
Reporterdregad Assigned Todregad  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Target Version2.26.4Fixed in Version2.26.4 
Summary0034682: Incorrect usage of lang_get_defaulted() for an URL
Description

When there is no specified label in a menu item, print_menu() uses an icon as a default instead; the URL used to build the HTML anchor tag in this case is passed on to lang_get_defaulted() instead of helper_mantis_url() which is wrong.

This never caused any noticeable harm, because

  • lang_get_defaulted() returned the parameter as-is when no matching language string is found,
  • URL was relative to current directory.
Additional Information

Regression introduced many years ago by commit MantisBT master b8e0279f

TagsNo tags attached.

Activities

dregad

dregad

2024-09-20 13:18

developer   ~0069248

PR https://github.com/mantisbt/mantisbt/pull/2029

Related Changesets

MantisBT: master-2.26 904f9235

2024-09-20 12:17

dregad


Details Diff		 Use helper_mantis_url(), not lang_get_defaulted()

The incorrect usage is a regression introduced many years ago by commit
b8e0279f7c1026bb27aaa5a1f3f09e5b9d8b08fc.

It never caused any noticeable harm, because with lang_get_defaulted()
the param is returned as-is when not found, and since it was used as URL
it would be relative to current directory.

Fixes 0034682		 Affected Issues
0034682
mod - core/html_api.php Diff File