View Issue Details

WikiRelated ChangesetsJump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0003473mantisbtbugtrackerpublic2003-12-22 06:262004-07-07 18:44
ReporterWandererAssigned Tovboctor  
PrioritynormalSeveritytrivialReproducibilityalways
Status closedResolutionfixed 
PlatformAnyOSAnyOS VersionAny
Product Version0.18.3 
Fixed in Version0.19.0a1 
Summary0003473: g_bug_resolved_status_threshold variable ignored
Description

bug_resolve in bug_api has now hardcoded status for resolved bugs instead of using declared g_bug_resolved_status_threshold



bug_set_field( $p_bug_id, 'status', RESOLVED );

must be, I suppose, changed to


global $g_bug_resolved_status_threshold;

...

bug_set_field( $p_bug_id, 'status', $g_bug_resolved_status_threshold);

Steps To Reproduce

Use different assignment for g_bug_resolved_status_threshold and "resolve" bug

TagsNo tags attached.
Attached Files
bug_api-patch.zip (399 bytes)

Activities

vboctor

vboctor

2004-02-05 18:54

manager   ~0004961

I guess there is two things that are meant by resolved:

  • Putting the bug in "resolved" status. This should be configurable.
  • Marking the bug as read-only, this probably needs to use a different configuration option.

The confusion is at the moment "bug_resolved_status_threshold" is used to reflect the read-only configuration which makes it a bit misleading.
vboctor

vboctor

2004-05-17 07:55

manager   ~0005524

The following was implemented and committed to CVS. This will be included in 0.19.0.

  • New Config: bug_readonly_status_threshold (default RESOLVED). Status threshold after which the issue is considered readonly.
  • New Config: update_readonly_bug_threshold (default MANAGER). Status threshold after which the user is allowed to edit readonly issues.
  • bug_resolved_status_threshold is now used rather than the hard-coded RESOLVED status when a bug is resolved.
Wanderer

Wanderer

2004-06-13 13:44

developer   ~0005695

Last edited: 2004-06-14 16:42

Error in bug_api does NOT allow using user-defined resolve-status

edited on: 06-14-04 16:42
Wanderer

Wanderer

2004-06-13 13:53

developer   ~0005696

Obviously

bug_set_field( $p_bug_id, 'status', config_get( 'bug_readonly_status_threshold' ) );

in bug_api must be

bug_set_field( $p_bug_id, 'status', config_get( 'bug_resolved_status_threshold' ) );

resolved != readonly
Wanderer

Wanderer

2004-06-15 04:53

developer   ~0005708

Patch for one-string fix attached :-)
Wanderer

Wanderer

2004-06-24 15:29

developer   ~0005796

Victor, please! Apply my patch - I hate undo changes in thunk from my branched bug_api every time, when it changed in HEAD
Wanderer

Wanderer

2004-06-24 15:36

developer   ~0005797

Reminder sent to vboctor

please, fix mistake...
vboctor

vboctor

2004-06-26 05:02

manager   ~0005799

Fixed in CVS. Will be included in 0.19.0. Sorry for the delay.

Related Changesets

MantisBT: master 9fdced85

2004-05-17 07:39

vboctor


Details Diff		 Enh 0003152: Adding notes and documents to resolved bugs.
Enh 0003505: Add a Bugnote to a resolved bug.
Enh 0003811: Allow private flag to be unset on resolved bugs.
Fix 0003473: g_bug_resolved_status_threshold variable ignored.
Fix 0003567: Reminders can be added for a readonly bug.

M config_defaults_inc.php
- New Config: bug_readonly_status_threshold (default RESOLVED). Status threshold after which the issue is considered readonly.
- New Config: update_readonly_bug_threshold (default MANAGER). Status threshold after which the user is allowed to edit readonly issues.

M core/email_api.php
- (email_format_bug_message): Use configurable resolved status.

M core/bug_api.php
- (bug_is_readonly): Modified to return true if issue is readonly, and user doesn't have access level to edit readonly issues.
- (bug_resolve): Modified to use bug_readonly_status_threshold rather than set status to hard-coded status RESOLVED.

M bugnote_add.php
M bug_reminder_page.php
M bug_reminder.php
M bug_update_advanced_page.php
M bug_update_page.php
- Check the readonly flag.

M view_all_inc.php
- Check the readonly flag and only display the edit pen for non-readonly issues, or if the user has threshold to edit readonly issues.

M bugnote_add_inc.php
M bugnote_edit_page.php
M bugnote_set_view_state.php
M bugnote_update.php
- Check the readonly flag rather than the resolved status.

M bug_view_advanced_page.php
M bug_view_page.php
- Check the readonly flag for the file upload.

M core/constant_inc.php
- Constant for new error message for attempting to edit readonly issues.

M core/html_api.php
- Use bug_is_readonly().
- Don't display Resolve button if issue is already resolved.

M lang/strings_english.txt
- New error message for attempting to edit a readonly issue.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2537 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9		 Affected Issues
0003473, 0003567
mod - lang/strings_english.txt Diff File
mod - core/constant_inc.php Diff File
mod - bug_update_advanced_page.php Diff File
mod - bugnote_edit_page.php Diff File
mod - bug_reminder_page.php Diff File
mod - core/email_api.php Diff File
mod - bug_view_page.php Diff File
mod - bug_reminder.php Diff File
mod - bug_view_advanced_page.php Diff File
mod - config_defaults_inc.php Diff File
mod - bugnote_add.php Diff File
mod - core/bug_api.php Diff File
mod - view_all_inc.php Diff File
mod - bugnote_update.php Diff File
mod - bugnote_set_view_state.php Diff File
mod - bug_update_page.php Diff File
mod - core/html_api.php Diff File
mod - doc/ChangeLog Diff File
mod - bugnote_add_inc.php Diff File