View Issue Details

IDProjectCategoryView StatusLast Update
0035093Plugin - EmailReportingGeneralpublic2025-01-06 15:39
Reportertomzero Assigned ToSL-Gundam  
PrioritynormalSeverityfeatureReproducibilityN/A
Status resolvedResolutionfixed 
Product Version0.10.1 
Summary0035093: Configuration option added to control whether resolved tickets should be reopened when adding notes
Description

Sorry for posting here but the forums are still down and I have no experience with contributing to open source projects.

I have implemented a modification that allows to control whether a bug should be reopened if further notes arrive via EmailReporting after the ticket has been resolved. I need this because we sometimes need to add logs or reports later for documentation purposes. The modification includes a new boolean value (mail_reopen_bugs) in the configuration (section feature configuration options), additions to the manage_config pages, additions to the language files EN, DE, ES as well as an adjustment in the Mail API to consider this option when creating the ticket / note.

Is there any interest in incorporating this addition into the plugin? If so, how should I proceed? I haven't found any information about how to contribute, neither in the Github project nor in the plugin's wiki page.

TagsNo tags attached.

Activities

tomzero

tomzero

2024-12-07 03:33

reporter   ~0069561

I'm not sure if I've made the purpose of the modification clear: It conditionally allows to suppress the reopening because so far it always reopens with respect to the global MantisBT configuration options

SL-Gundam

SL-Gundam

2024-12-07 19:26

manager   ~0069563

Forum or MantisBT ticket is fine.

EmailReporting tries to emulate MantisBT in user experience. Since MantisBT does not allow to disable this except with permissions, neither does EmailReporting.
We can evaluate the code if you provide a pull request on the EmailReporting github project page.
I understand you have little experience with github so if figuring out github is too much you can provide a download link to the changed files (please only the changed files). If the zipped package is small enough you might also be able to attach it to this ticket.

tomzero

tomzero

2024-12-08 07:20

reporter   ~0069567

I have opened a pull request: https://github.com/mantisbt-plugins/EmailReporting/pull/38

I tested with MantisBT 2.27.0, 2.26.4, and 2.25.2. Seems my VSC messed up the original tab size, unfortunately I didn't find out how to fix this.

This solution works for me, it may be too naive with respect to your quality requirements.

If this is merged I can also edit the plugin's wiki page to document the configuration option. I hope I haven't missed out sth. important.

tomzero

tomzero

2024-12-08 07:43

reporter   ~0069568

One more thought on this and its relevance. I have searched quite a while to suppress reopening and found a considerable number of discussions where this feature is asked for. Currently the standard proposition is to set $g_bug_readonly_status_threshold and $g_bug_resolved_status_threshold to large numbers (larger than the largest issue state value). This kind of works but messes up the my view page since this page refers to those thresholds when filtering issues.

tomzero

tomzero

2024-12-08 07:52

reporter   ~0069569

One more thing, sorry for spamming, but things come to my mind step by step. I still have $g_bug_readonly_status_threshold set to larger than the state value of CLOSED issues such that EmailReporting can add notes to closed issues. This should be mentioned in the plugin's wiki page and maybe at the configuration option, too.

SL-Gundam

SL-Gundam

2024-12-08 09:57

manager   ~0069571

I believe the readonly threshold is already mentioned on the wiki page. I will have look at your changes sometime soon.

SL-Gundam

SL-Gundam

2024-12-31 14:40

manager   ~0069629

Changes applied to 0.11.0-DEV

tomzero

tomzero

2025-01-06 06:51

reporter   ~0069638

That's great. Sorry for asking dumb questions: shall I create a changelog entry and if yes, how do I do it? Opening another pull request and changing the docs/CHANGELOG.txt? Or is it generated from the merges?

SL-Gundam

SL-Gundam

2025-01-06 15:39

manager   ~0069640

Already added it last week.
It's a manually created changelog entry

https://github.com/mantisbt-plugins/EmailReporting/commit/fbc4625b318248846eccb9c6d693f0450289338b