|
|
So the next version of MantisBT 2.28 will be with Parsedown 1.8?
Looks like MantisCoreFormatting plugin should be slightly updated:
SYSTEM WARNING
'Undefined array key "name"' in '...plugins\MantisCoreFormatting\core\MantisMarkdown.php' line 152
...
Detailed error information
Full path: ...plugins\MantisCoreFormatting\core\MantisMarkdown.php
Line number: 152
Stack trace
# Filename Line Class Type Function Args
0 ...parsedown\Parsedown.php 1792 MantisMarkdown -> element <array> { ['elements'] => <array> { [0] => <array> { ['text'] => 'Bug!' } }, ['autobreak'] => false }
...
|
|
|
|
So the next version of MantisBT 2.28 will be with Parsedown 1.8?
1.8, 2.0 or whatever they release next... Hoping they do it soon. |
|
|
|
PR: https://github.com/mantisbt/mantisbt/pull/2068 |
|
|
|
Another problem with Parsedown 1.8 is probably a bug in Parsedown...
After figuring out how to run PHPUnit tests (and fixing them for the new version), I noticed that two PHPUnit tests failed:
✘ Process emails with process_urls·=·ON;·lorem·user@exmaple.com·ipsum
┐
├ Failed asserting that two strings are identical.
├ --- Expected
├ +++ Actual
├ @@ @@
├ -'<p>lorem <a href="mailto:user@exmaple.com">user@exmaple.com</a> ipsum</p>'
├ +'<p>lorem user@exmaple.com ipsum</p>'
│
│ mantisbt\plugins\MantisCoreFormatting\tests\MarkdownTest.php:119
┴
✘ Process emails with process_urls·=·ON;·user@exmaple.com
┐
├ Failed asserting that two strings are identical.
├ --- Expected
├ +++ Actual
├ @@ @@
├ -'<p><a href="mailto:user@exmaple.com">user@exmaple.com</a></p>'
├ +'<p>user@exmaple.com</p>'
│
│ mantisbt\plugins\MantisCoreFormatting\tests\MarkdownTest.php:119
┴
Further investigation revealed that Parsedown commit eb55e42 removed the use of the unmarkedText method, although the method itself remains and is not used anywhere else. The problem is that MantisBT uses this overloaded method to mark up an email without angle brackets.
We need to decide whether to rewrite the MantisBT plugin or fix Parsedown. |
|
|
|
Thanks for testing.
Parsedown commit eb55e42 removed the use of the unmarkedText method, although the method itself remains and is not used anywhere else
We need to decide whether to rewrite the MantisBT plugin or fix Parsedown.
For starters I suggest reporting this upstream, and see if they consider it a bug or not.
We can decide what to do based on their response (if they respond).
As a side note, please note that this thread is about PHP 8.4 compatibility, not Parsedown 1.8 tests - it would be better to move this discussion to a new issue. |
|
|
|
I created 0035227, all notes here can be deleted.
P.S. I just now realised that MantisBT doesn't have a button to move notes to another ticket... |
|
|
|
MantisBT doesn't have a button to move notes to another ticket
No it does not. That's not a very common use case. What you can do is Clone the issue, then you have the option to copy the bugnotes and set a relationship to the original issue. |
|
|
|
Switching to community-maintained Parsedown fork https://github.com/parsedown/parsedown which recently released version 1.7.5 including PHP 8.4 compatibility fix. |
|
|
|
PR https://github.com/mantisbt/mantisbt/pull/2164 |
|
