0035227: MantisBT is not compatible with Parsedown 1.8 - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update
0035227	mantisbt	markdown	public	2025-01-11 08:04	2025-01-26 10:05

Reporter	raspopov	Assigned To	community
Priority	normal	Severity	minor	Reproducibility	always
Status	resolved	Resolution	fixed
Product Version	2.27.0
Target Version	2.28.0	Fixed in Version	2.28.0

Summary	0035227: MantisBT is not compatible with Parsedown 1.8
Description	It looks like the MantisCoreFormatting plugin should be updated a bit, because when using Parsedown 1.8 the following error is generated: SYSTEM WARNING 'Undefined array key "name"' in '...plugins\MantisCoreFormatting\core\MantisMarkdown.php' line 152 `Detailed error information Full path: ...plugins\MantisCoreFormatting\core\MantisMarkdown.php Line number: 152 Stack trace # Filename Line Class Type Function Args 0 ...parsedown\Parsedown.php 1792 MantisMarkdown -> element <array> { ['elements'] => <array> { [0] => <array> { ['text'] => 'Bug!' } }, ['autobreak'] => false }`
Steps To Reproduce	Replace MantisBT `vendor\erusev\parsedown\Parsedown.php` 1.7.4 with a latest one 1.8.
Additional Information	PR: https://github.com/mantisbt/mantisbt/pull/2068 Another problem with Parsedown 1.8 is probably a bug in Parsedown... After figuring out how to run PHPUnit tests (and fixing them for the new version), I noticed that two PHPUnit tests failed: ✘ Process emails with process_urls·=·ON;·lorem·user@exmaple.com·ipsum ┐ ├ Failed asserting that two strings are identical. ├ --- Expected ├ +++ Actual ├ @@ @@ ├ -'<p>lorem <a href="mailto:user@exmaple.com">user@exmaple.com</a> ipsum</p>' ├ +'<p>lorem user@exmaple.com ipsum</p>' │ │ mantisbt\plugins\MantisCoreFormatting\tests\MarkdownTest.php:119 ┴ ✘ Process emails with process_urls·=·ON;·user@exmaple.com ┐ ├ Failed asserting that two strings are identical. ├ --- Expected ├ +++ Actual ├ @@ @@ ├ -'<p><a href="mailto:user@exmaple.com">user@exmaple.com</a></p>' ├ +'<p>user@exmaple.com</p>' │ │ mantisbt\plugins\MantisCoreFormatting\tests\MarkdownTest.php:119 ┴ Further investigation revealed that Parsedown commit eb55e42 removed the use of the `unmarkedText` method, although the method itself remains and is not used anywhere else. The problem is that MantisBT uses this overloaded method to mark up an email without angle brackets.
Tags	No tags attached.

dregad 2025-01-11 09:54 developer ~0069661	Repeating my original comment from 0035217:0069650 Parsedown commit eb55e42 removed the use of the unmarkedText method, although the method itself remains and is not used anywhere else We need to decide whether to rewrite the MantisBT plugin or fix Parsedown. For starters I suggest reporting this upstream, and see if they consider it a bug or not. We can decide what to do based on their response (if they respond).

raspopov 2025-01-11 10:43 reporter ~0069662	I addressed the issue to Parsedown: https://github.com/erusev/parsedown/issues/898

dregad 2025-01-11 14:31 developer ~0069673	Great, thank you

raspopov 2025-01-21 10:21 reporter ~0069733 Last edited: 2025-01-21 10:22	All tests are going well now. We are now independent of Parsedown versions and patches.

MantisBT: master 75113ccc 2025-01-06 09:41 raspopov Committer: dregad Details Diff	Fix Undefined array key warning in Parsedown 1.8+ SYSTEM WARNING 'Undefined array key "name"' in '...plugins\MantisCoreFormatting\core\MantisMarkdown.php' line 152 Fixes 0035227		Affected Issues 0035227
	mod - plugins/MantisCoreFormatting/core/MantisMarkdown.php		Diff File