View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003621 | mantisbt | other | public | 2004-03-01 17:10 | 2014-11-07 15:18 |
Reporter | leeguy | Assigned To | |||
Priority | normal | Severity | tweak | Reproducibility | always |
Status | new | Resolution | open | ||
Summary | 0003621: use LABEL tag with radio and checkbox inputs | ||||
Description | The label tag make form use easier. It allows for a larger clickable area around small interface items, like radio buttons and checkboxes. | ||||
Tags | patch | ||||
Attached Files | label_radio.patch (5,304 bytes)
Index: bug_report_page.php =================================================================== RCS file: /cvsroot/mantisbt/mantisbt/bug_report_page.php,v retrieving revision 1.31 diff -u -r1.31 bug_report_page.php --- bug_report_page.php 5 Feb 2004 10:57:01 -0000 1.31 +++ bug_report_page.php 1 Mar 2004 22:19:32 -0000 @@ -222,8 +222,8 @@ <?php echo lang_get( 'view_status' ) ?> </td> <td> - <input tabindex="9" type="radio" name="view_state" value="<?php echo VS_PUBLIC ?>" <?php check_checked( $f_view_state, VS_PUBLIC ) ?> /> <?php echo lang_get( 'public' ) ?> - <input tabindex="10" type="radio" name="view_state" value="<?php echo VS_PRIVATE ?>" <?php check_checked( $f_view_state, VS_PRIVATE ) ?> /> <?php echo lang_get( 'private' ) ?> + <input tabindex="9" type="radio" name="view_state" id="view_state_public" value="<?php echo VS_PUBLIC ?>" <?php check_checked( $f_view_state, VS_PUBLIC ) ?> /> <label for="view_state_public"><?php echo lang_get( 'public' ) ?></label> + <input tabindex="10" type="radio" name="view_state" id="view_state_private" value="<?php echo VS_PRIVATE ?>" <?php check_checked( $f_view_state, VS_PRIVATE ) ?> /> <label for="view_state_private"><?php echo lang_get( 'private' ) ?></label> </td> </tr> @@ -234,7 +234,7 @@ <?php echo lang_get( 'report_stay' ) ?> <?php print_documentation_link( 'report_stay' ) ?> </td> <td> - <input tabindex="11" type="checkbox" name="report_stay" <?php check_checked( $f_report_stay ) ?> /> (<?php echo lang_get( 'check_report_more_bugs' ) ?>) + <input tabindex="11" type="checkbox" name="report_stay" <?php check_checked( $f_report_stay ) ?> /> <label for="report_stay">(<?php echo lang_get( 'check_report_more_bugs' ) ?>)</label> </td> </tr> Index: account_prof_menu_page.php =================================================================== RCS file: /cvsroot/mantisbt/mantisbt/account_prof_menu_page.php,v retrieving revision 1.31 diff -u -r1.31 account_prof_menu_page.php --- account_prof_menu_page.php 11 Jan 2004 07:16:05 -0000 1.31 +++ account_prof_menu_page.php 1 Mar 2004 22:19:32 -0000 @@ -107,9 +107,9 @@ </tr> <tr class="row-1"> <td class="center" colspan="2"> - <input type="radio" name="action" value="edit" checked="checked" /> <?php echo lang_get( 'edit_profile' ) ?> - <input type="radio" name="action" value="default" /> <?php echo lang_get( 'make_default' ) ?> - <input type="radio" name="action" value="delete" /> <?php echo lang_get( 'delete_profile' ) ?> + <input type="radio" name="action" id="action_edit" value="edit" checked="checked" /> <label for="action_edit"><?php echo lang_get( 'edit_profile' ) ?></label> + <input type="radio" name="action" id="action_default" value="default" /> <label for="action_default"><?php echo lang_get( 'make_default' ) ?></label> + <input type="radio" name="action" id="action_delete" value="delete" /> <label for="action_delete"><?php echo lang_get( 'delete_profile' ) ?></label> </td> </tr> <tr class="row-2"> Index: bug_report_advanced_page.php =================================================================== RCS file: /cvsroot/mantisbt/mantisbt/bug_report_advanced_page.php,v retrieving revision 1.31 diff -u -r1.31 bug_report_advanced_page.php --- bug_report_advanced_page.php 11 Jan 2004 07:16:06 -0000 1.31 +++ bug_report_advanced_page.php 1 Mar 2004 22:19:32 -0000 @@ -351,8 +351,8 @@ <?php echo lang_get( 'view_status' ) ?> </td> <td> - <input tabindex="17" type="radio" name="view_state" value="<?php echo VS_PUBLIC ?>" <?php check_checked( $f_view_state, VS_PUBLIC ) ?> /> <?php echo lang_get( 'public' ) ?> - <input tabindex="18" type="radio" name="view_state" value="<?php echo VS_PRIVATE ?>" <?php check_checked( $f_view_state, VS_PRIVATE ) ?> /> <?php echo lang_get( 'private' ) ?> + <input tabindex="17" type="radio" name="view_state" id="view_state_public" value="<?php echo VS_PUBLIC ?>" <?php check_checked( $f_view_state, VS_PUBLIC ) ?> /> <label for="view_state_public"><?php echo lang_get( 'public' ) ?></label> + <input tabindex="18" type="radio" name="view_state" id="view_state_private" value="<?php echo VS_PRIVATE ?>" <?php check_checked( $f_view_state, VS_PRIVATE ) ?> /> <label for="view_state_private"><?php echo lang_get( 'private' ) ?></label> </td> </tr> Index: news_menu_page.php =================================================================== RCS file: /cvsroot/mantisbt/mantisbt/news_menu_page.php,v retrieving revision 1.31 diff -u -r1.31 news_menu_page.php --- news_menu_page.php 11 Jan 2004 07:16:07 -0000 1.31 +++ news_menu_page.php 1 Mar 2004 22:19:32 -0000 @@ -86,8 +86,8 @@ </tr> <tr class="row-1"> <td class="center" colspan="2"> - <input type="radio" name="action" value="edit" checked="checked" /> <?php echo lang_get( 'edit_post' ) ?> - <input type="radio" name="action" value="delete" /> <?php echo lang_get( 'delete_post' ) ?> + <input type="radio" name="action" id="action_edit" value="edit" checked="checked" /> <label for="action_edit"><?php echo lang_get( 'edit_post' ) ?></label> + <input type="radio" name="action" id="action_delete" value="delete" /> <label for="action_delete"><?php echo lang_get( 'delete_post' ) ?></label> </td> </tr> <tr class="row-2"> label_checkbox.patch (1,802 bytes)
Index: manage_user_page.php =================================================================== RCS file: /cvsroot/mantisbt/mantisbt/manage_user_page.php,v retrieving revision 1.49 diff -u -r1.49 manage_user_page.php --- manage_user_page.php 11 Jan 2004 07:16:07 -0000 1.49 +++ manage_user_page.php 1 Mar 2004 22:38:13 -0000 @@ -201,7 +201,7 @@ <input type="hidden" name="sort" value="<?php echo $c_sort ?>" /> <input type="hidden" name="dir" value="<?php echo $c_dir ?>" /> <input type="hidden" name="save" value="1" /> - <input type="checkbox" name="hide" value="1" <?php check_checked( $c_hide, 1 ); ?> /> <?php echo lang_get( 'hide_inactive' ) ?> + <input type="checkbox" name="hide" value="1" <?php check_checked( $c_hide, 1 ); ?> /> <label for="hide"><?php echo lang_get( 'hide_inactive' ) ?></label> <input type="submit" value="<?php echo lang_get( 'filter_button' ) ?>" /> </form> </td> Index: bug_report_advanced_page.php =================================================================== RCS file: /cvsroot/mantisbt/mantisbt/bug_report_advanced_page.php,v retrieving revision 1.31 diff -u -r1.31 bug_report_advanced_page.php --- bug_report_advanced_page.php 11 Jan 2004 07:16:06 -0000 1.31 +++ bug_report_advanced_page.php 1 Mar 2004 22:38:13 -0000 @@ -363,7 +363,7 @@ <?php echo lang_get( 'report_stay' ) ?> <?php print_documentation_link( 'report_stay' ) ?> </td> <td> - <input tabindex="19" type="checkbox" name="report_stay" <?php check_checked( $f_report_stay ) ?> /> (<?php echo lang_get( 'check_report_more_bugs' ) ?>) + <input tabindex="19" type="checkbox" name="report_stay" <?php check_checked( $f_report_stay ) ?> /> <label for="report_stay">(<?php echo lang_get( 'check_report_more_bugs' ) ?>)</label> </td> </tr> label-2004-06-21.patch (13,214 bytes)
Index: account_prof_menu_page.php =================================================================== RCS file: /cvsroot/mantisbt/mantisbt/account_prof_menu_page.php,v retrieving revision 1.32 diff -U4 -p -u -r1.32 account_prof_menu_page.php --- account_prof_menu_page.php 12 Apr 2004 21:04:35 -0000 1.32 +++ account_prof_menu_page.php 22 Jun 2004 02:32:00 -0000 @@ -106,11 +106,11 @@ </td> </tr> <tr class="row-1"> <td class="center" colspan="2"> - <input type="radio" name="action" value="edit" checked="checked" /> <?php echo lang_get( 'edit_profile' ) ?> - <input type="radio" name="action" value="default" /> <?php echo lang_get( 'make_default' ) ?> - <input type="radio" name="action" value="delete" /> <?php echo lang_get( 'delete_profile' ) ?> + <input type="radio" name="action" value="edit" checked="checked" id="edit_profile" /> <label for="edit_profile"><?php echo lang_get( 'edit_profile' ) ?></label> + <input type="radio" name="action" value="default" id="make_default" /> <label for="make_default"><?php echo lang_get( 'make_default' ) ?></label> + <input type="radio" name="action" value="delete" id="delete_profile" /> <label for="delete_profile"><?php echo lang_get( 'delete_profile' ) ?></label> </td> </tr> <tr class="row-2"> <td class="category" width="25%"> Index: bug_report_advanced_page.php =================================================================== RCS file: /cvsroot/mantisbt/mantisbt/bug_report_advanced_page.php,v retrieving revision 1.35 diff -U4 -p -u -r1.35 bug_report_advanced_page.php --- bug_report_advanced_page.php 6 Apr 2004 19:38:32 -0000 1.35 +++ bug_report_advanced_page.php 22 Jun 2004 02:32:01 -0000 @@ -353,10 +353,10 @@ <td> <?php if ( access_has_project_level( config_get( 'set_view_status_threshold' ) ) ) { ?> - <input tabindex="9" type="radio" name="view_state" value="<?php echo VS_PUBLIC ?>" <?php check_checked( $f_view_state, VS_PUBLIC ) ?> /> <?php echo lang_get( 'public' ) ?> - <input tabindex="10" type="radio" name="view_state" value="<?php echo VS_PRIVATE ?>" <?php check_checked( $f_view_state, VS_PRIVATE ) ?> /> <?php echo lang_get( 'private' ) ?> + <input tabindex="9" type="radio" name="view_state" value="<?php echo VS_PUBLIC ?>" <?php check_checked( $f_view_state, VS_PUBLIC ) ?> id="view_state_public" /> <label for="view_state_public"><?php echo lang_get( 'public' ) ?></label> + <input tabindex="10" type="radio" name="view_state" value="<?php echo VS_PRIVATE ?>" <?php check_checked( $f_view_state, VS_PRIVATE ) ?> id="view_state_private" /> <label for="view_state_private"><?php echo lang_get( 'private' ) ?></label> <?php } else { echo get_enum_element( 'project_view_state', $f_view_state ); } @@ -369,9 +369,9 @@ <td class="category"> <?php echo lang_get( 'report_stay' ) ?> <?php print_documentation_link( 'report_stay' ) ?> </td> <td> - <input tabindex="19" type="checkbox" name="report_stay" <?php check_checked( $f_report_stay ) ?> /> (<?php echo lang_get( 'check_report_more_bugs' ) ?>) + <input tabindex="19" type="checkbox" name="report_stay" <?php check_checked( $f_report_stay ) ?> id="report_stay_check" /> <label for="report_stay_check">(<?php echo lang_get( 'check_report_more_bugs' ) ?>)</label> </td> </tr> Index: bug_report_page.php =================================================================== RCS file: /cvsroot/mantisbt/mantisbt/bug_report_page.php,v retrieving revision 1.37 diff -U4 -p -u -r1.37 bug_report_page.php --- bug_report_page.php 10 May 2004 14:06:08 -0000 1.37 +++ bug_report_page.php 22 Jun 2004 02:32:01 -0000 @@ -243,10 +243,10 @@ <td> <?php if ( access_has_project_level( config_get( 'set_view_status_threshold' ) ) ) { ?> - <input tabindex="9" type="radio" name="view_state" value="<?php echo VS_PUBLIC ?>" <?php check_checked( $f_view_state, VS_PUBLIC ) ?> /> <?php echo lang_get( 'public' ) ?> - <input tabindex="10" type="radio" name="view_state" value="<?php echo VS_PRIVATE ?>" <?php check_checked( $f_view_state, VS_PRIVATE ) ?> /> <?php echo lang_get( 'private' ) ?> + <input tabindex="9" type="radio" name="view_state" value="<?php echo VS_PUBLIC ?>" <?php check_checked( $f_view_state, VS_PUBLIC ) ?> id="view_state_public" /> <label for="view_state_public"><?php echo lang_get( 'public' ) ?></label> + <input tabindex="10" type="radio" name="view_state" value="<?php echo VS_PRIVATE ?>" <?php check_checked( $f_view_state, VS_PRIVATE ) ?> id="view_state_private" /> <label for="view_state_private"><?php echo lang_get( 'private' ) ?></label> <?php } else { echo get_enum_element( 'project_view_state', $f_view_state ); } @@ -259,9 +259,9 @@ <td class="category"> <?php echo lang_get( 'report_stay' ) ?> <?php print_documentation_link( 'report_stay' ) ?> </td> <td> - <input tabindex="11" type="checkbox" name="report_stay" <?php check_checked( $f_report_stay ) ?> /> (<?php echo lang_get( 'check_report_more_bugs' ) ?>) + <input tabindex="11" type="checkbox" name="report_stay" <?php check_checked( $f_report_stay ) ?> id="report_stay_check" /> <label for="report_stay_check">(<?php echo lang_get( 'check_report_more_bugs' ) ?>)</label> </td> </tr> Index: bug_update_advanced_page.php =================================================================== RCS file: /cvsroot/mantisbt/mantisbt/bug_update_advanced_page.php,v retrieving revision 1.68 diff -U4 -p -u -r1.68 bug_update_advanced_page.php --- bug_update_advanced_page.php 24 May 2004 12:23:18 -0000 1.68 +++ bug_update_advanced_page.php 22 Jun 2004 02:32:01 -0000 @@ -431,11 +431,10 @@ <?php $t_default_bugnote_view_status = config_get( 'default_bugnote_view_status' ); if ( access_has_bug_level( config_get( 'set_view_status_threshold' ), $f_bug_id ) ) { ?> - <input type="checkbox" name="private" <?php check_checked( config_get( 'default_bugnote_view_status' ), VS_PRIVATE ); ?> /> + <input type="checkbox" name="private" <?php check_checked( config_get( 'default_bugnote_view_status' ), VS_PRIVATE ); ?> id="private_check" /> <label for="private_check"><?php echo lang_get( 'private' ); ?></label> <?php - echo lang_get( 'private' ); } else { echo get_enum_element( 'project_view_state', $t_default_bugnote_view_status ); } ?> Index: bug_update_page.php =================================================================== RCS file: /cvsroot/mantisbt/mantisbt/bug_update_page.php,v retrieving revision 1.69 diff -U4 -p -u -r1.69 bug_update_page.php --- bug_update_page.php 23 May 2004 14:13:47 -0000 1.69 +++ bug_update_page.php 22 Jun 2004 02:32:01 -0000 @@ -346,11 +346,10 @@ <?php $t_default_bugnote_view_status = config_get( 'default_bugnote_view_status' ); if ( access_has_bug_level( config_get( 'set_view_status_threshold' ), $f_bug_id ) ) { ?> - <input type="checkbox" name="private" <?php check_checked( config_get( 'default_bugnote_view_status' ), VS_PRIVATE ); ?> /> + <input type="checkbox" name="private" <?php check_checked( config_get( 'default_bugnote_view_status' ), VS_PRIVATE ); ?> id="private_check" /> <label for="private_check"><?php echo lang_get( 'private' ); ?></label> <?php - echo lang_get( 'private' ); } else { echo get_enum_element( 'project_view_state', $t_default_bugnote_view_status ); } ?> Index: bugnote_add_inc.php =================================================================== RCS file: /cvsroot/mantisbt/mantisbt/bugnote_add_inc.php,v retrieving revision 1.20 diff -U4 -p -u -r1.20 bugnote_add_inc.php --- bugnote_add_inc.php 17 May 2004 11:39:06 -0000 1.20 +++ bugnote_add_inc.php 22 Jun 2004 02:32:01 -0000 @@ -39,11 +39,10 @@ <?php $t_default_bugnote_view_status = config_get( 'default_bugnote_view_status' ); if ( access_has_bug_level( config_get( 'set_view_status_threshold' ), $f_bug_id ) ) { ?> - <input type="checkbox" name="private" <?php check_checked( $t_default_bugnote_view_status, VS_PRIVATE ); ?> /> + <input type="checkbox" name="private" <?php check_checked( $t_default_bugnote_view_status, VS_PRIVATE ); ?> id="private_check" /> <label for="private_check"><?php echo lang_get( 'private' ); ?></label> <?php - echo lang_get( 'private' ); } else { echo get_enum_element( 'project_view_state', $t_default_bugnote_view_status ); } ?> Index: manage_user_page.php =================================================================== RCS file: /cvsroot/mantisbt/mantisbt/manage_user_page.php,v retrieving revision 1.53 diff -U4 -p -u -r1.53 manage_user_page.php --- manage_user_page.php 25 May 2004 13:38:52 -0000 1.53 +++ manage_user_page.php 22 Jun 2004 02:32:01 -0000 @@ -198,9 +198,9 @@ for ($i=0;$i<$new_user_count;$i++) { <form method="post" action="manage_user_page.php"> <input type="hidden" name="sort" value="<?php echo $c_sort ?>" /> <input type="hidden" name="dir" value="<?php echo $c_dir ?>" /> <input type="hidden" name="save" value="1" /> - <input type="checkbox" name="hide" value="1" <?php check_checked( $c_hide, 1 ); ?> /> <?php echo lang_get( 'hide_inactive' ) ?> + <input type="checkbox" name="hide" value="1" <?php check_checked( $c_hide, 1 ); ?> id="hide_inactive" /> <label for="hide_inactive"><?php echo lang_get( 'hide_inactive' ) ?></label> <input type="submit" class="button" value="<?php echo lang_get( 'filter_button' ) ?>" /> </form> </td> </tr> Index: news_menu_page.php =================================================================== RCS file: /cvsroot/mantisbt/mantisbt/news_menu_page.php,v retrieving revision 1.32 diff -U4 -p -u -r1.32 news_menu_page.php --- news_menu_page.php 12 Apr 2004 21:04:36 -0000 1.32 +++ news_menu_page.php 22 Jun 2004 02:32:01 -0000 @@ -85,10 +85,10 @@ </td> </tr> <tr class="row-1"> <td class="center" colspan="2"> - <input type="radio" name="action" value="edit" checked="checked" /> <?php echo lang_get( 'edit_post' ) ?> - <input type="radio" name="action" value="delete" /> <?php echo lang_get( 'delete_post' ) ?> + <input type="radio" name="action" value="edit" checked="checked" id="edit_post" /> <label for="edit_post"><?php echo lang_get( 'edit_post' ) ?></label> + <input type="radio" name="action" value="delete" id="delete_post" /> <label for="delete_post"><?php echo lang_get( 'delete_post' ) ?></label> </td> </tr> <tr class="row-2"> <td class="category" width="25%"> Index: query_store_page.php =================================================================== RCS file: /cvsroot/mantisbt/mantisbt/query_store_page.php,v retrieving revision 1.3 diff -U4 -p -u -r1.3 query_store_page.php --- query_store_page.php 12 Apr 2004 21:04:36 -0000 1.3 +++ query_store_page.php 22 Jun 2004 02:32:01 -0000 @@ -45,18 +45,18 @@ print lang_get( 'query_name' ) . ': '; ?> <form method="POST" action="query_store.php"> - <input type="text" name="query_name"><br /> + <input type="text" name="query_name" /><br /> <?php if ( access_has_project_level( config_get( 'stored_query_create_shared_threshold' ) ) ) { - print '<input type="checkbox" name="is_public" value="on">'; + print '<input type="checkbox" name="is_public" value="on" id="make_public_check" /> <label for="make_public_check">'; print lang_get( 'make_public' ); - print '<br />'; + print '</label><br />'; } ?> - <input type="checkbox" name="all_projects" value="on"> - <?php print lang_get( 'all_projects' ); ?><br /><br /> + <input type="checkbox" name="all_projects" value="on" id="all_projects_check" /><label for="all_projects_check"> + <?php print lang_get( 'all_projects' ); ?></label><br /><br /> <input type="submit" class="button" value="<?php print lang_get( 'save_query' ); ?>"> </form> <form action="view_all_bug_page.php"> <input type="submit" class="button" value="<?php print lang_get( 'go_back' ); ?>"> Index: view_filters_page.php =================================================================== RCS file: /cvsroot/mantisbt/mantisbt/view_filters_page.php,v retrieving revision 1.9 diff -U4 -p -u -r1.9 view_filters_page.php --- view_filters_page.php 15 Jun 2004 07:31:01 -0000 1.9 +++ view_filters_page.php 22 Jun 2004 02:32:02 -0000 @@ -197,9 +197,9 @@ </select> <?php if ( 'simple' == $f_view_type ) { ?> - <br /><input type="checkbox" name="and_not_assigned" <?php check_checked( $t_filter['and_not_assigned'], 'on' ); ?> /> <?php echo lang_get( 'or_unassigned' ) ?> + <br /><input type="checkbox" name="and_not_assigned" <?php check_checked( $t_filter['and_not_assigned'], 'on' ); ?> id="or_unassigned_check" /> <label for="or_unassigned_check"><?php echo lang_get( 'or_unassigned' ) ?></label> <?php } ?> </td> @@ -254,10 +254,10 @@ <td class="small-caption" colspan="<?php echo ( 3 * $t_custom_cols ); ?>"> <input type="checkbox" name="do_filter_by_date" <?php check_checked( $t_filter['do_filter_by_date'], 'on' ); if ( ON == config_get( 'use_javascript' ) ) { - print "onclick=\"SwitchDateFields();\""; } ?> /> - <?php echo lang_get( 'use_date_filters' ) ?> + print "onclick=\"SwitchDateFields();\""; } ?> id="use_date_filters_check" /> + <label for="use_date_filters_check"><?php echo lang_get( 'use_date_filters' ) ?></label> </td> </tr> <tr class="row-2"> <!-- Build --> | ||||
Updated patch for the latest CVS version, a bit more comprehensive than the last one. |
|
Any news about this issue ? When are the patches going into CVS ? |
|
Another patch was submitted in 0004786. |
|