0036438: MantisCoreFormatting: Error when saving configuration

ID	Project	Category	View Status	Date Submitted	Last Update
0036438	mantisbt	plug-ins	public	2025-10-03 09:12	2025-10-04 13:00

Reporter	mschmidt	Assigned To	atrol
Priority	normal	Severity	minor	Reproducibility	have not tried
Status	resolved	Resolution	fixed
Target Version	2.28.0	Fixed in Version	2.28.0

Summary	0036438: MantisCoreFormatting: Error when saving configuration
Description	In current V2.28 Nightly Builds and on the current master there is an error when saving the format configuration. The line `$f_syntax_highlighting_plugins = gpc_get_string_array( 'syntax_highlighting_plugins', null );` causes an error and must be replaced with `$f_syntax_highlighting_plugins = gpc_get_string_array( 'syntax_highlighting_plugins', array() );`.
Steps To Reproduce	Version: Current nightly builds (V2.28) and master branch (03.10.2025) File: plugins/MantisCoreFormatting/pages/config_edit.php Line: `$f_syntax_highlighting_plugins = gpc_get_string_array( 'syntax_highlighting_plugins', null );`
Tags	PHP 8.4

atrol 2025-10-03 11:30 developer ~0070547	Thanks @register@h-s-e.org for finding and analyzing the bug. Regression introduced by 0035215 PR https://github.com/mantisbt/mantisbt/pull/2153

dregad 2025-10-04 12:46 developer ~0070549	Regression introduced by 0035215 The fix is good, but the above statement is incorrect. The regression actually comes from commit MantisBT master 1b3ca867 (0034124). I do agree that 0035215 is related though, because it's the same PHP error.

atrol 2025-10-04 13:00 developer ~0070550	@dregad the plugin / syntax highlighting configuration worked before you changed function gpc_get_string_array in PR for 0035215

related to	0035215	resolved	dregad	PHP 8.4: Implicitly nullable parameter types are deprecated
related to	0034124	closed	community	Add syntax highlighting to markdown codeblocks

MantisBT: master 82ecf152 2025-10-03 11:22 atrol Details Diff	Fix INTERNAL APPLICATION ERROR in formatting plugin configuration Fixes 0036438		Affected Issues 0035215, 0036438
	mod - plugins/MantisCoreFormatting/pages/config_edit.php		Diff File