0036889: Add database caching to more functions. - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update
0036889	mantisbt	performance	public	2026-02-20 08:28	2026-09-02 12:56

Reporter	raspopov	Assigned To	community
Priority	normal	Severity	minor	Reproducibility	always
Status	resolved	Resolution	fixed
Product Version	2.28.0
Target Version	2.29.0	Fixed in Version	2.29.0

Summary	0036889: Add database caching to more functions.
Description	Enabling database operation logging (`$g_log_level = LOG_DATABASE;`) detects duplicate database queries, including those that are completely identical and those that overlap with earlier queries in terms of the requested rows. The number of duplicates is notably large, particularly on the first page of the tracker and when custom fields are present in the projects.
Additional Information	Further investigation of the code revealed that although many requests are already cached, there are errors in some places when working with the cache, and there is no cache in others.
Tags	No tags attached.

raspopov 2026-02-20 08:36 reporter ~0070800	PR: https://github.com/mantisbt/mantisbt/pull/2189

raspopov 2026-03-01 03:41 reporter ~0070808	I would also like to cache tokens_api.php calls, but this will probably require manually rebuilding the token_get() call, which returns the raw result of the database query.

dregad 2026-03-06 20:02 developer ~0070824	Many thanks for your contribution I would also like to cache tokens_api.php calls, but this will probably require manually rebuilding the token_get() call, which returns the raw result of the database query. I merged the PR as it was, so feel free to open a separate one for tokens, either referencing this issue, or open a new Issue as you prefer.

MantisBT: master 71404459 2026-03-06 20:00 raspopov Committer: community Details Diff	Add database caching to more functions This patch dramatically reduces the number of database queries, especially on the first page of the tracker with projects that have custom fields. - Added database cache to bug_get_bugnote_stats_array(), custom_field_cache_array_rows() and filter_db_get_project_current() - Added database negative result cache to category_cache_array_rows() - Fixed database cache in file_bug_attachment_count_cache() - Added cache of all relationships Fixes 0036889, PR https://github.com/mantisbt/mantisbt/pull/2189 Signed-off-by: Damien Regad <dregad@mantisbt.org>		Affected Issues 0036889
	mod - core/bug_api.php		Diff File
	mod - core/category_api.php		Diff File
	mod - core/custom_field_api.php		Diff File
	mod - core/file_api.php		Diff File
	mod - core/filter_api.php		Diff File
	mod - core/relationship_api.php		Diff File
MantisBT: master e108a253 2026-09-01 19:03 dregad Details Diff	Fix PHP warning in custom_field_cache_row() It can happen that $g_cache_custom_field does NOT contain an entry for a given custom field id, causing an Undefined array key warning. This is likely a regression introduced by issue 0036889 (commit 71404459cec835ff068f1812b52da9ebea223abb), which introduced an early return from the function; previously, the key was guaranteed to exist. Adding a null-coalescing operator fixes the problem. Issue 0032449		Affected Issues 0032449, 0036889
	mod - core/custom_field_api.php		Diff File