View Issue Details

WikiJump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0003970mantisbtbugtrackerpublic2004-06-24 14:482004-08-29 02:06
ReporterWandererAssigned Tothraxisp  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
PlatformAnyOSAnyOS VersionAny
Product Versiongit trunk 
Fixed in Version0.19.0rc1 
Summary0003970: Reopen issue logic was broken for ustom reopen statuses
Description

Before this update Reopen worked as expected - resolved issue can be reopened, now only "closed" issues have "reopen" button and ability

Steps To Reproduce

Try to work with Mantis after this update and compate with old style

Additional Information

Feel free to use http://bts.e-city.net.ru/demo/ - it mirrorred all CVS-commit

TagsNo tags attached.
Attached Files
html_api.php.diff (560 bytes)    
Index: C:/Documents and Settings/Ray/My Documents/Projects/mantis/core/html_api.php
===================================================================
--- C:/Documents and Settings/Ray/My Documents/Projects/mantis/core/html_api.php	(revision 1)
+++ C:/Documents and Settings/Ray/My Documents/Projects/mantis/core/html_api.php	(revision 21)
@@ -824,6 +824,9 @@
 			# REOPEN button
 			html_button_bug_reopen( $p_bug_id );
 		}
+		if ($t_status == $t_resolved) {
+			html_button_bug_reopen( $p_bug_id );
+		}
 		PRINT '</td>';
 
 		# CLOSE button
html_api.php.diff (560 bytes)   

Relationships

Relationship GraphDependency Graph
related to 0003772 closedthraxisp Status updating should be different from bug updating 
child of 0003987 closedvboctor Mantis 0.19.0 Release 

Activities

Wanderer

Wanderer

2004-06-24 15:25

reporter   ~0005795

Last edited: 2004-06-24 16:36

Ups, tested with previous revision and found, that I was wrong - it never work as expected according to html_api
Please, remember - resolved != readonly!
resolved bug can be writable, but because it was resolved (into custom "resolved" status), it MUST have "reopen" button.
Dirty (but usable and correct from side of fixing mentioned problem) patch attached

edited on: 06-24-04 16:36
thraxisp

thraxisp

2004-07-28 13:30

reporter   ~0006421

I'll roll this into the fix for 0003772 which touches the same code.
thraxisp

thraxisp

2004-08-04 08:14

reporter   ~0006624

Fixed in CVS as part of the changes for 0003772.
Wanderer

Wanderer

2004-08-04 16:13

reporter   ~0006640

Last edited: 2004-08-04 16:17

Even with html_api 1.117
Separate "reopen" button is visible only for resolved and above (closed). In custom resolve status ("verify wait") there aren't button (but reopen possible with "change status"). Compate view of different "green" issues on my site (updater can all, it's not permissions issue)

edited on: 08-04-04 16:17
thraxisp

thraxisp

2004-08-04 17:34

reporter   ~0006643

I missed the subtlety of the comment. I will fix this and resubmit. I'm now treating readonly and resolved separately. There will be a reopen button if the issue status is equal to or greater than the "bug_resolved_status_threshold".
thraxisp

thraxisp

2004-08-04 21:09

reporter   ~0006645

Fixed again. Differentiated resolved from readonly actions.