View Issue Details

IDProjectCategoryView StatusLast Update
0004293mantisbtlocalizationpublic2004-08-29 01:42
Reporterjferraz Assigned Tothraxisp  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Versiongit trunk 
Fixed in Version0.19.0rc1 
Summary0004293: Lang variable names broken
Description

bug_change_status_page.php is using the value of localized $s_status_enumstring on variable names, like $s_bugtitle and $s_bug_button. This breaks all language files.

Steps To Reproduce
  1. set language to something other than english;
  2. try to change the status of a bug
Additional Information

On bug_change_status_page.php, line 28:
$t_status_label = get_enum_element( 'status', $f_new_status );

get_enum_element() uses translated names if available.

TagsNo tags attached.

Relationships

has duplicate 0004294 closedWanderer Lang variable names broken 
child of 0003987 closedvboctor Mantis 0.19.0 Release 

Activities

jlatour

jlatour

2004-08-09 02:21

reporter   ~0006845

Alex, are you going to fix this?

Wanderer

Wanderer

2004-08-09 06:55

developer   ~0006858

It's code flaws, not localisation texts really, in
$Id: bug_change_status_page.php,v 1.3 2004/08/05 23:37:43 thraxisp Exp $, on which I see this big problem.
I suppose, it must be fixed (and thisissue re-classified into common bugtracker problems)

jlatour

jlatour

2004-08-09 07:27

reporter   ~0006860

Yes, it is a code problem, we determined that already. My question was, since you are assigned this issue (by Juliano?), are you planning on fixing it?

(and I supposed it's a problem with the localisation feature, but the actual category isn't that important.)

thraxisp

thraxisp

2004-08-09 09:43

reporter   ~0006874

I originally had an additional array to create an indirection for the variable names (in english). I will re-install this code and add instructions for customization.

vboctor

vboctor

2004-08-09 09:53

manager   ~0006876

Last edited: 2004-08-09 09:58

Glenn, I would rather avoid adding an extra variable that Mantis installers have to keep in sync. I think we should have an API that returns a string given its id in the enum, but in this case it returns the string in $g_enum rather than $s_enum.

edited on: 08-09-04 09:58

thraxisp

thraxisp

2004-08-09 10:43

reporter   ~0006877

That is what I was thinking. I will patch it today.

jferraz

jferraz

2004-08-09 10:54

reporter   ~0006878

I didn't assigned it directely to Alex Netman, it was automatica. Maybe Alex is listed as maintener of the "localization" category.

thraxisp

thraxisp

2004-08-09 11:27

reporter   ~0006879

fixed in CVS