View Issue Details

IDProjectCategoryView StatusLast Update
0004353mantisbtotherpublic2004-08-29 01:41
ReporterWandererAssigned Tobpfennig  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
PlatformAnyOSAnyOS VersionAny
Fixed in Version0.19.0rc1 
Summary0004353: "Select all issues" in some clicks
Description

If I (anybody) want to perform some operation in mass-treatment mode with big (BIG) set of issues (20-30-50), I have to enable each issue separately and became "overclicker". Possibilty mark all (visible on page) issues quicker will be nice time-saving feature

TagsNo tags attached.
Attached Files
patch_4353_diff.txt (1,883 bytes)   
cvs -z9 diff -u view_all_inc.php (in directory D:\cvsroot\mantisbt\)
Index: view_all_inc.php
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/view_all_inc.php,v
retrieving revision 1.142
diff -u -r1.142 view_all_inc.php
--- view_all_inc.php	1 Aug 2004 05:53:01 -0000	1.142
+++ view_all_inc.php	20 Aug 2004 21:56:31 -0000
@@ -52,7 +52,7 @@
 ?>
 
 <br />
-<form method="get" action="bug_actiongroup_page.php">
+<form name="bug_action" method="get" action="bug_actiongroup_page.php">
 <table id="buglist" class="width100" cellspacing="1">
 <tr>
 	<td class="form-title" colspan="<?php echo $col_count - 2; ?>">
@@ -347,7 +347,17 @@
 	# -- ====================== MASS BUG MANIPULATION =================== -- 
 ?>
 	<tr>
-		<td class="left" colspan="<?php echo $col_count-2; ?>">
+		<td class="left">
+<?php
+		if ( $t_checkboxes_exist ) {
+			echo "<input type=\"checkbox\" name=\"all_bugs\" value=\"all\" onClick=\"checkall('bug_action', this.form.all_bugs.checked)\">";
+		}
+		else {
+			echo '&nbsp;';
+		}
+?>
+		</td>
+		<td class="left" colspan="<?php echo $col_count-1; ?>">
 <?php
 		if ( $t_checkboxes_exist ) {
 ?>


cvs -z9 diff -u common.js (in directory D:\cvsroot\mantisbt\javascript\)
Index: common.js
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/javascript/common.js,v
retrieving revision 1.3
diff -u -r1.3 common.js
--- common.js	17 Jul 2004 23:52:57 -0000	1.3
+++ common.js	19 Aug 2004 21:15:25 -0000
@@ -124,3 +124,13 @@
 	SetDiv( p_div, p_cookie_bit );
 }
 
+/* Check checkboxes */
+function checkall( p_formname, p_state) {
+	var t_elements = (eval("document." + p_formname + ".elements"));
+	
+	for (var i = 0; i < t_elements.length; i++) { 
+    	if(t_elements[i].type == 'checkbox') { 
+      		t_elements[i].checked = p_state;
+   		} 
+  	}
+}
patch_4353_diff.txt (1,883 bytes)   

Activities

bpfennig

bpfennig

2004-08-21 07:55

reporter   ~0007091

I still have no cvs commit access, so I attached the patch.

grangeway

grangeway

2004-08-21 10:48

reporter   ~0007096

Also committed.

Changed view_inc slightly to
a) display some text explaining the checkbox is 'select all' - clearer for users.
b) Added a check for $g_use_javascript to be ON.

Other then those, committed pretty much as is

Related Changesets

MantisBT: master 74b20394

2004-08-21 09:54

Paul Richards


Details Diff
Fix 0004353: "Select all issues" in some clicks

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2878 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0004353
mod - javascript/common.js Diff File
mod - lang/strings_english.txt Diff File

MantisBT: master 464eff51

2004-08-21 11:49

Paul Richards


Details Diff
Fix 0004353: "Select all issues" in some clicks

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2880 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0004353
mod - view_all_inc.php Diff File