View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004906 | mantisbt | ldap | public | 2004-11-25 00:59 | 2012-08-17 14:11 |
Reporter | karl | Assigned To | dregad | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | no change required | ||
Product Version | 0.19.1 | ||||
Summary | 0004906: new user email incorrect when using LDAP backend | ||||
Description | When using LDAP a newly created user gets an email with instructions to change their password using the supplied URL. Of course if they try and do this it doesn't work. When LDAP is used at the back end, until users can actually change their passwords they should not get this email, or alternately get a modified email. | ||||
Tags | No tags attached. | ||||
can someone please reproduce this and mark it confirmed? I've tried with my 19.1 install using LDAP and it doesn't send the new user email, but there's the chance that my config is mis-configed. I used both a non-existing ldap user and an existing ldap user. I have new user signup disabled ($g_allow_signup = OFF;) since only LDAP users will be allowed in. |
|
Since the LDAP code in user_signup() is currently disabled, there's no point in investigating this issue at the moment. |
|
After doing some more work on bug 0005595, I can confirm this bug (0004906) here. Mantis 1.0.6, Windows server, $g_allow_signup = OFF. |
|
Some observations/thoughts: 1) In signup.php, signup is prevented if allow_signup=OFF. We could also bail at this point if login_method=LDAP. I believe that this is the only code that calls user_signup() so user_signup() would therefore never be called if login_method=LDAP. We could put a test for login_method=LDAP in user_signup(), just to be extra safe, I suppose. 2) A similar change to print_signup_link() in print_api.php could prevent the signup link being printed if login_method=LDAP too. 3) user_create() in user_api.php would probably need a tweak too. The sending of the notification email at the end of the function could be safely skipped. Or instead, if login_method=LDAP, a simple 'welcome to Mantis' email could be sent? Is there anything I've missed, or would that cover it? |
|
Well I was about to start work on a patch for this when I noticed that the configuration option $g_send_reset_password will block the sending of the signup email (whatever login method is used). That seems to solve the symptoms but not really the cause of this bug. Do we think that is sufficient? |
|
I think this should be fixed in the following way:
There should be no email verification links in emails sent to LDAP users. |
|
Can you please check if this is still an issue with the latest code? I've done a lot of changes in this area and my understanding is that this is resolved. |
|
As mentioned by vboctor, this is not an issue with current version of MantisBT |
|