View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004931 | mantisbt | webpage | public | 2004-12-02 07:26 | 2005-04-18 10:35 |
| Reporter | TomR | Assigned To | |||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | duplicate | ||
| Product Version | git trunk | ||||
| Summary | 0004931: http links are broken before the '?' question mark. | ||||
| Description | http://bugs.mantisbt.org/bugnote_edit_page.php?bugnote_id=8492 This link shows up right in 0.19.1, however in 0.19.2-CVS it is broken before the questionmark. | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
|
Can anyone verify this, we use quite a lot of external links with parameters, so this is a nasty problem for us. |
|
|
Problem lies in 0.19.2 because now Mantis is experiencing the same problem! The link here-after is copied/pasted from the browser. |
|
|
Since 0.19.1 the link recognition algorithm changed twice - the first version in 0.19.1 (implemented by me ;) ) works fine but had a little overhead and one problem, it doesn't work with links like this: http://www.google.com The second link was not parsed correctly, because the first link was part of the second. The changes made in 0.19.2 (not by me ;) ) are made to get rid of the overhead and correct the problem descriped above - so the algorithm changed back to old one (before 0.19.1) with some improvements. I think we should discuss a new algorithm :) |
|
|
Am I correct that the error in 0.19.2 can not be corrected immediatly. Our databas eis full of those links and users depend on them. Can tou give me some instructions how to get back to 0.19.1 behaviour? So I can manually change sources and make sure they are not overwritten. |
|
|
As a small bugfix you can change the following line in core/string_api.php (line 295) Replace this:
by this:
But this is not the best solution - while testing I found some links which are not parsed correctly, even with that changes. |
|