| Description | In filter_api, the line with the buttons (Search, Apply Filter...) is one column too short. This causes a line break and looks ugly. See image.
The attached patch fixes this.
IMHO the buttons look ugly in general. As discussed on the mailinglist, making things prettier using CSS is not so easy, e.g. IE does not use HOVER with buttons, MOZILLA does not allow underlined texts in buttons.
The buttons are particularly ugly in the bugnotes: Edit / Make Private / Delete.
At least one could use "button-small". But a well defined CSS would be desireable. |
|---|
| Attached Files |
filter_api.patch (869 bytes)
Index: core/filter_api.php
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/core/filter_api.php,v
retrieving revision 1.112
diff -u -r1.112 filter_api.php
--- core/filter_api.php 1 Jun 2005 01:38:03 -0000 1.112
+++ core/filter_api.php 2 Jun 2005 13:15:41 -0000
@@ -6,7 +6,7 @@
# See the README and LICENSE files for details
# --------------------------------------------------------
- # $Id$
+ # $Id: filter_api.php,v 1.112 2005/06/01 01:38:03 thraxisp Exp $
# --------------------------------------------------------
$t_core_dir = dirname( __FILE__ ).DIRECTORY_SEPARATOR;
@@ -1921,7 +1921,7 @@
}
?>
</td>
- <td class="right" colspan="4">
+ <td class="right" colspan="5">
<?php
$t_stored_queries_arr = array();
$t_stored_queries_arr = filter_db_get_available_queries();
bugnote_view_small_button.patch (3,369 bytes)
Index: core/print_api.php
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/core/print_api.php,v
retrieving revision 1.135
diff -u -r1.135 print_api.php
--- core/print_api.php 28 May 2005 00:54:34 -0000 1.135
+++ core/print_api.php 2 Jun 2005 13:16:15 -0000
@@ -6,7 +6,7 @@
# See the README and LICENSE files for details
# --------------------------------------------------------
- # $Id$
+ # $Id: print_api.php,v 1.135 2005/05/28 00:54:34 thraxisp Exp $
# --------------------------------------------------------
$t_core_dir = dirname( __FILE__ ).DIRECTORY_SEPARATOR;
@@ -1051,8 +1051,8 @@
# print a button which presents a standalone form.
# if the $p_link is blank then the text is printed but no link is created
# if $p_new_window is true, link will open in a new window, default false.
- function print_button( $p_action_page, $p_label ) {
- echo '<form method="POST" action="', $p_action_page, '"><input type="submit" class="button" value="', $p_label, '" /></form>';
+ function print_button( $p_action_page, $p_label , $p_class = "button" ) {
+ echo '<form method="POST" action="', $p_action_page, '"><input type="submit" class="', $p_class, '" value="', $p_label, '" /></form>';
}
# --------------------
# print the bracketed links used near the top
Index: bugnote_view_inc.php
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/bugnote_view_inc.php,v
retrieving revision 1.30
diff -u -r1.30 bugnote_view_inc.php
--- bugnote_view_inc.php 16 May 2005 12:56:05 -0000 1.30
+++ bugnote_view_inc.php 2 Jun 2005 13:16:15 -0000
@@ -6,7 +6,7 @@
# See the files README and LICENSE for details
# --------------------------------------------------------
- # $Id$
+ # $Id: bugnote_view_inc.php,v 1.30 2005/05/16 12:56:05 vboctor Exp $
# --------------------------------------------------------
?>
<?php
@@ -134,14 +134,14 @@
if ( !bug_is_readonly( $f_bug_id ) ) {
if ( ( access_has_bug_level( config_get( 'manage_project_threshold' ), $f_bug_id ) ) ||
( ( $v3_reporter_id == $t_user_id ) && ( ON == config_get( 'bugnote_allow_user_edit_delete' ) ) ) ) {
- print_button( 'bugnote_edit_page.php?bugnote_id='.$v3_id, lang_get( 'bugnote_edit_link' ) );
- print_button( 'bugnote_delete.php?bugnote_id='.$v3_id, lang_get( 'delete_link' ) );
+ print_button( 'bugnote_edit_page.php?bugnote_id='.$v3_id, lang_get( 'bugnote_edit_link' ), 'button-small' );
+ print_button( 'bugnote_delete.php?bugnote_id='.$v3_id, lang_get( 'delete_link' ), 'button-small' );
if ( access_has_bug_level( config_get( 'private_bugnote_threshold' ), $f_bug_id ) &&
access_has_bug_level( config_get( 'change_view_status_threshold' ), $f_bug_id ) ) {
if ( VS_PRIVATE == $v3_view_state ) {
- print_button('bugnote_set_view_state.php?private=0&bugnote_id='.$v3_id, lang_get( 'make_public' ));
+ print_button('bugnote_set_view_state.php?private=0&bugnote_id='.$v3_id, lang_get( 'make_public' ), 'button-small');
} else {
- print_button('bugnote_set_view_state.php?private=1&bugnote_id='.$v3_id, lang_get( 'make_private' ));
+ print_button('bugnote_set_view_state.php?private=1&bugnote_id='.$v3_id, lang_get( 'make_private' ), 'button-small');
}
}
}
|
|---|
