| Steps To Reproduce | Pre-requisites :
1 - Create a custom field as administrator in [Manage custom fields]
2 - Add this custom field to a project in [Manage project]
3 - Create an anomaly in this project and let the custom field empty
Reproducing :
1 - In view issues, select [none] as the value to filter on for this field
2 - Click on Apply Filter
3 - See the empty result |
|---|
| Attached Files |
custom_field_filter_none.patch (1,129 bytes)
Index: core/filter_api.php
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/core/filter_api.php,v
retrieving revision 1.147
diff -u -r1.147 filter_api.php
--- core/filter_api.php 19 Dec 2006 09:15:54 -0000 1.147
+++ core/filter_api.php 9 Mar 2007 10:46:21 -0000
@@ -784,8 +784,17 @@
array_push( $t_join_clauses, $t_cf_join_clause );
foreach( $t_filter['custom_fields'][$t_cfid] as $t_filter_member ) {
$t_filter_member = stripslashes( $t_filter_member );
- if ( META_FILTER_NONE === $t_filter_member ) { # coerce filter value if selecting META_FILTER_NONE
+ if ( META_FILTER_NONE == $t_filter_member ) { # coerce filter value if selecting META_FILTER_NONE
$t_filter_member = '';
+
+ if( $t_first_time ) {
+ $t_first_time = false;
+ $t_custom_where_clause = '(';
+ } else {
+ $t_custom_where_clause .= ' OR ';
+ }
+
+ $t_custom_where_clause .= "$t_bug_table.id NOT IN (SELECT bug_id FROM $t_table_name WHERE field_id=$t_cfid)";
}
if( $t_first_time ) {
custom_field_filter_none_2.patch (1,144 bytes)
Index: core/filter_api.php
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/core/filter_api.php,v
retrieving revision 1.147
diff -u -r1.147 filter_api.php
--- core/filter_api.php 19 Dec 2006 09:15:54 -0000 1.147
+++ core/filter_api.php 9 Mar 2007 11:23:37 -0000
@@ -784,8 +784,17 @@
array_push( $t_join_clauses, $t_cf_join_clause );
foreach( $t_filter['custom_fields'][$t_cfid] as $t_filter_member ) {
$t_filter_member = stripslashes( $t_filter_member );
- if ( META_FILTER_NONE === $t_filter_member ) { # coerce filter value if selecting META_FILTER_NONE
+ if ( META_FILTER_NONE == $t_filter_member ) { # coerce filter value if selecting META_FILTER_NONE
$t_filter_member = '';
+
+ if( $t_first_time ) {
+ $t_first_time = false;
+ $t_custom_where_clause = '(';
+ } else {
+ $t_custom_where_clause .= ' OR ';
+ }
+
+ $t_custom_where_clause .= "$t_bug_table.id NOT IN (SELECT bug_id FROM $t_custom_field_string_table WHERE field_id=$t_cfid)";
}
if( $t_first_time ) {
bug7809.patch (2,563 bytes)
Index: core/filter_api.php
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/core/filter_api.php,v
retrieving revision 1.155
diff -u -r1.155 filter_api.php
--- core/filter_api.php 27 May 2007 22:31:59 -0000 1.155
+++ core/filter_api.php 16 Jul 2007 22:42:57 -0000
@@ -1067,7 +1067,6 @@
$t_custom_fields = custom_field_get_linked_ids( $t_project_id );
foreach( $t_custom_fields as $t_cfid ) {
- $t_first_time = true;
$t_custom_where_clause = '';
# Ignore all custom filters that are not set, or that are set to '' or "any"
$t_any_found = false;
@@ -1112,27 +1111,27 @@
} else {
array_push( $t_join_clauses, $t_cf_join_clause );
+
+ $t_filter_array = array();
foreach( $t_filter['custom_fields'][$t_cfid] as $t_filter_member ) {
$t_filter_member = stripslashes( $t_filter_member );
- if ( META_FILTER_NONE === $t_filter_member ) { # coerce filter value if selecting META_FILTER_NONE
+ if ( META_FILTER_NONE == $t_filter_member ) {
+ # coerce filter value if selecting META_FILTER_NONE so it will match empty fields
$t_filter_member = '';
+ # but also add those _not_ present in the custom field string table
+ array_push( $t_filter_array , "$t_bug_table.id NOT IN (SELECT bug_id FROM $t_custom_field_string_table WHERE field_id=$t_cfid)" );
}
- if( $t_first_time ) {
- $t_first_time = false;
- $t_custom_where_clause = '(';
- } else {
- $t_custom_where_clause .= ' OR ';
- }
switch( $t_def['type'] ) {
- case CUSTOM_FIELD_TYPE_MULTILIST:
- case CUSTOM_FIELD_TYPE_CHECKBOX:
- $t_custom_where_clause .= db_helper_like( "$t_table_name.value", '%|' . db_prepare_string( $t_filter_member ) . '|%' );
- break;
- default:
- $t_custom_where_clause .= "$t_table_name.value = '" . db_prepare_string( $t_filter_member ) . "'";
+ case CUSTOM_FIELD_TYPE_MULTILIST:
+ case CUSTOM_FIELD_TYPE_CHECKBOX:
+ array_push( $t_filter_array , db_helper_like( "$t_table_name.value", '%|' . db_prepare_string( $t_filter_member ) . '|%' ) );
+ break;
+ default:
+ array_push( $t_filter_array, "$t_table_name.value = '" . db_prepare_string( $t_filter_member ) . "'" );
}
}
+ $t_custom_where_clause .= '(' . implode( ' OR ', $t_filter_array );
}
if ( !is_blank( $t_custom_where_clause ) ) {
array_push( $t_where_clauses, $t_custom_where_clause . ')' );
|
|---|
