| Description | Currently, the permissions settings for file attachments is set to "0400".
This results in non-admin users of the webserver not being able to back up their file attachments since apparently some 'cant-copy-this' bit is set by the '0400' setting.
Workaround:
In core/file_api.php (at line 600) change "0400" to "0775"
- This appears to fix the problem, at least it does in my limited tests on WindowsXP in as far as removing the 'read-only' attribute.
however, being a unix noob, i really dont know have a solid concept of what these numbers actually mean, or really what the appropriate setting really should be. |
|---|
| Attached Files |
permissions.patch (559 bytes)
Index: file_api.php
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/core/file_api.php,v
retrieving revision 1.76
diff -u -r1.76 file_api.php
--- file_api.php 15 Sep 2006 05:02:47 -0000 1.76
+++ file_api.php 22 Mar 2007 08:18:38 -0000
@@ -644,7 +644,7 @@
if ( !move_uploaded_file( $p_tmp_file, $t_disk_file_name ) ) {
trigger_error( FILE_MOVE_FAILED, ERROR );
}
- chmod( $t_disk_file_name, 0400 );
+ chmod( $t_disk_file_name, 0644 );
$c_content = '';
} else {
file-permissions.patch (2,166 bytes)
Index: mantisbt/config_defaults_inc.php
===================================================================
--- mantisbt.orig/config_defaults_inc.php
+++ mantisbt/config_defaults_inc.php
@@ -760,6 +760,10 @@
# DISK, DATABASE, or FTP.
$g_file_upload_method = DATABASE;
+ # When using FTP or DISK for storing uploaded files, they will be created
+ # with the following permissions
+ $g_new_file_permissions = 0400;
+
# FTP settings, used if $g_file_upload_method = FTP
$g_file_upload_ftp_server = 'ftp.myserver.com';
$g_file_upload_ftp_user = 'readwriteuser';
@@ -1798,4 +1802,6 @@
# access level required to run reports
$g_time_tracking_reporting_threshold = MANAGER;
+
+# vim: noexpandtab tabstop=4 softtabstop=0:
?>
Index: mantisbt/core/bug_api.php
===================================================================
--- mantisbt.orig/core/bug_api.php
+++ mantisbt/core/bug_api.php
@@ -595,7 +595,7 @@
$t_new_file_name = file_get_display_name( $t_bug_file['filename'] );
if ( ( config_get( 'file_upload_method' ) == DISK ) ) {
copy( $t_bug_file['diskfile'], $t_new_diskfile_name );
- chmod( $t_new_diskfile_name, 0400 ); # make file read only in the file system
+ chmod( $t_new_diskfile_name, $g_new_file_permissions );
}
$query = "INSERT INTO $t_mantis_bug_file_table
Index: mantisbt/core/file_api.php
===================================================================
--- mantisbt.orig/core/file_api.php
+++ mantisbt/core/file_api.php
@@ -636,7 +636,7 @@
trigger_error( FILE_MOVE_FAILED, ERROR );
}
- chmod( $t_disk_file_name, 0644 );
+ chmod( $t_disk_file_name, $g_new_file_permissions );
$c_content = '';
} else {
Index: mantisbt/proj_doc_update.php
===================================================================
--- mantisbt.orig/proj_doc_update.php
+++ mantisbt/proj_doc_update.php
@@ -107,7 +107,7 @@
if ( !move_uploaded_file( $v_tmp_name, $t_disk_file_name ) ) {
trigger_error( FILE_MOVE_FAILED, ERROR );
}
- chmod( $t_disk_file_name, 0400 );
+ chmod( $t_disk_file_name, $g_new_file_permissions );
$c_content = '';
break;
file-permissionsv2.patch (2,126 bytes)
Index: mantisbt/config_defaults_inc.php
===================================================================
--- mantisbt.orig/config_defaults_inc.php
+++ mantisbt/config_defaults_inc.php
@@ -760,6 +760,10 @@
# DISK, DATABASE, or FTP.
$g_file_upload_method = DATABASE;
+ # When using FTP or DISK for storing uploaded files, they will be created
+ # on the server with the following permissions
+ $g_attachments_file_permissions = 0400;
+
# FTP settings, used if $g_file_upload_method = FTP
$g_file_upload_ftp_server = 'ftp.myserver.com';
$g_file_upload_ftp_user = 'readwriteuser';
Index: mantisbt/core/bug_api.php
===================================================================
--- mantisbt.orig/core/bug_api.php
+++ mantisbt/core/bug_api.php
@@ -595,7 +595,7 @@
$t_new_file_name = file_get_display_name( $t_bug_file['filename'] );
if ( ( config_get( 'file_upload_method' ) == DISK ) ) {
copy( $t_bug_file['diskfile'], $t_new_diskfile_name );
- chmod( $t_new_diskfile_name, 0400 ); # make file read only in the file system
+ chmod( $t_new_diskfile_name, config_get( 'attachments_file_permissions' ) );
}
$query = "INSERT INTO $t_mantis_bug_file_table
Index: mantisbt/core/file_api.php
===================================================================
--- mantisbt.orig/core/file_api.php
+++ mantisbt/core/file_api.php
@@ -645,7 +645,7 @@ document.getElementById( span ).style.di
trigger_error( FILE_MOVE_FAILED, ERROR );
}
- chmod( $t_disk_file_name, 0644 );
+ chmod( $t_disk_file_name, config_get( 'attachments_file_permissions' ) );
$c_content = '';
} else {
Index: mantisbt/proj_doc_update.php
===================================================================
--- mantisbt.orig/proj_doc_update.php
+++ mantisbt/proj_doc_update.php
@@ -107,7 +107,7 @@
if ( !move_uploaded_file( $v_tmp_name, $t_disk_file_name ) ) {
trigger_error( FILE_MOVE_FAILED, ERROR );
}
- chmod( $t_disk_file_name, 0400 );
+ chmod( $t_disk_file_name, config_get( 'attachments_file_permissions' ) );
$c_content = '';
break;
|
|---|
