View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007871 | mantisbt | bugtracker | public | 2007-03-30 04:39 | 2013-03-08 06:15 |
| Reporter | giallu | Assigned To | giallu | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.1.0a2 | ||||
| Target Version | 1.1.0 | Fixed in Version | 1.1.0a4 | ||
| Summary | 0007871: Move "Add Note" pane below previous notes | ||||
| Description | IMHO, the "Add Note" pane for entering bug notes should be positioned after already entered notes, for the same reason why top posting is bad... | ||||
| Tags | No tags attached. | ||||
| Attached Files | swap-note-addnote.patch (2,014 bytes)
Index: bug_view_page.php
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/bug_view_page.php,v
retrieving revision 1.85
diff -u -r1.85 bug_view_page.php
--- bug_view_page.php 6 Mar 2007 07:05:18 -0000 1.85
+++ bug_view_page.php 30 Mar 2007 10:03:51 -0000
@@ -432,19 +432,9 @@
include( $t_mantis_dir . 'bug_monitor_list_view_inc.php' );
# Bugnotes
- include( $t_mantis_dir . 'bugnote_add_inc.php' );
include( $t_mantis_dir . 'bugnote_view_inc.php' );
-?>
- <!-- Jump to Bugnote add form -->
-<?php
- if ( ( $t_bug->status < config_get( 'bug_resolved_status_threshold' ) ) &&
- ( access_has_bug_level( config_get( 'add_bugnote_threshold' ), $f_bug_id ) ) )
- {
-?>
- <span class="small"><?php print_bracket_link( "#addbugnote", lang_get( 'add_bugnote_button' ) ) ?></span>
- <br />
-<?php } ?>
-<?php
+ include( $t_mantis_dir . 'bugnote_add_inc.php' );
+
# Time Tracking stats
if ( config_get('time_tracking_enabled') &&
access_has_bug_level( config_get( 'time_tracking_reporting_threshold' ), $f_bug_id ) ) {
@@ -458,4 +448,6 @@
html_page_bottom1( __FILE__ );
last_visited_issue( $f_bug_id );
+
+# vim: noexpandtab tabstop=4 softtabstop=0:
?>
Index: bug_view_advanced_page.php
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/bug_view_advanced_page.php,v
retrieving revision 1.83
diff -u -r1.83 bug_view_advanced_page.php
--- bug_view_advanced_page.php 6 Mar 2007 07:05:18 -0000 1.83
+++ bug_view_advanced_page.php 30 Mar 2007 10:03:52 -0000
@@ -554,8 +554,8 @@
include( $t_mantis_dir . 'bug_monitor_list_view_inc.php' );
# Bugnotes
- include( $t_mantis_dir . 'bugnote_add_inc.php' );
include( $t_mantis_dir . 'bugnote_view_inc.php' );
+ include( $t_mantis_dir . 'bugnote_add_inc.php' );
# History
if ( $f_history ) {
@@ -565,4 +565,6 @@
html_page_bottom1( __FILE__ );
last_visited_issue( $f_bug_id );
+
+# vim: noexpandtab tabstop=4 softtabstop=0:
?>
swap-note-addnote-v2.patch (2,332 bytes)
Index: bug_view_page.php
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/bug_view_page.php,v
retrieving revision 1.85
diff -u -r1.85 bug_view_page.php
--- bug_view_page.php 6 Mar 2007 07:05:18 -0000 1.85
+++ bug_view_page.php 12 Apr 2007 09:25:08 -0000
@@ -431,20 +431,15 @@
# User list monitoring the bug
include( $t_mantis_dir . 'bug_monitor_list_view_inc.php' );
- # Bugnotes
- include( $t_mantis_dir . 'bugnote_add_inc.php' );
- include( $t_mantis_dir . 'bugnote_view_inc.php' );
-?>
- <!-- Jump to Bugnote add form -->
-<?php
- if ( ( $t_bug->status < config_get( 'bug_resolved_status_threshold' ) ) &&
- ( access_has_bug_level( config_get( 'add_bugnote_threshold' ), $f_bug_id ) ) )
- {
-?>
- <span class="small"><?php print_bracket_link( "#addbugnote", lang_get( 'add_bugnote_button' ) ) ?></span>
- <br />
-<?php } ?>
-<?php
+ # Bugnotes and "Add Note" box
+ if ( 'ASC' == current_user_get_pref( 'bugnote_order' ) ) {
+ include( $t_mantis_dir . 'bugnote_view_inc.php' );
+ include( $t_mantis_dir . 'bugnote_add_inc.php' );
+ } else {
+ include( $t_mantis_dir . 'bugnote_add_inc.php' );
+ include( $t_mantis_dir . 'bugnote_view_inc.php' );
+ }
+
# Time Tracking stats
if ( config_get('time_tracking_enabled') &&
access_has_bug_level( config_get( 'time_tracking_reporting_threshold' ), $f_bug_id ) ) {
Index: bug_view_advanced_page.php
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/bug_view_advanced_page.php,v
retrieving revision 1.83
diff -u -r1.83 bug_view_advanced_page.php
--- bug_view_advanced_page.php 6 Mar 2007 07:05:18 -0000 1.83
+++ bug_view_advanced_page.php 12 Apr 2007 09:25:08 -0000
@@ -553,9 +553,14 @@
# User list monitoring the bug
include( $t_mantis_dir . 'bug_monitor_list_view_inc.php' );
- # Bugnotes
- include( $t_mantis_dir . 'bugnote_add_inc.php' );
- include( $t_mantis_dir . 'bugnote_view_inc.php' );
+ # Bugnotes and "Add Note" box
+ if ( 'ASC' == current_user_get_pref( 'bugnote_order' ) ) {
+ include( $t_mantis_dir . 'bugnote_view_inc.php' );
+ include( $t_mantis_dir . 'bugnote_add_inc.php' );
+ } else {
+ include( $t_mantis_dir . 'bugnote_add_inc.php' );
+ include( $t_mantis_dir . 'bugnote_view_inc.php' );
+ }
# History
if ( $f_history ) {
| ||||
 |
attached a (trivial) patch for bug_view_page.php and bug_view_advanced_page.php, the former a little longer since, after the swap, the "Add Note" link did not seem to be that much useful. |
|
|
With the v2 patch applied, the "Add note" box is located above or below bugnotes according to the "Notes Sort Order" user preference, so that it is always near the newest note |
|
|
Patch applied |
|
MantisBT: master 3ccd8f88 2007-06-29 13:44 Details Diff |
Fix 7871: Move "Add Note" pane below previous notes. The "Add note" pane location now depends on the bugnote ordering, so that it will be always near the last inserted note. git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@4392 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
Affected Issues 0007871 |
|
| mod - bug_view_page.php | Diff File | ||
| mod - bug_view_advanced_page.php | Diff File | ||
