View Issue Details

WikiRelated ChangesetsJump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0008919mantisbtlocalizationpublic2008-02-23 13:572009-06-26 12:05
ReporterMartin Fuchs Assigned ToMartinFuchs  
PrioritynormalSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Product Versiongit trunk 
Summary0008919: disambiguate localized date string constants
Description

The code in bug_reminder_page.php is currently using this ambiguous string constants:

$s_from
$s_to
$s_on
$s_off

As discussed on the mailing list, the constants should be renamed to provide better manageability. For example the "on" constant should be disambiguated from "on date ..." expressions:

s_on = 'On' <- for switching some flag to the "on" state
s_off = 'Off'

s_on_date = 'On' <- for "mail sent on ..." dates or similar

Further the time tracking constants s_from_date and s_to_date should be used in a common way.

TagsNo tags attached.

Activities

giallu

giallu

2008-02-23 15:03

reporter   ~0017173

I agree we need to clarify the meaning of "On" in the language file: we can change the name to s_on_date or just add a comment on the english file.

About the other change, I think we don't need On/Off strings at all. All present usage of those strings can be safely changed to use checkboxes instead of radiobuttons
MartinFuchs

MartinFuchs

2008-02-23 15:32

reporter   ~0017174

Sorry giallu, I saw your comment too late. There are now this "on" strings defined for all languages. The "off" constant exists currently only for English, German and Spanish. But it's no problem to remove this two constants again if we really don't need them in future. Removing is always easier than adding. ;-)

Related Changesets

MantisBT: master 24013ed6

2008-02-23 15:09

Martin Fuchs


Details Diff		 Fix 0008919 - disambiguate localized date string constants:
Now there are defined the following localized string constants.

filter_api.php:
s_between_date, s_on_or_before_date, s_before_date, s_after_date, s_on_or_after_date

common date constants:
s_from_date, s_to_date, s_on_date,

common switch constants:
s_on, s_off

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@5046 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9		 Affected Issues
0008919
mod - lang/strings_portuguese_brazil.txt Diff File
mod - lang/strings_german.txt Diff File
mod - lang/strings_dutch.txt Diff File
mod - lang/strings_hebrew.txt Diff File
mod - lang/strings_serbian.txt Diff File
mod - lang/strings_bulgarian.txt Diff File
mod - lang/strings_norwegian_8859-15.txt Diff File
mod - lang/strings_polish_8859-2.txt Diff File
mod - lang/strings_chinese_traditional_big5.txt Diff File
mod - lang/strings_russian.txt Diff File
mod - lang/strings_dutch_8859-15.txt Diff File
mod - lang/strings_german_eintrag.txt Diff File
mod - lang/strings_russian_koi8.txt Diff File
mod - lang/strings_russian_1251.txt Diff File
mod - lang/strings_turkish_8859-9.txt Diff File
mod - lang/strings_spanish_8859-15.txt Diff File
mod - lang/strings_french_8859-15.txt Diff File
mod - lang/strings_swedish.txt Diff File
mod - lang/strings_english.txt Diff File
mod - lang/strings_lithuanian_1257.txt Diff File
mod - lang/strings_german_8859-1.txt Diff File
mod - lang/strings_slovene.txt Diff File
mod - lang/strings_ukrainian.txt Diff File
mod - lang/strings_hungarian.txt Diff File
mod - lang/strings_portuguese_standard_8859-1.txt Diff File
mod - lang/strings_danish_8859-15.txt Diff File
mod - lang/strings_spanish.txt Diff File
mod - lang/strings_swedish_8859-1.txt Diff File
mod - lang/strings_slovene_8859-2.txt Diff File
mod - lang/strings_finnish_8859-15.txt Diff File
mod - core/filter_api.php Diff File
mod - lang/strings_chinese_simplified.txt Diff File
mod - lang/strings_catalan_8859-15.txt Diff File
mod - lang/strings_czech_8859-2.txt Diff File
mod - lang/strings_portuguese_brazil_8859-1.txt Diff File
mod - lang/strings_chinese_traditional.txt Diff File
mod - lang/strings_turkish.txt Diff File
mod - lang/strings_korean.txt Diff File
mod - lang/strings_polish.txt Diff File
mod - lang/strings_finnish.txt Diff File
mod - lang/strings_ukrainian_1251.txt Diff File
mod - lang/strings_icelandic_8859-1.txt Diff File
mod - lang/strings_portuguese_standard.txt Diff File
mod - lang/strings_latvian_1257.txt Diff File
mod - lang/strings_chinese_simplified_gb2312.txt Diff File
mod - lang/strings_catalan.txt Diff File
mod - lang/strings_croatian.txt Diff File
mod - lang/strings_japanese.txt Diff File
mod - lang/strings_lithuanian.txt Diff File
mod - lang/strings_serbian_8859-2.txt Diff File
mod - lang/strings_croatian_8859-2.txt Diff File
mod - lang/strings_greek.txt Diff File
mod - lang/strings_slovak_8859-2.txt Diff File
mod - lang/strings_japanese_sjis.txt Diff File
mod - lang/strings_estonian.txt Diff File
mod - lang/strings_latvian.txt Diff File
mod - lang/strings_urdu.txt Diff File
mod - lang/strings_bulgarian_1251.txt Diff File
mod - lang/strings_czech.txt Diff File
mod - lang/strings_japanese_euc.txt Diff File
mod - lang/strings_korean_euc-kr.txt Diff File
mod - lang/strings_romanian.txt Diff File
mod - core/class.period.php Diff File
mod - lang/strings_norwegian.txt Diff File
mod - lang/strings_french.txt Diff File
mod - lang/strings_estonian_8859-15.txt Diff File
mod - lang/strings_hungarian_8859-2.txt Diff File
mod - lang/strings_danish.txt Diff File
mod - lang/strings_slovak.txt Diff File
mod - lang/strings_icelandic.txt Diff File
mod - lang/strings_italian.txt Diff File
mod - core/email_api.php Diff File