View Issue Details

IDProjectCategoryView StatusLast Update
0009247mantisbtsecuritypublic2008-08-11 09:42
ReporterSergiodf Assigned Tojreese  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version1.2.0a1 
Target Version1.2.0a2Fixed in Version1.2.0a2 
Summary0009247: A reporter can update an incidence
Description

When playing with this Mantis (http://www.mantisbt.org/bugs/) i clicked on "Report issue", then i reset the filter and i discovered a new feature: due date.
Then i clicked on the clock icon and i was carried to bug_update_advanced_page.php and was able to update the "Build" field (i think it works with any field that does not use AJAX).

This seems to work only for bugs reported by myself.
It is possible using advanced or simple update page (entering URL manually).

TagsNo tags attached.

Activities

Sergiodf

Sergiodf

2008-06-09 19:43

reporter   ~0018042

May i add a note, also?

giallu

giallu

2008-06-10 04:30

reporter   ~0018043

I fail to see where is the problem... can you expand your point please?

Sergiodf

Sergiodf

2008-06-10 08:58

reporter   ~0018048

I have reporter access ("Logged in as: Sergiodf (Sergio Del Franco - reporter)"), not Updater.
So, in this page (view.php) there is no button for update the bug. It is Ok.
But I can update it by generating an URL by hand.

jreese

jreese

2008-06-10 09:30

reporter   ~0018049

Last edited: 2008-06-10 09:32

The advanced update page checks for access levels, but does not enforce them or give an 'access denied' message like the standard update page; This should be fixed.

However, a reporter will still not be allowed to actually update the bug if they lack the necessary permissions.

jreese

jreese

2008-06-10 09:40

reporter   ~0018050

After further looking, it seems this is because of the due date feature, in attempts to allow the user to update the due date even without persmissions to update anything else.

In my opinion, this should not be allowed, as it could potentially be a security risk, for example, brute-force viewing of private issues because you have access to update due dates.

I think the best solution is to:

  • revert the old-style behavior for the update pages (only those with bug_update_threshold allowed)
  • either: follow the tagging behavior, where you can update it by itself witha special form
  • or: remove the ability to have a separate due date threshold

I'm partial to the second option. Is there really anyone who would have permission to select when a bug is due that wouldn't already have permissions to update the bug in the first place?

vboctor

vboctor

2008-06-27 20:07

manager   ~0018213

I would go with the first option. However, we have to support the case where a user has access to update an issue but not to update the due date. I can see in some installations that users have access to update their issues but not the due date of such issues.

jreese

jreese

2008-07-30 14:05

reporter   ~0018929

Fixed in SVN trunk r5464.

Related Changesets

MantisBT: master 562e08a8

2008-07-30 14:05

jreese


Details Diff
Fix 0009247: Bug updates were not ensuring access levels.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@5464 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0009247
mod - bug_update_advanced_page.php Diff File
mod - bug_update_page.php Diff File
mod - bug_update.php Diff File