0009803: Tags field in filter should not be shown when user has no access to tags - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0009803	mantisbt	tagging	public	2008-11-12 12:41	2008-11-21 16:08

Reporter	olegos	Assigned To	jreese
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	1.2.0a2
Fixed in Version	1.1.5

Summary	0009803: Tags field in filter should not be shown when user has no access to tags
Description	I disabled the tagging feature by setting all tag related config variables to NOBODY in config_inc.php (everything listed in "Bug Tagging" section of config_defaults_inc.php). But the filter still includes the "Tags:" field, and a value can be typed there, and can seemingly be applied (but it doesn't really filter anything!). I think if current user cannot view tags, the filter shouldn't show Tags.
Tags	No tags attached.

jreese 2008-11-12 12:55 reporter ~0019855	Agreed.

jreese 2008-11-13 14:57 reporter ~0019876	Fixed in 1.2.x and 1.1.5 development trees.

olegos 2008-11-13 19:47 reporter ~0019878 Last edited: 2008-11-13 19:48	I think the fix is incomplete. I can still see "Tags:" link, which does some weird stuff when clicked. Don't you need to modify filter_draw_selection_area2() function in filter_api.php? (tried it with 1.2.0a2) Maybe I'm not seeing a complete fix, because I'm going from the changeset attached here...

jreese 2008-11-14 08:53 reporter ~0019891	Got it this time. Fixed in both development trees.

olegos 2008-11-14 17:19 reporter ~0019903	Yep, thanks! (although you may want to also disable the blob of code for the next row as well (tag_string_filter_target))

MantisBT: master fa071c66 2008-11-13 14:53 jreese Details Diff	Fix 0009803: Hide tagging filter if user does not have view access.	Affected Issues 0009803
	mod - core/filter_api.php	Diff File
	mod - view_filters_page.php	Diff File
MantisBT: master-1.1.x 9e6bc9f3 2008-11-13 14:53 jreese Details Diff	Fix 0009803: Hide tagging filter if user does not have view access.	Affected Issues 0009803
	mod - view_filters_page.php	Diff File
	mod - core/filter_api.php	Diff File
MantisBT: master ceab5e80 2008-11-14 08:32 jreese Details Diff	Fix 0009803, part two: Hide tagging filter title if user does not have view access.	Affected Issues 0009803
	mod - core/filter_api.php	Diff File
MantisBT: master-1.1.x 5fc21f1e 2008-11-14 08:32 jreese Details Diff	Fix 0009803, part two: Hide tagging filter title if user does not have view access.	Affected Issues 0009803
	mod - core/filter_api.php	Diff File