Dependency Graph
View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0011039 | mantisbt | api soap | public | 2009-10-14 09:04 | 2010-04-28 14:44 |
| Reporter | MAGMA | Assigned To | rombert | ||
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | no change required | ||
| Product Version | 1.2.0rc2 | ||||
| Target Version | 1.2.0 | Fixed in Version | 1.2.0 | ||
| Summary | 0011039: mc_issue_attachment_get() returns garbage | ||||
| Description | As mc_issue_attachment_add() expects the attachment data to be base64 encoded, mc_issue_attachment_get has to return the attachment data base64 encoded, too. A working patch has been provided as "Additional Information" | ||||
| Steps To Reproduce |
| ||||
| Additional Information | diff -r 2f192cbf1207 api/soap/mc_issue_attachment_api.php
| ||||
| Tags | No tags attached. | ||||
|
OK, you've already fixed it in on the 1.1 branch. Please don't forget to merge the fix for the 1.2 release. Thankx. |
|
|
The related changesets list this being fixed in both branches. Please confirm that it still does not work for you. |
|
|
I have shortly reviewed the lastest versions of api/soap/mc_issue_attachment_api.php in the "master-1.2.x" and "master" development branches. Visually the error is still there. |
|
|
I have manually tested this issue using SOAP UI. The request-reponse cycle for mc_issue_attachment_get is: <soapenv:Envelope xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:man="http://futureware.biz/mantisconnect"> <SOAP-ENV:Envelope xmlns:SOAP-ENV="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:SOAP-ENC="http://schemas.xmlsoap.org/soap/encoding/"> Please note the contents - it is base64 encoded. Furthermore, all execution paths of mci_file_get return base64-encoded content. I did observe that the PHP soap extension on the client side already decodes the base64 contents. I suppose that's a feature, and as long as plain XML requests do the right thing there is nothing to fix. Please reopen if you think this is not correct. |
|
|
I've committed a fix in the soap-attachments branch ( commit at http://git.mantisbt.org/?p=mantisbt.git;a=commit;h=b836b267cfc77aa516968fe05d1804743df133d7 ). Please verify that it does solve the problem you've reported. |
|
|
MantisBT: master-1.2.x d880d59a 2009-10-29 19:25 Details Diff |
Issue 0011039: mc_issue_attachment_get() returns garbage This commits adds a test which verifies that the contents of an attachment is properly encoded and decoded. |
Affected Issues 0011039 |
|
| mod - tests/soap/AllTests.php | Diff File | ||
| add - tests/soap/AttachmentTest.php | Diff File | ||
|
MantisBT: master d47ded46 2009-10-29 19:25 Details Diff |
Issue 0011039: mc_issue_attachment_get() returns garbage This commits adds a test which verifies that the contents of an attachment is properly encoded and decoded. |
Affected Issues 0011039 |
|
| mod - tests/soap/AllTests.php | Diff File | ||
| add - tests/soap/AttachmentTest.php | Diff File | ||
related to
child of
duplicate of