View Issue Details

WikiJump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0010892mantisbtapi soappublic2009-09-01 06:452010-09-19 03:12
Reportertpo Assigned Torombert  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.1.8 
Summary0010892: followup of 0010235 : can't add binary attachment with cropper because attachment is base64-decoded twice
Description

Hi, I use mantis 1.1.8 and I can't add screnshot attachment anymore.

I did a lot of debugging and I found the culprit : diff in 0010235

I don't know why, but in mc_issue_attachment_add, $p_content is already base64 decoded.

If I revert the final line to

return mci_file_add( $p_issue_id, $p_name, $p_content, $p_file_type, 'bug' );

attachment are not corrupted anymore.

TagsNo tags attached.

Relationships

Relationship GraphDependency Graph
related to 0011039 closedrombert mc_issue_attachment_get() returns garbage 

Activities

tpo

tpo

2009-09-01 06:46

reporter   ~0022842

I use cropper to store screenshot
giallu

giallu

2009-09-01 11:01

reporter   ~0022843

Hi, I made the change detailed in 0010235 and I assume you're using the cropper plugin attached to 0007053.

If the attachment is already decoded in mc_issue_attachment_add then it means the sender (cropper) is not encoding it before sending. That's an error on the cropper (or plugin, I don't know) side and should be fixed there
tpo

tpo

2009-09-01 12:38

reporter   ~0022845

Hi, I used wireshark to analyse stream from cropper and the picture was in base64.

I think you will want to look at some example, so I will attach some traces tomorrow.
rombert

rombert

2009-09-01 18:13

reporter   ~0022847

Last edited: 2009-09-01 18:13

In the Mylyn-Mantis connector we work with both versions, before and after 0010235. We have a simple version check, to see if we should base64 encode the file or not.
vboctor

vboctor

2009-10-06 03:31

manager   ~0023072

This is a bug in the MantisConnect .NET client. When it attaches a file from disk, it doesn't base64 encode it. I'll keep this open until I do the following:

  1. Add a .NET unit test case.
  2. Fix the bug in the .NET client.
  3. Make updated version of cropper available.
rombert

rombert

2010-04-28 14:44

reporter   ~0025336

Actually this was determined to be an error in the SOAP API . Please see http://git.mantisbt.org/?p=mantisbt.git;a=commit;h=b836b267cfc77aa516968fe05d1804743df133d7 for details.
rombert

rombert

2010-05-16 05:26

reporter   ~0025507

Last edited: 2010-05-16 05:26

This was fixed for bug 0011151.