Changesets: MantisBT
|
master fc5cb097 2010-03-06 12:05 Details Diff |
Fix 0011624: Update version refs in child projects When updating version names, we need to properly cascade those changes to child projects that are using the inherited version names. This can potentially cause an issue with child projects that have a version with the same name as the parent project, but I believe this mechanism better handles the user's intent, and prevents sites from "breaking" with the new version inheritance feature. A better solution would be to fix versions so that they are referenced by unique IDs everywhere, similar to how categories were upgraded to use IDs instead of duplicating the name everywhere. However, that solution would not be considered within the scope of 1.2 due to schema changes necessary for such a change. Also, the project hierarchy was updated slightly to allow the version API to access a full list of subprojects, including disabled projects. |
Affected Issues 0011624 |
|
| mod - core/version_api.php | Diff File | ||
| mod - core/project_hierarchy_api.php | Diff File | ||
|
master-1.2.x b03397ad 2010-03-04 07:49 Details Diff |
Fix 0011561: Filtering fails for multi-select custom field types When attempting to filter bugs based on multi-select custom fields, some bugs are not returned. This is due to multi-select custom field values being stored as a string in the database with a vertical pipe character being used as a delimiter between values. We can't just check for: LIKE '%|value|%' We also need to check for: LIKE 'value|%' LIKE '%|value' = 'value' To catch all possible cases of a value being stored within a multi-select custom field string. |
Affected Issues 0011561 |
|
| mod - core/database_api.php | Diff File | ||
| mod - core/filter_api.php | Diff File | ||
|
master 73d72e11 2010-03-04 07:49 Details Diff |
Fix 0011561: Filtering fails for multi-select custom field types When attempting to filter bugs based on multi-select custom fields, some bugs are not returned. This is due to multi-select custom field values being stored as a string in the database with a vertical pipe character being used as a delimiter between values. We can't just check for: LIKE '%|value|%' We also need to check for: LIKE 'value|%' LIKE '%|value' = 'value' To catch all possible cases of a value being stored within a multi-select custom field string. |
Affected Issues 0011561 |
|
| mod - core/filter_api.php | Diff File | ||
| mod - core/database_api.php | Diff File | ||
|
master-1.2.x b7b9537d 2010-03-04 06:31 Details Diff |
Fix 0011610: Validate all custom field types MantisBT was only validating certain custom field types. List/checkbox style field values were not being validated making it possible for malicious users to bypass the custom field 'possible values' setting and set custom field values to be whatever they desired. All custom field types are now validated to ensure that selected values are within the bounds of the 'possible values' setting of each custom field. This patch also fixes the radio custom field type so that it no longer behaves like a field with multiple possible values. Only one value can be specified for a radio field, hence there is no need to treat it like an array within gpc_api. |
Affected Issues 0011610 |
|
| mod - core/gpc_api.php | Diff File | ||
| mod - core/cfdefs/cfdef_standard.php | Diff File | ||
| mod - core/custom_field_api.php | Diff File | ||
|
master aa2742da 2010-03-04 06:31 Details Diff |
Fix 0011610: Validate all custom field types MantisBT was only validating certain custom field types. List/checkbox style field values were not being validated making it possible for malicious users to bypass the custom field 'possible values' setting and set custom field values to be whatever they desired. All custom field types are now validated to ensure that selected values are within the bounds of the 'possible values' setting of each custom field. This patch also fixes the radio custom field type so that it no longer behaves like a field with multiple possible values. Only one value can be specified for a radio field, hence there is no need to treat it like an array within gpc_api. |
Affected Issues 0011610 |
|
| mod - core/gpc_api.php | Diff File | ||
| mod - core/custom_field_api.php | Diff File | ||
| mod - core/cfdefs/cfdef_standard.php | Diff File | ||
|
master-1.2.x b1e3df6a 2010-03-04 03:29 Details Diff |
test_langs.php references invalid variable names PHP errors were caused on admin/test_langs.php due to inconsistent naming of variables. |
||
| mod - admin/test_langs.php | Diff File | ||
|
master cf99022f 2010-03-04 03:29 Details Diff |
test_langs.php references invalid variable names PHP errors were caused on admin/test_langs.php due to inconsistent naming of variables. |
||
| mod - admin/test_langs.php | Diff File | ||
|
master 6dd6e7c4 2010-03-04 02:42 Details Diff |
Revert "Fix 0011600: Bugnote direct links include mismatched parenthesis" This reverts commit 02185e9949d512826bc4b8dc23a6c0fb495a5888. |
Affected Issues 0011600 |
|
| mod - bugnote_view_inc.php | Diff File | ||
|
master 4f3906f6 2010-03-04 02:32 Details Diff |
Fix 0011600: Bugnote direct links include mismatched parenthesis In the bugnote direct links in the left column of the "Notes" section of an issue page, the right parenthesis is part of the link but the left parenthesis is not. This patch removes the parenthesis entirely and instead uses the value of $g_bugnote_link_tag as a prefix to the bugnote ID. This technique is a subtle reminder to users of the syntax to use within bugnotes and bug descriptions to refer to a particular bugnote. |
Affected Issues 0011600 |
|
| mod - bugnote_view_inc.php | Diff File | ||
|
master 02185e99 2010-03-04 02:32 Details Diff |
Fix 0011600: Bugnote direct links include mismatched parenthesis In the bugnote direct links in the left column of the "Notes" section of an issue page, the right parenthesis is part of the link but the left parenthesis is not. This patch removes the parenthesis entirely and instead uses the value of $g_bugnote_link_tag as a prefix to the bugnote ID. This technique is a subtle reminder to users of the syntax to use within bugnotes and bug descriptions to refer to a particular bugnote. |
Affected Issues 0011600 |
|
| mod - bugnote_view_inc.php | Diff File | ||
|
master bfd49f38 2010-03-01 08:43 Details Diff |
login_method = LDAP shouldn't warrant a warning | ||
| mod - admin/check/check_crypto_inc.php | Diff File | ||
|
master 21ac0c07 2010-03-01 07:36 Kirill Krasnov Committer: dhx Details Diff |
Update link to check script from admin/index.php Commit ba97560b02d620569ad062d894284722f0acd890 renamed the old admin/check.php script to admin/check/index.php However a link on admin/index.php wasn't updated to point to the new check script. Signed-off-by: David Hicks <hickseydr@optusnet.com.au> |
||
| mod - admin/index.php | Diff File | ||
|
master 457d8c9e 2010-03-01 06:19 Details Diff |
Revert "Issue 0010730: Implement CAPICOM PRNG source for Windows servers" This reverts commit ab7dad32cd2e53124f1cc78cb62964861ee7c87f. Relying upon the CAPICOM.Utilities.1 library for providing a PRNG source for Windows environments seems to be problematic. Problems include lack of CAPICOM libraries in certain Windows environments as well as potentially garbled and unpredictable output from the CAPICOM library. |
Affected Issues 0010730 |
|
| mod - core/crypto_api.php | Diff File | ||
|
master-1.2.x 3cca9275 2010-02-28 20:22 Details Diff |
Fix 0011571: Versions 1.1 and 1.10 are treated as duplicates A problem was discovered on manage_proj_edit_page.php where if versions 1.1 and 1.10 were both shown, clicking 'edit' for 1.1 would bring up the edit version page for the 1.10 version instead. This is due to an incorrect version name comparison in version_get_id whereby the following check between strings was occurring: if( "1.1" == "1.10" ) { ... } PHP evaluates this expression to true because 1.1 and 1.10 are treated as floats. We however need to preserve the string type during this comparison, thus we need to use the === comparison operator instead. |
Affected Issues 0011571 |
|
| mod - core/version_api.php | Diff File | ||
|
master 0e5ad6ca 2010-02-28 20:22 Details Diff |
Fix 0011571: Versions 1.1 and 1.10 are treated as duplicates A problem was discovered on manage_proj_edit_page.php where if versions 1.1 and 1.10 were both shown, clicking 'edit' for 1.1 would bring up the edit version page for the 1.10 version instead. This is due to an incorrect version name comparison in version_get_id whereby the following check between strings was occurring: if( "1.1" == "1.10" ) { ... } PHP evaluates this expression to true because 1.1 and 1.10 are treated as floats. We however need to preserve the string type during this comparison, thus we need to use the === comparison operator instead. |
Affected Issues 0011571 |
|
| mod - core/version_api.php | Diff File | ||
|
master 904e4943 2010-02-27 12:16 Details Diff |
Localisation updates from translatewiki.net (2010-02-27) Signed-off-by: Siebrand Mazeland <s.mazeland@xs4all.nl> |
||
| mod - lang/strings_norwegian_bokmal.txt | Diff File | ||
| mod - lang/strings_spanish.txt | Diff File | ||
| mod - lang/strings_serbian.txt | Diff File | ||
| mod - lang/strings_galician.txt | Diff File | ||
| mod - lang/strings_arabicegyptianspoken.txt | Diff File | ||
|
master-1.2.x 76cd989e 2010-02-26 20:39 Details Diff |
Fix 0011560: ADOdb version check in check.php is incorrect See upstream bug report http://phplens.com/lens/lensforum/msgs.php?id=18320 for the reason as to why this change is necessary. version_compare works with strings, not float values. And the Version() function in ADOdb should not be returning floats anyway (there is no way to determine if the version if 5.1 or 5.10 from a float value). |
Affected Issues 0011560 |
|
| mod - admin/check.php | Diff File | ||
|
master 916f1143 2010-02-26 20:39 Details Diff |
Fix 0011560: ADOdb version check in check.php is incorrect See upstream bug report http://phplens.com/lens/lensforum/msgs.php?id=18320 for the reason as to why this change is necessary. version_compare works with strings, not float values. And the Version() function in ADOdb should not be returning floats anyway (there is no way to determine if the version if 5.1 or 5.10 from a float value). |
Affected Issues 0011560 |
|
| mod - admin/check.php | Diff File | ||
|
master ab7dad32 2010-02-26 19:42 Details Diff |
Issue 0010730: Implement CAPICOM PRNG source for Windows servers First attempt at generating strong randomness on Windows servers by using the CAPICOM.Utilities library call GetRandom(). Needs testing! |
Affected Issues 0010730 |
|
| mod - core/crypto_api.php | Diff File | ||
|
master 1fbfa488 2010-02-26 18:54 Details Diff |
Don't use openssl_random_pseudo_bytes() on Windows (performance reasons) The openssl_random_pseudo_bytes() function seems to perform very slowly on Windows (100% CPU, pages take over a minute to load). Therefore we should disable this function from being used on Windows platforms. |
||
| mod - core/crypto_api.php | Diff File | ||
|
master-1.2.x 5ea26915 2010-02-26 18:39 Details Diff |
Fixes 0011427: Undefined index: id Fix provided by vboctor, supplemented with a SOAP test. |
Affected Issues 0011427 |
|
| mod - tests/soap/IssueAddTest.php | Diff File | ||
| mod - api/soap/mc_api.php | Diff File | ||
|
master 44be8f3f 2010-02-26 18:39 Details Diff |
Fixes 0011427: Undefined index: id Fix provided by vboctor, supplemented with a SOAP test. |
Affected Issues 0011427 |
|
| mod - tests/soap/IssueAddTest.php | Diff File | ||
| mod - api/soap/mc_api.php | Diff File | ||
|
master-1.2.x 888a3561 2010-02-26 18:17 Details Diff |
Fix 0011569: Incorrect variable name in print_page_links() Commit f838e89dc6460f3f2e65d20e4bd904203bd6f880 introduced a bug whereby a variable name was incorrect ($p_emp_filter_id instead of $p_temp_filter_id), thereby causing errors. |
Affected Issues 0011569 |
|
| mod - core/print_api.php | Diff File | ||
|
master 6a424345 2010-02-26 18:17 Details Diff |
Fix 0011569: Incorrect variable name in print_page_links() Commit f838e89dc6460f3f2e65d20e4bd904203bd6f880 introduced a bug whereby a variable name was incorrect ($p_emp_filter_id instead of $p_temp_filter_id), thereby causing errors. |
Affected Issues 0011569 |
|
| mod - core/print_api.php | Diff File | ||
|
master-1.2.x 19b969e9 2010-02-26 08:18 Details Diff |
Fix 0011565: $g_enable_profiles not respected on bug report page On the bug report page, profile fields are shown even with $g_enable_profiles = OFF |
Affected Issues 0011565 |
|
| mod - bug_report_page.php | Diff File | ||
