Changesets: MantisBT

master bddf5d32

2023-08-26 13:05

dregad


Details Diff
Use ProjectDeleteCommand in rest_project_delete()

Fixes 0032232, 0032858
Affected Issues
0032232, 0032858
mod - api/rest/restcore/projects_rest.php Diff File

master f095e36b

2023-08-26 12:22

dregad


Details Diff
UserDeleteCommand: ensure user exists

Fixes 0032858
Affected Issues
0032858
mod - core/commands/UserDeleteCommand.php Diff File

master 40df3eb9

2023-08-26 12:19

dregad


Details Diff
TagDetachCommand: ensure tag exists

Fixes 0032858
Affected Issues
0032858
mod - core/commands/TagDetachCommand.php Diff File

master 14552850

2023-08-26 12:14

dregad


Details Diff
Add test cases for Issue Tag Attach/Detach

Covering
- attach a new tag
- attach existing tag
- detach tag
- detach unattached tag
- detach non-existing tag
- attach/detach on non-existing issue

Issue 0032858
Affected Issues
0032858
mod - tests/rest/RestIssueTest.php Diff File

master 2aff8062

2023-08-26 12:11

dregad


Details Diff
Fix static analysis warnings
mod - tests/rest/RestIssueTest.php Diff File

master 59f62a71

2023-08-26 12:09

dregad


Details Diff
Adapt RestUserTests::testDeleteUserById()

Update the test case to prepare for change of returned status code to
404 when trying to delete a non-existing user.

Remove the assertion from RestBase::tearDown(), the check for a
successful deletion should be done in the actual test cases.

Issue 0032858
Affected Issues
0032858
mod - tests/rest/RestBase.php Diff File
mod - tests/rest/RestUserTest.php Diff File

master 089a6c84

2023-08-26 12:03

dregad


Details Diff
Remove invalid usernames from the data provider

Based on the default value for $g_user_login_valid_regex

- `vboctor@localhost` -> a TLD is required
- `user!` -> only letters, numbers, `-.+_` and space are allowed
mod - tests/rest/RestUserTest.php Diff File

master 625b4069

2023-08-26 11:59

dregad


Details Diff
Fix RestUserTests::testCreateUserMinimal()

The test case was defined with a data provider, but did not actually
use it...
mod - tests/rest/RestUserTest.php Diff File

master a19795b5

2023-08-26 11:56

dregad


Details Diff
Use more specialized assertions
mod - tests/rest/RestIssueTest.php Diff File
mod - tests/rest/RestProjectVersionTest.php Diff File
mod - tests/rest/RestUserTest.php Diff File

master 5bd40a5f

2023-08-26 11:38

dregad


Details Diff
bug_exists() never throws an exception

Update PHPDoc and @noinspection tags accordingly.
mod - core/bug_api.php Diff File

master 925297a6

2023-08-26 08:02

dregad


Details Diff
Rest API issue relationship add/delete fixes

Merge PR https://github.com/mantisbt/mantisbt/pull/1906
mod - api/soap/mc_issue_api.php Diff File
mod - core/commands/IssueRelationshipAddCommand.php Diff File
mod - core/relationship_api.php Diff File
add - tests/rest/RestIssueRelationshipsTest.php Diff File
mod - tests/soap/RelationshipTest.php Diff File

master-2.25 37f65a58

2023-08-26 06:30

dregad


Details Diff
Prevent API resolving parent with unresolved children

There are discrepancies between issue updates from the GUI vs the API,
as bug_udpate.php has not been kept in sync with mc_issue_update().

This is a quick fix for one of these occurrences; REST/SOAP API allowed
mc_issue_update() to resolve a parent Issue having unresolved children
while the GUI does not (unless $g_allow_parent_of_unresolved_to_close
is ON).

The proper, long-term solution to this problem is to implement a new
IssueUpdateCommand to ensure consistent behavior (see Issue 0032861).

Fixes 0032860

(cherry picked from commit 007e3f1aecac0b804f101dc40df82d03f395def0)
Affected Issues
0032860, 0032861
mod - api/soap/mc_issue_api.php Diff File

master 007e3f1a

2023-08-26 06:30

dregad


Details Diff
Prevent API resolving parent with unresolved children

There are discrepancies between issue updates from the GUI vs the API,
as bug_udpate.php has not been kept in sync with mc_issue_update().

This is a quick fix for one of these occurrences; REST/SOAP API allowed
mc_issue_update() to resolve a parent Issue having unresolved children
while the GUI does not (unless $g_allow_parent_of_unresolved_to_close
is ON).

The proper, long-term solution to this problem is to implement a new
IssueUpdateCommand to ensure consistent behavior (see Issue 0032861).

Fixes 0032860
Affected Issues
0032860, 0032861
mod - api/soap/mc_issue_api.php Diff File

master 1c6e035d

2023-08-26 06:13

dregad


Details Diff
Test deletion of parent issue with unresolved children
mod - tests/rest/RestIssueRelationshipsTest.php Diff File

master 2307f0bd

2023-08-25 08:05

dregad


Details Diff
Whitespace
mod - tests/soap/RelationshipTest.php Diff File

master 485c0d84

2023-08-24 07:11

translatewiki.net


Details Diff
Localisation updates from https://translatewiki.net. [skip ci]
mod - lang/strings_lithuanian.txt Diff File

master 0adab695

2023-08-18 19:28

dregad


Details Diff
Add PHPUnit test for REST Issue Relationships

Fixes 0032835
Affected Issues
0032835
add - tests/rest/RestIssueRelationshipsTest.php Diff File

master 957ef4ff

2023-08-18 19:20

dregad


Details Diff
Exception if relationship type id does not exist

IssueRelationshipAddCommand checks for invalid relationship name in the
payload, but lacks the same check when using a relationship id.

This lets the API create invalid relationships that can't be deleted and
cause errors when viewing the related Issues in the GUI.

Also changed the error code used for invalid rel type, to make it
consistent with invalid rel name.

Fixes 0032835
Affected Issues
0032835
mod - core/commands/IssueRelationshipAddCommand.php Diff File
mod - core/relationship_api.php Diff File

master 33dbef25

2023-08-18 18:17

dregad


Details Diff
PHP 7.2 minimum version, PHPUnit 8.5 upgrade

PR https://github.com/mantisbt/mantisbt/pull/1903
mod - .gitignore Diff File
mod - .travis.yml Diff File
mod - README.md Diff File
mod - build/travis_before_script.sh Diff File
mod - build/travis_script.sh Diff File
mod - composer.json Diff File
mod - composer.lock Diff File
mod - core/constant_inc.php Diff File
mod - docbook/Admin_Guide/en-US/Installation.xml Diff File
mod - docbook/Developers_Guide/en-US/Contributors.xml Diff File
add - phpunit.xml Diff File
rm - tests/AllTests.php Diff
rm - tests/Mantis/AllTests.php Diff
mod - tests/Mantis/ConfigParserTest.php Diff File
mod - tests/Mantis/MantisCoreBase.php Diff File
mod - tests/Mantis/PluginTest.php Diff File
mod - tests/Mantis/UserTest.php Diff File
add - tests/fakesendmail.sh Diff File
rm - tests/rest/AllTests.php Diff
mod - tests/rest/RestBase.php Diff File
mod - tests/rest/RestImpersonateUserTest.php Diff File
mod - tests/rest/RestIssueTest.php Diff File
mod - tests/rest/RestProjectVersionTest.php Diff File
mod - tests/rest/RestUserTest.php Diff File
rm - tests/soap/AllTests.php Diff
mod - tests/soap/AttachmentTest.php Diff File
mod - tests/soap/CategoryTest.php Diff File
mod - tests/soap/EnumTest.php Diff File
mod - tests/soap/IssueAddTest.php Diff File
mod - tests/soap/ProjectTest.php Diff File
mod - tests/soap/SoapBase.php Diff File
mod - tests/soap/TagTest.php Diff File
mod - tests/soap/VersionTest.php Diff File

master 0e1fce2a

2023-08-18 18:14

dregad


Details Diff
Upgrade to PHPUnit 8.5

Fixes 0032810
Affected Issues
0032810
mod - .gitignore Diff File
mod - .travis.yml Diff File
mod - build/travis_script.sh Diff File
mod - composer.json Diff File
mod - composer.lock Diff File
mod - docbook/Developers_Guide/en-US/Contributors.xml Diff File
add - phpunit.xml Diff File
rm - tests/AllTests.php Diff
rm - tests/Mantis/AllTests.php Diff
mod - tests/Mantis/ConfigParserTest.php Diff File
mod - tests/Mantis/MantisCoreBase.php Diff File
mod - tests/Mantis/PluginTest.php Diff File
mod - tests/Mantis/UserTest.php Diff File
add - tests/fakesendmail.sh Diff File
rm - tests/rest/AllTests.php Diff
mod - tests/rest/RestBase.php Diff File
mod - tests/rest/RestImpersonateUserTest.php Diff File
mod - tests/rest/RestIssueTest.php Diff File
mod - tests/rest/RestProjectVersionTest.php Diff File
mod - tests/rest/RestUserTest.php Diff File
rm - tests/soap/AllTests.php Diff
mod - tests/soap/AttachmentTest.php Diff File
mod - tests/soap/CategoryTest.php Diff File
mod - tests/soap/EnumTest.php Diff File
mod - tests/soap/IssueAddTest.php Diff File
mod - tests/soap/ProjectTest.php Diff File
mod - tests/soap/SoapBase.php Diff File
mod - tests/soap/TagTest.php Diff File
mod - tests/soap/VersionTest.php Diff File

master 49b6c809

2023-08-18 11:56

dregad


Details Diff
Remove code duplication

Introduce new internal function relationship_prepare_for_assignment()
mod - core/relationship_api.php Diff File

master 7d30751d

2023-08-18 11:51

dregad


Details Diff
Variable naming consistency

$p_relationship_code -> $p_relationship_type, in line with usage in the
rest of the script.
mod - core/relationship_api.php Diff File

master 678718fa

2023-08-18 11:50

dregad


Details Diff
Fix static analysis warnings (missing @throws tags)
mod - core/relationship_api.php Diff File

master c511d709

2023-08-18 11:44

dregad


Details Diff
PHPDoc
mod - core/relationship_api.php Diff File

master 60667b21

2023-08-18 11:28

dregad


Details Diff
Throw Exception instead of calling trigger_error()

Ensures expected failure behavior from REST API when attempting to
delete an existing relationship not linked to the given (existing)
issue.

Fixes 0032835
Affected Issues
0032835
mod - core/relationship_api.php Diff File
 First  Prev  1 2 3 ... 69 70 71 72 73 74 75 ... 80 ... 160 ... 240 ... 320 ... 400 ... 480 ... 560 ... 640 ... 720 ... 762 763 764  Next  Last