View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0011080 | mantisbt | administration | public | 2009-10-26 09:44 | 2019-06-28 17:40 |
Reporter | atrol | Assigned To | community | ||
Priority | normal | Severity | feature | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Summary | 0011080: Add a feature to reflect that a user is absent | ||||
Description | Suggestion: provide a "I am absent" check box in "My account" page When someone wants to assign absent user this should be marked in a special way. When user logs in and is marked absent, he should be remembered that he is marked absent. Luxury: | ||||
Additional Information | This feature is supported by a pluginDownload, discuss and get support on https://github.com/mantisbt-plugins/Holidays | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
kick This would be very helpful, because a the moment we just give the order to the users to manually "accept" the ticket, so the reporter has a feedback. Otherwise he donĀ“t know, if the ticket was even read. |
|
as described in 0015339, this could be handled by the same plugin. |
|
cas, if you feel like writing a plugin and need new events, feel free to request them (preferably with pull request or unified diff) |
|
Since we can use this functionality too, i will create the plugin. For the additional events I will supply an unified diff. Hope to realize this plugin somewhere this month. |
|
attached an initial version,please test |
|
That was a short month ;-) Preliminary note: I have not actually tested the plugin itself, just took a quick look at with specific focus on the new events. Some comments:
While we're at it, I think it may make sense to add a few additional events to MantisBT core to provide a more comprehensive set of hook points for future plugins revolving around user accounts management (e.g. creation, update, etc). That's it for now. |
|
well it is not finished yet.......... |
|
Added an updated version based upon initial comments. |
|
Parse error: syntax error, unexpected T_STRING, expecting ']' in /var/www/clients/client0/web16/web/plugins/Holidays/Holidays.php on line 63 In line 54 change to $mail[1] = $row['backup_user']; |
|
Thanks for reporting, fixed in next version. |
|
Added version 0.92 including patches for mantis (excluded events_inc.php though). These can be found in the DOC directory. |
|
Think I should use a different event in manage_user pages from account_page. |
|
A slight change in lay-out of the form used to define once holiday. |
|
Unfortunately I can't test patches on our instance of Mantis (it's under heavy use and could cause troubles if something goes wrong with a patch), but I'm eagerly awaiting this feature in a release. Is there a target version for this feature? |
|
I'll try to have a look later this week if I can manage |
|
@yany, implementing a new version seems to have more impact than applying intotal 4 patches. |
|
Added a check @ system startup if user is authenticated |
|
Considering that you are one of the requestors of this new feature, and it's due to your pressure that cas agreed to develop the plugin, I think it's the least you could do to actually perform some tests. I fully understand you not wanting to do so on a Prod system, but it should not be too difficult to copy the DB and setup a test instance where you can play without disruption to normal activity, no ? |
|
I have moved this into our production environment. |
|
Adjusted the update routine in case no dates are needed. |
|
@cas |
|
Was hoping to have more feedback before releasing another version. |
|
As far as I am concerned, this issue can be closed. |
|
I have tested this plugin and it works like a charm! Maybe it's possible to complete it, so it can be implemented without patching the mantis-core-files manually? Attached you will find my german translation file and a new english_lang-file (because you missed one string) |
|
And there was a problem in holidy_update.php (Path to account_page.php was wrong). I just replaced the last line: //print_header_redirect( $script ); |
|
A bit off topic, but we shouldn't introduce new technical debt in old branches: dregad wrote at 0011080:0034702 The question is: Should we go on to trigger such kind of events on UI side (e.g. account_delete.php, manage_user_delete.php)? I think we should change this also for some of the existing events as they get not triggered by bulk operations ("View Issues" page) and by the SOAP API. @cas @JeromyK , you get some error messages when checking the language files (run admin/test_langs.php) |
|
I agree, that it would be better to use existing events insteed of generating new ones for the same event. Thanks for the hint, I will test the files with test_langs.php and upload a patched version |
|
I attached Holidys98.zip with new lang-files and replaced holiday_update.php @Admin |
|
JeromyK, you can help to make cas happy by updating also doc/changelog.txt and $this->version in Holidays.php Still hoping that cas will use https://github.com/mantisbt-plugins to share his code instead of adding .zip-Files to issues. |
|
Done Topic: Github |
|
Hi there, We installed this plugin on our 1.2.15 Mantis installation and are getting the following message on users' "My Account" page, printed out before the footer and after the "Update User" button: event_signal( 'EVENT_ACCOUNT_UPDATE_FORM'); And no Holiday settings show up. When I login as Administrator, however, and go to "Manage Users," I can select a user and their Holiday settings show up. Can you give some tips as to why the Holiday settings don't show up when the user is trying to access them through "My Account"? |
|
This is caused by a wrong instruction in install.txt This section should be replaced by |
|
I have tried implementing the Holiday Plugin with all the settings as instructed in the Install.txt, also incorporated with the changes as proposed in the Note 0038049 By, atrol (developer) Post configuration of this plugin, a newly registered user is getting the following ERROR, when he/she follows the link triggered by Mantis upon self registration. APPLICATION ERROR #200 A required parameter to this page (user_id) was not found. Please use the "Back" button in your web browser to return to the previous page. There you can correct whatever problems were identified in this error or select another action. You can also click an option from the menu bar to go directly to a new section. |
|
Hello, We are eager to enjoy the benefits of such a plug-in in our current configuration (MantisBT version 2.5.1). Is the plug-in noted here (or a similar one) available that can provide the noted out-of-office notification functionality? Thanks very much, |
|
I have this plugin available for version2 of mantis, will release here shortly |
|
Heer is the initial version of this plugin. Have a go so I can release it shortly via Github |
|
Hi @cas did you create a git repo for this? I like to contribute |
|
Clan_destina, |
|
Hello, I tried to install version 2.01 on Mantis 2.21 (latest as of today), and have an internal error that I will debug next week. We would like to integrate this kind of functionnality to Mantis core so that this unofficial plugin does not have to be maintained anymore, especially the following :
Do you think it's feasible and a good idea ? Thanks |
|
@c2pil implementing this functionality in core would need database schema changes. |
|
I know I said over 6 years ago (0011080:0034740) that I'd be looking at this next week, turns out I never did... Sorry about that ;-) Personally, I don't think we should implement this feature in core. A plugin can easily do the job, and considering that the basis already exists with @cas's work, then my recommendation would be to make sure we publish the necessary events so that it is not required for the plugin's users to keep patching Mantis to use it. And move the code from zip files here, into a proper repository on GitHub's mantisbt-plugins organization. |
|
When do you think would be the start of a 3.x version, if it were to be decided that way ? I will start from @cas's plugin to fit my needs, move everything in a GitHub repo and define some events in a PR if necessary. |
|
No idea at this time.
Thanks for your understanding and collaboration. Let us know if you need anything. Until then, you may find reading https://mantisbt.org/wiki/doku.php/mantisbt:plugins:start#hosting_a_new_plugin useful for the process to host the repo in mantisbt-plugins org. Also, if it's not too much to ask, I would suggest, in the interest of keeping the original plugin's history, to initialize the repo with one commit per zip file attached here, and tag the respective versions. Or even better, maybe @cas has it under source control locally. |
|
@c2pil, so I can assume that you take over my Holidays plugin? That is good news, active mainetnance can only benefit the community. |
|
Here is the repository I initiated : No further development at the moment, I will try to make it work on my machine first. How does https://github.com/mantisbt-plugins work ? |
|
As mentioned in 0011080:0062237 I've already created the plugin's team and sent you an invitation to join. Let me know when you've transferred ownership, so I can finalize. |
|
@dregad Thanks a lot, I didn't check the docs before asking, my bad.. |
|
Cheers. For the record, even after transferring ownership of the repository, you would still retain push access to it. |
|
I've been trying to implement this plugin in several versions of Mantis, without success. I think the problem is due to the javascript datepicker, as it looks for a function called "date_print_calendar" that is not found inside date_api.php. Have you guys been encountering the issue as well or did I do something wrong ? |
|
@Raekh You can find here how I did it : https://github.com/c2pil/Holidays/blob/v2.21/pages/holiday_form.php. @dregad, I'm ready to transfer ownership of the repo, and even another one (Eannounce) if you wish. The invite you sent before expired or has been cancelled |
|
@c2pil as far as I can tell, you have successfully joined the org. That should let you transfer ownership of any repo. |
|
@dregad Thanks, an invite was sent for another plugin. Could I join the Holidays plugin team to transfer ownership ? |
|
As member of the org, you should be able to transfer ownership of any repository, without being a member of a specific group. |
|
The Holidays plugin has been transferred |
|
This plugin is now hosted in the mantisbt-plugins organization on GitHub : https://github.com/mantisbt-plugins/Holidays Many thanks to @c2pil for creating the repository and taking ownership of the plugin's maintenance. |
|