| Additional Information | Seems that this piece of code is the problem
bugnote_view_inc.php
$t_access_level = access_get_project_level( null, (int)$t_bugnote->reporter_id );
echo '(', get_enum_element( 'access_levels', $t_access_level ), ')';
if I undertand right, the returnvalue of access_get_project_level will be ANYBODY (=0) in this case
and get_enum_element( 'access_levels', 0 ) delivers (@0@)
Adding a value for 0 in access_levels would certainly fix this problem, but maybe will have unwanted side effects.
Possibly this is at least a workaround:
Introduce a new function access_get_project_level_string which delivers something like lang_get( 'access_level_anybody_string' ) for input value ANYBODY and the enum element for all other values.
More clean?: ANYBODY access level is introduced system wide, so that every user is per default ANYBODY and has ANYBODY access level for private projects. (which means has no rights) |
|---|
| Attached Files |
11923-bugnote-access_level-0.patch (1,075 bytes)
From a746e1d434882be3775c9a4722aed2ee40781e16 Mon Sep 17 00:00:00 2001
From: Lapinkiller <lapinkiller@hotmail.fr>
Date: Thu, 28 Jul 2011 14:33:14 +0200
Subject: [PATCH] bugnote access_level=0 mantis#11923
---
bugnote_view_inc.php | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/bugnote_view_inc.php b/bugnote_view_inc.php
index 9332839..0f65440 100644
--- a/bugnote_view_inc.php
+++ b/bugnote_view_inc.php
@@ -119,8 +119,12 @@ $num_notes = count( $t_bugnotes );
<span class="small"><?php
if ( user_exists( $t_bugnote->reporter_id ) ) {
$t_access_level = access_get_project_level( null, (int)$t_bugnote->reporter_id );
- echo '(', get_enum_element( 'access_levels', $t_access_level ), ')';
+ //No label if access_level is 0
+ if($t_access_level>0 && $t_access_level){
+ echo '(', get_enum_element( 'access_levels', $t_access_level ), ')';
+ }
}
+
?></span>
<?php if ( VS_PRIVATE == $t_bugnote->view_state ) { ?>
<span class="small">[ <?php echo lang_get( 'private' ) ?> ]</span>
--
1.7.6.msysgit.0
|
|---|
