View Issue Details

IDProjectCategoryView StatusLast Update
0012846mantisbthtmlpublic2014-12-08 02:07
ReporterKirill Assigned Todhx  
PriorityhighSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version1.3.0dev 
Target Version1.3.0-beta.1 
Summary0012846: Error generated structure-dom in views.php for international translate with < and >
Description

Ошибка синтаксического анализа XML: несоответствующий тег. Ожидается: </Метки>.

Строка 87, символ 31:
<option value="0"><Метки></option> </select>

Error parcing XML: not correct tag. Waiting: </Метки>

Line 87, char 31:
<option value="0"><Метки></option> </select>

Tagspatch
Attached Files
0012846.patch (1,096 bytes)   
From f4fc735c615d62f4f97d810835e28fb19f749ef4 Mon Sep 17 00:00:00 2001
From: Kirill Krasnov <krasnovforum@gmail.com>
Date: Mon, 22 Nov 2010 11:46:03 +0200
Subject: [PATCH] =?UTF-8?q?Fix=20inclorrect=20code=20when=20translation=20string=20user=20tag-chars=20such=20Russian=20<=D0=9C=D0=B5=D1=82=D0=BA=D0=B8>?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 core/print_api.php |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/core/print_api.php b/core/print_api.php
index 4137ab5..69b6c38 100644
--- a/core/print_api.php
+++ b/core/print_api.php
@@ -343,7 +343,7 @@ function print_tag_input( $p_bug_id = 0, $p_string = '' ) {
 function print_tag_option_list( $p_bug_id = 0 ) {
 	$t_rows = tag_get_candidates_for_bug( $p_bug_id );
 
-	echo '<option value="0">', lang_get( 'tag_existing' ), '</option>';
+	echo '<option value="0">', string_html_specialchars( lang_get( 'tag_existing' ) ), '</option>';
 	foreach ( $t_rows as $row ) {
 		$t_string = $row['name'];
 		if ( !empty( $row['description'] ) ) {
-- 
1.7.4.msysgit.0

0012846.patch (1,096 bytes)   

Relationships

related to 0015721 closedgrangeway Functionality to consider porting to master-2.0.x 

Activities

dhx

dhx

2011-03-11 05:12

reporter   ~0028400

Applied. Thanks.

In the future we're aiming to automatically escape all translation strings in the HTML output to avoid problems like this one.

grangeway

grangeway

2013-04-05 17:57

reporter   ~0036464

Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch

Related Changesets

MantisBT: master 9483d52f

2010-11-22 04:46

Kirill Krasnov

Committer: dhx


Details Diff
Fix 0012846: Escape translation string user tag-chars such Russian <Метки>

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0012846
mod - core/print_api.php Diff File

MantisBT: master-1.2.x f190021f

2010-11-22 04:46

Kirill Krasnov

Committer: dhx


Details Diff
Fix 0012846: Escape translation string user tag-chars such Russian <Метки>

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
Affected Issues
0012846
mod - core/print_api.php Diff File