0013054: Installer displays a blank page if core.php encounters a critical error

ID	Project	Category	View Status	Date Submitted	Last Update
0013054	mantisbt	installation	public	2011-06-06 10:35	2014-09-23 18:05

Reporter	skayser	Assigned To	dregad
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	1.2.5
Target Version	1.2.15	Fixed in Version	1.2.15

Summary	0013054: Installer displays a blank page if core.php encounters a critical error
Description	admin/install.php uses the @ operator when including core.php. Thus, if core.php encounters any critical issues (e.g. a missing PHP session module), install.php will fail silently - presenting the admin with a blank page instead of an indication as to what went wrong. The PHP error log won't contain errors either. The extent to which @ suppresses errors is more of a PHP issue, but the specific situation with install.php is potentially frustrating for new and seasoned Mantis admins alike. Some sort of error indication would be good.
Steps To Reproduce	Unpack Mantis on a system with PHP Disable or uninstall the session module Access admin/install.php from a browser
Additional Information	Possibly similar issue reported in the user forums http://www.mantisbt.org/forums/viewtopic.php?f=3&t=19345
Tags	No tags attached.

MantisBT: master-1.2.x ac05a43e 2013-02-27 04:21 dregad Details Diff	Fix 0013054: Install: don't suppress errors when including libraries	Affected Issues 0013054
	mod - admin/install.php	Diff File
MantisBT: master 07d23bc1 2013-02-27 04:30 dregad Details Diff	Fix 0013054: Install: don't suppress errors when including libraries	Affected Issues 0013054
	mod - admin/install.php	Diff File

dregad 2013-02-27 04:32 developer ~0035324	I don't see any reason for suppressing errors here.

grangeway 2013-04-05 17:56 reporter ~0036088	Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch