From 11963e9f74c7bff149bd538ef8ad2ee5d10607bc Mon Sep 17 00:00:00 2001
From: Damien Regad <damien.regad@merckserono.net>
Date: Thu, 16 Jun 2011 13:23:44 +0200
Subject: [PATCH 1/2] Fix #13085: do not display "Create Tag" link when user can't edit tags

---
 manage_tags_page.php |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/manage_tags_page.php b/manage_tags_page.php
index 4ec6db0..c33d5d0 100644
--- a/manage_tags_page.php
+++ b/manage_tags_page.php
@@ -132,8 +132,12 @@ $t_result = db_query_bound( $t_query, $t_where_params, $t_per_page, $t_offset );
 <table class="width100" cellspacing="1">
 	<tr>
 		<td class="form-title" colspan="4">
-			<?php echo lang_get( 'manage_tags_link' ) ?> [<?php echo $t_total_tag_count ?>]
-			<?php print_link( '#tagcreate', lang_get( 'tag_create' ) ) ?>
+			<?php
+				echo lang_get( 'manage_tags_link' ) . ' [' . $t_total_tag_count . '] ';
+				if ( $t_can_edit ) {
+					print_link( '#tagcreate', lang_get( 'tag_create' ) );
+				}
+			?>
 		</td>
 	</tr>
 	<tr class="row-category">
-- 
1.7.4.1

From cab1f6d6aeffa354de2f48289ac20b9bfb118c03 Mon Sep 17 00:00:00 2001
From: Damien Regad <damien.regad@merckserono.net>
Date: Thu, 16 Jun 2011 14:17:18 +0200
Subject: [PATCH 2/2] Fix #13085: Allow Manage Tags only for global level >= tag_edit_threshold

Previously the level check in function print_manage_menu was made at project
level, which is not consistent with globally managed Tags.

The access level check change in manage_tags_page.php is for consistency,
only to avoid users without the proper access level trying to reach the page
directly, even though it would only display a read-only list of tags.
---
 core/html_api.php    |    2 +-
 manage_tags_page.php |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/html_api.php b/core/html_api.php
index c3920bc..40611a0 100644
--- a/core/html_api.php
+++ b/core/html_api.php
@@ -967,7 +967,7 @@ function print_manage_menu( $p_page = '' ) {
 	if( access_has_project_level( config_get( 'manage_project_threshold' ) ) ) {
 		print_bracket_link( helper_mantis_url( $t_manage_project_menu_page ), lang_get( 'manage_projects_link' ) );
 	}
-	if( access_has_project_level( config_get( 'tag_edit_threshold' ) ) ) {
+	if( access_has_global_level( config_get( 'tag_edit_threshold' ) ) ) {
 		print_bracket_link( helper_mantis_url( $t_manage_tags_page ), lang_get( 'manage_tags_link' ) );
 	}
 	if( access_has_global_level( config_get( 'manage_custom_fields_threshold' ) ) ) {
diff --git a/manage_tags_page.php b/manage_tags_page.php
index c33d5d0..0718160 100644
--- a/manage_tags_page.php
+++ b/manage_tags_page.php
@@ -32,7 +32,7 @@ require_once( 'tag_api.php' );
 require_once( 'user_pref_api.php' );
 require_once( 'form_api.php' );
 
-access_ensure_global_level( config_get( 'tag_view_threshold' ) );
+access_ensure_global_level( config_get( 'tag_edit_threshold' ) );
 
 compress_enable();
 
-- 
1.7.4.1