View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0013123 | mantisbt | time tracking | public | 2011-07-06 09:11 | 2014-09-23 18:05 |
| Reporter | dregad | Assigned To | rombert | ||
| Priority | low | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.2.5 | ||||
| Target Version | 1.2.6 | Fixed in Version | 1.2.6 | ||
| Summary | 0013123: Bug notes of type "reminder" display time tracking information | ||||
| Description | When a reminder is added to a bug, a bugnote record of type 1 (reminder) is created. As this record is printed by bugnote_view_inc.php, time tracking information is also printed which is not correct. | ||||
| Steps To Reproduce | Add a reminder to a bug and examine the resulting output in view issue details page. To make it more obvious, add some text in the time tracking display in bugnote_view_inc.php (line 188). | ||||
| Additional Information | This is normally not very visible because standard Mantis just displays the time spent in bold characters, and since that is 0 for reminder notes, a blank line is printed. However, in my implementation I added some descriptive text plus an <hr> tag after the time tracking data, to more clearly separate that from the bug note itself, which made the error obvious. | ||||
| Tags | patch | ||||
| Attached Files | 0001-Fix-13123-Reminder-Bug-notes-display-time-tracking-i.patch (962 bytes)
From 9c413e3302ec0a7e29346ae95725f6030e381373 Mon Sep 17 00:00:00 2001
From: Damien Regad <damien.regad@merckserono.net>
Date: Wed, 6 Jul 2011 15:08:04 +0200
Subject: [PATCH] Fix #13123: Reminder Bug notes display time tracking information
This was caused by a missing break statement at the end of the switch
case handling Reminder bug notes
---
bugnote_view_inc.php | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/bugnote_view_inc.php b/bugnote_view_inc.php
index 9332839..6448a34 100644
--- a/bugnote_view_inc.php
+++ b/bugnote_view_inc.php
@@ -183,6 +183,7 @@ $num_notes = count( $t_bugnotes );
$t_to[] = prepare_user_name( $t_recipient );
}
echo implode( ', ', $t_to ) . '</em><br /><br />';
+ break;
case TIME_TRACKING:
if ( access_has_bug_level( config_get( 'time_tracking_view_threshold' ), $f_bug_id ) ) {
echo '<b><big>', $t_time_tracking_hhmm, '</big></b><br /><br />';
--
1.7.4.1
Fix-13123-for-master.patch (964 bytes)
From 187c857c3e3b8895144df7e0a0a1f399041dbd82 Mon Sep 17 00:00:00 2001
From: Damien Regad <damien.regad@merckserono.net>
Date: Wed, 6 Jul 2011 15:08:04 +0200
Subject: [PATCH] Fix #13123: Reminder Bug notes display time tracking information
This was caused by a missing break statement at the end of the switch
case handling Reminder bug notes
---
bugnote_view_inc.php | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/bugnote_view_inc.php b/bugnote_view_inc.php
index a6581bf..dc3c5f4 100644
--- a/bugnote_view_inc.php
+++ b/bugnote_view_inc.php
@@ -246,6 +246,7 @@ $num_notes = count( $t_bugnotes );
$t_to[] = prepare_user_name( $t_recipient );
}
echo implode( ', ', $t_to ) . '</em><br /><br />';
+ break;
case TIME_TRACKING:
if ( access_has_bug_level( config_get( 'time_tracking_view_threshold' ), $f_bug_id ) ) {
echo '<div class="time-tracked">', $t_time_tracking_hhmm, '</div>';
--
1.7.4.1
| ||||
|
MantisBT: master eb1f8184 2011-07-06 09:08 Damien Regad Committer: rombert Details Diff |
Fix 0013123: Reminder Bug notes display time tracking information This was caused by a missing break statement at the end of the switch case handling Reminder bug notes Signed-off-by: Robert Munteanu <robert.munteanu@gmail.com> |
Affected Issues 0013123 |
|
| mod - bugnote_view_inc.php | Diff File | ||
|
MantisBT: master-1.2.x b924569b 2011-07-06 09:08 Damien Regad Committer: rombert Details Diff |
Fix 0013123: Reminder Bug notes display time tracking information This was caused by a missing break statement at the end of the switch case handling Reminder bug notes Signed-off-by: Robert Munteanu <robert.munteanu@gmail.com> |
Affected Issues 0013123 |
|
| mod - bugnote_view_inc.php | Diff File | ||
