0013276: missing "attachments" column header in view_all_bug_page - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0013276	mantisbt	attachments	public	2011-08-30 11:36	2014-09-23 18:05

Reporter	~~ckonnerth~~	Assigned To	dregad
Priority	normal	Severity	minor	Reproducibility	sometimes
Status	closed	Resolution	fixed
Product Version	1.2.1
Target Version	1.2.9	Fixed in Version	1.2.9

Summary	0013276: missing "attachments" column header in view_all_bug_page
Description	The config value $g_show_attachment_indicator seems not to be evaluated properly. In my case it was turned off, but I still had the column "attachment_count" available in My Account -> Manage Columns, so the attachment indicator is shown for every issue row, but the corresponding column header with the attachment indicator is missing and the rest of the column headers are shown too early. Why I chose "sometimes"-repro: I didn't notice the problem until I installed (and tested) my changes to our test system. On the dev system the problem didn't occur (attachment indicators have been shown properly, even with $g_show_attachment_indicator turned off). This may be due to different config values in the database (sources are identical on both systems), but I couldn't figure out the significant settings for the moment. I'll tell you, if I can find some more information.
Tags	No tags attached.
Attached Files	fix-attach-column-13276.tar.gz (1,750 bytes)

dregad 2011-08-31 08:12 developer ~0029603	It indeed looks like the behavior of the 'attachment' column is not consistent - with $g_show_attachment_indicator = ON the column is displayed and the paperclip bitmap is displayed, and with $g_show_attachment_indicator = OFF, the count of attachment is printed. I was not able to replicate the behavior you described, of disaligned columns, would appreciate if you can provide steps to reproduce problem. I discussed with dhx (another developer) and we'll probably get rid of this option entirely as it does not really make sense. I'm working on a patch.

dregad 2011-08-31 10:12 developer ~0029605	You might want to take a look at 2 possible fixes for this - not sure yet which one to go for. https://github.com/dregad/mantisbt/commits/fix-attach-column-13276 https://github.com/dregad/mantisbt/commits/remove-show_attachment_indicator As I'm not able to replicate the missing column thing myself, you can hopefully tell me whether either or both versions do the trick for you.

dregad 2011-10-21 12:30 developer ~0030023 Last edited: 2011-10-21 12:44	After discussing with dhx (see #mantishelp IRC log transcript for 31-Aug-2011), we took the decision to completely remove the $g_show_attachment_indicator setting. As the solution to remove the config option was selected (remove-show_attachment_indicator branch), I'm storing here for the record the alternative which was fixing this issue while keeping the option (fix-attach-column-13276.tar.gz)

TomR 2012-01-23 09:45 reporter ~0031007	Does this mean that on is NOT able to select to sort on attachment(s) anymore in the filter? Is there another way to select / view only issues with one ore more attachments?

dregad 2012-01-23 14:39 developer ~0031009	The attachment_count column is not sortable or usable as a filter, and I don't believe it was the case before this change was implemented.

TomR 2012-01-23 17:26 reporter ~0031010	That were my thoughts too, however can you think of any way to select / filter on issues with attachments?

dregad 2012-01-24 06:13 developer ~0031016	TomR, please follow 0008836 for attachment filtering.

grangeway 2013-04-05 17:57 reporter ~0036301	Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch

MantisBT: master d5a0ea7b 2011-08-31 01:31 dregad Details Diff	Correct naming of attachments column Commit 97b67e4bbb2f2df5f6fb24eea5b4bb37e1c28acd introduced some changes to the BugData class: the 'attachment' column was renamed to 'attachment_count'. This change was not cascaded everywhere, which resulted in the column not being displayed by default (as the now-invalid column named 'attachment' was automatically removed) This then hid the fact that $g_show_attachment_indicator was actually not working as advertised, i.e. the attachments column is always displayed; when ON the field contains the paperclip bitmap, and when OFF the actual number of attachments for the corresponding issue. Affects issue 0013276 This is porting d86ba7220b1b5f9b6eab2eaef44f1345e6699df0 to master	Affected Issues 0013276
	mod - config_defaults_inc.php	Diff File
	mod - core/filter_api.php	Diff File
	mod - core/helper_api.php	Diff File
	mod - view_filters_page.php	Diff File
MantisBT: master-1.2.x d86ba722 2011-08-31 01:31 dregad Details Diff	Correct naming of attachments column Commit 97b67e4bbb2f2df5f6fb24eea5b4bb37e1c28acd introduced some changes to the BugData class: the 'attachment' column was renamed to 'attachment_count'. This change was not cascaded everywhere, which resulted in the column not being displayed by default (as the now-invalid column named 'attachment' was automatically removed) This then hid the fact that $g_show_attachment_indicator was actually not working as advertised, i.e. the attachments column is always displayed; when ON the field contains the paperclip bitmap, and when OFF the actual number of attachments for the corresponding issue. Affects issue 0013276 This commit also removes some trailing whitespace	Affected Issues 0013276
	mod - config_defaults_inc.php	Diff File
	mod - core/filter_api.php	Diff File
	mod - core/helper_api.php	Diff File
	mod - view_filters_page.php	Diff File
MantisBT: master ce56bd57 2011-08-31 02:32 dregad Details Diff	Obsolete $g_show_attachment_indicator option Following discussion with dhx on IRC on 31-Aug-2011, this setting is not necessary. There is no point or advantage in displaying a paperclip bitmap as opposed to the actual number of attachments; furthermore, the option was inconsistently used, in one instance it was actually hiding the attachments column completely Affects issue 0013276 Porting 3323204d0c3e6031b182b7113e7afb99d861588d to master	Affected Issues 0013276
	mod - config_defaults_inc.php	Diff File
	mod - core/columns_api.php	Diff File
	mod - core/helper_api.php	Diff File
	mod - core/obsolete.php	Diff File
MantisBT: master-1.2.x 3323204d 2011-08-31 02:32 dregad Details Diff	Obsolete $g_show_attachment_indicator option Following discussion with dhx on IRC today, this setting is not necessary. There is no point or advantage in displaying a paperclip bitmap as opposed to the actual number of attachments; furthermore, the option was inconsistently used, in one instance it was actually hiding the attachments column completely Affects issue 0013276 Commit also removes trailing whitespace in columns_api.php	Affected Issues 0013276
	mod - config_defaults_inc.php	Diff File
	mod - core/columns_api.php	Diff File
	mod - core/helper_api.php	Diff File
	mod - core/obsolete.php	Diff File
MantisBT: master-1.2.x 24a90639 2011-10-22 04:25 atrol Details Diff	Updated documentation to reflect changes after fix 0013276	Affected Issues 0013276
	mod - docbook/adminguide/en/configuration.sgml	Diff File
MantisBT: master 2068b753 2011-10-22 04:28 atrol Details Diff	Updated documentation to reflect changes after fix 0013276	Affected Issues 0013276
	mod - docbook/Admin_Guide/en-US/Configuration.xml	Diff File

View Issue Details

Relationships

Activities

Related Changesets