0014086: Default administrator timezone to server timezone - MantisBT - Signup temporarily disabled due to spam

ID	Project	Category	View Status	Date Submitted	Last Update

0014086	mantisbt	installation	public	2012-03-26 01:10	2014-12-08 02:07

Reporter	vboctor	Assigned To	dregad
Priority	high	Severity	block	Reproducibility	have not tried
Status	closed	Resolution	fixed
Product Version	1.3.0dev
Target Version	1.3.0-beta.1

Summary	0014086: Default administrator timezone to server timezone
Description	The master branch now gives a system notice on logic because the administrator timezone is set to an empty string. The fix should include the following: If timezone is blank, don't set it. Introduce the concept of default timezone, ideally part of the installation. Default administrator's to default/server timezone. When user edits their preference, should have a proper default and not select the first entry. As new users are created, they should use the default time zone.
Tags	No tags attached.

vboctor 2012-03-26 01:41 manager ~0031527	A partial fix was checked in that doesn't set the timezone in case it is empty. This removes the system notice.

dregad 2012-11-14 10:05 developer ~0034312	Setting default_timezone to date_default_timezone_get() will block Mantis with PHP 5.4 if date.timezone is not properly defined in php.ini, due to the system warning triggered by PHP in this case (as the function no longer falls back to querying the OS for the default tz): Warning: date_default_timezone_get(): It is not safe to rely on the system's timezone settings. You are required to use the date.timezone setting or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier. We selected the timezone 'UTC' for now, but please set date.timezone to select your timezone. in /path/to/mantisbt/config_defaults_inc.php on line 1141 I think commit 15c23b1a should be reverted, as well as the changes to core.php made by dhx in ba97560b. IMO, the default timezone should be set in core.php as it was in 1.2.x.

dregad 2012-11-14 11:00 developer ~0034315	Victor, I have applied what I believe is a better fix for this issue; as I'm not sure exactly what test case you ran initially, I would appreciate your letting me know if the original issue you reported still exists. I also opened 0015205 to track your suggestion to improve the installer.

grangeway 2013-04-05 17:56 reporter ~0036140	Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch

MantisBT: master d4508697 2012-03-25 18:31 vboctor Details Diff	Issue 0014086: Default administrator timezone to server timezone. (partial fix).		Affected Issues 0014086
	mod - core.php		Diff File
MantisBT: master 15c23b1a 2012-05-06 08:15 vboctor Details Diff	Fixes 0014086: Default administrator timezone to server timezone. The timezone is now defaulted to date_default_timezone_get() rather than empty string which defaults to date_default_timezone_get() in some code paths. This fixes the issue where user preferences picked up the first in the list rather than the default timezone.		Affected Issues 0014086
	mod - config_defaults_inc.php		Diff File
MantisBT: master fc67be88 2012-11-14 10:14 dregad Details Diff	Revert "Fixes 0014086: Default administrator timezone to server timezone." This reverts commit 15c23b1a71fe92839c3f0f2c75c882cec16d051d.		Affected Issues 0014086
	mod - config_defaults_inc.php		Diff File