0015556: Bugnotes can't set to public with PostgreSQL when the user access level >= private_bugnote_threshold - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update
0015556	mantisbt	db postgresql	public	2013-03-01 02:22	2014-05-16 15:02

Reporter	schoppi71	Assigned To	dregad
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	unable to reproduce
Platform	VM-Ware	OS	SuSe Linux Enterprise Server	OS Version	10
Product Version	1.2.14

Summary	0015556: Bugnotes can't set to public with PostgreSQL when the user access level >= private_bugnote_threshold
Description	The parameter $p_private of the function bugnote_add() in bugnote_api.php is changed to $c_private by the function call db_prepare_bool( $p_private ). In line 175 is $c_private checked instead of $p_private. $c_private is always true because of the change in the databas_api.php function db_prepare_bool. Bugfix: Use $p_private.
Tags	No tags attached.

dregad 2013-03-01 06:04 developer ~0035338	schoppi71, I see no reference to $c_private in bugnote_add function. line 175 is blank assuming you meant line 170, it correctly references $p_private [1] (and has done since at least 1.2.0a1 In fact, $c_private is initialized but never used; I'll remove it. This begs the question, is this really on 1.2.14, and if yes, are you maybe running non-standard code ? [1] https://github.com/mantisbt/mantisbt/blob/release-1.2.14/core/bugnote_api.php#L170

schoppi71 2013-03-01 06:48 reporter ~0035342	Hi dregad, yes the source was changed by us (2011/3/9 13:1:16) but it wasn't a problem since we upgraded to 1.2.14. Sorry for that and thank you for your support. Regards, Schoppi71

dregad 2013-03-01 07:35 developer ~0035344	Ok. In future, when using custom code, please always double-check issue against standard prior to reporting, thanks in advance.

grangeway 2014-05-16 15:02 reporter ~0040513	MantisBT currently supports Mysql and has support for other database engines. The support for other databases is known to be problematic. Having implemented the current database layer into Mantis 10 years ago, I'm currently working on replacing the current layer. If you are interested in using Mantis with non-mysql databases - for example, Oracle, PGSQL or MSSQL, and would be willing to help out testing the new database layer, please drop me an email at paul@mantisforge.org In the meantime, I'd advise running Mantis with Mysql Only to avoid issues. Thanks Paul

MantisBT: master e49ddce2 2013-03-01 06:00 dregad Details Diff	Issue 0015556: remove unused variable $c_private is initialized but never used in bugnote_add()'s scope.		Affected Issues 0015556
	mod - core/bugnote_api.php		Diff File
MantisBT: master-1.2.x a8828a36 2013-03-01 06:00 dregad Details Diff	Issue 0015556: remove unused variable $c_private is initialized but never used in bugnote_add()'s scope.		Affected Issues 0015556
	mod - core/bugnote_api.php		Diff File