View Issue Details

IDProjectCategoryView StatusLast Update
0016010mantisbtotherpublic2014-12-08 02:07
ReporterKirill Assigned Tovboctor  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.3.0dev 
Target Version1.3.0-beta.1 
Summary0016010: Deleted "unused" variable. Fix issue 15556
Description

https://github.com/mantisbt/mantisbt/commit/e49ddce2e24e6ba21950eb76541e5690645de9fd
removed variables for branch master-1.2.x and master, but in master variable
$c_private used in line 191
https://github.com/mantisbt/mantisbt/blob/master/core/bugnote_api.php#L191

Tagspatch
Attached Files
issue16010.patch (863 bytes)   
From 5b810665a83e204e2f0ce933310b4959438935d1 Mon Sep 17 00:00:00 2001
From: Kirill Krasnov <krasnovforum@gmail.com>
Date: Wed, 5 Jun 2013 09:45:08 +0300
Subject: [PATCH] Fix #16010

---
 core/bugnote_api.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/bugnote_api.php b/core/bugnote_api.php
index 1dc6e51..3d6ad47 100644
--- a/core/bugnote_api.php
+++ b/core/bugnote_api.php
@@ -188,7 +188,7 @@ function bugnote_add( $p_bug_id, $p_bugnote_text, $p_time_tracking = '0:00', $p_
 	}
 
 	# Check for private bugnotes.
-	if( $c_private && access_has_bug_level( config_get( 'set_view_status_threshold' ), $p_bug_id, $c_user_id ) ) {
+	if( $p_private && access_has_bug_level( config_get( 'set_view_status_threshold' ), $p_bug_id, $c_user_id ) ) {
 		$t_view_state = VS_PRIVATE;
 	} else {
 		$t_view_state = VS_PUBLIC;
-- 
1.8.3.msysgit.0

issue16010.patch (863 bytes)   

Relationships

related to 0015556 closeddregad Bugnotes can't set to public with PostgreSQL when the user access level >= private_bugnote_threshold 

Activities

Related Changesets

MantisBT: master ee1b6d64

2013-06-04 23:00

Kirill


Details Diff
Fix 0016010 change variable Affected Issues
0016010
mod - core/bugnote_api.php Diff File

MantisBT: master c4f2d6c1

2013-06-04 23:09

vboctor


Details Diff
Merge pull request #87 from Kirill/issue16010

Fixes 0016010: remove usage of undeclared variable.
Affected Issues
0016010
mod - core/bugnote_api.php Diff File