View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0024192||mantisbt||bugtracker||public||2018-03-30 15:51||2018-05-23 04:50|
|Target Version||2.14.0||Fixed in Version||2.14.0|
|Summary||0024192: Update ADOdb to 5.20.12|
The latest release of ADOdb fixes PHP 7.2 compatibility issues (see 0024174) and addresses a couple security issues (not affecting MantisBT directly though)
|Tags||No tags attached.|
@atrol I've targeted 2.13.0 because of the PHP 7.2 compatibility issue, but I let you decide if you want to merge it now to get the fix in quickly, or delay until 2.14.0 to get more test time with the new ADOdb (changes since 5.20.9 are fairly minor, but you never know)
@dregad I made some cursory tests (just MySQL) with different PHP versions (5.6, 7.1, 7.2) and did not encounter any problem until now.
But the ADOdb changes are not enough to get a full PHP 7.2 compatibility.
So on the one hand we don't have to rush to merge the PR, but on the other hand we should also be aware that Ubuntu 18.04 LTS will come with PHP 7.2 and will be released 26th April.
I did. Remaining errors are not related to ADOdb, but I didn't have time to look into the root cause.
Found this in .travis.yml
Seems we should use PHPunit 6 as PHP 7.2 is not supported in PHPunit 5, see https://phpunit.de
Resolved after changes to fix 0024462
|2018-03-30 15:51||dregad||New Issue|
|2018-03-30 15:51||dregad||Status||new => assigned|
|2018-03-30 15:51||dregad||Assigned To||=> dregad|
|2018-03-30 15:52||dregad||Relationship added||related to 0024174|
|2018-03-30 16:08||dregad||Note Added: 0059371|
|2018-03-30 16:11||dregad||Note Added: 0059373|
|2018-03-30 17:32||atrol||Note Added: 0059375|
|2018-03-30 19:24||dregad||Note Added: 0059378|
|2018-03-31 16:58||atrol||Note Added: 0059385|
|2018-03-31 20:06||vboctor||Target Version||2.13.0 => 2.14.0|
|2018-03-31 20:07||vboctor||Changeset attached||=> MantisBT master fd9b9b3c|
|2018-03-31 20:07||dregad||Status||assigned => resolved|
|2018-03-31 20:07||dregad||Resolution||open => fixed|
|2018-03-31 20:07||dregad||Fixed in Version||=> 2.14.0|
|2018-04-29 19:21||vboctor||Status||resolved => closed|
|2018-05-23 04:50||atrol||Note Added: 0059919|